From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f51.google.com (mail-wg0-f51.google.com [74.125.82.51])
 by dpdk.org (Postfix) with ESMTP id D0B685A74
 for <dev@dpdk.org>; Thu,  5 Mar 2015 10:52:31 +0100 (CET)
Received: by wggy19 with SMTP id y19so52193063wgg.10
 for <dev@dpdk.org>; Thu, 05 Mar 2015 01:52:31 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=m0SUPggO7ReKsUwKx+pUuzq6ZzzSUH4hLb7z3J1bQ1g=;
 b=I9cOwZEBp46ayuKbpGKsHEvQ2FOcjgi1qYYawkc1UHhuvR5n3BPwHejeZUW7BAmC/K
 oQoJHznQZEwrB4Nhw8TEwQ6TmJDtubpqSR62G8JD6kw9DF7QICl34/Ti56nE1IaCI3IC
 e4kVe27ZVC/c4ejsYBxQjTdS9xofbvm6Xmh0x3ShU/Ehg7zeENXuaotKjJ7WiroPeGUM
 p0JPHigGSQnUue77ET5LzS/Url/6L7cBU9NC9py2vjW5l8SlXQS5rXfg7wTvT/xXuGNP
 WYi/Jurl0RdGHvaDKEgH0Cmge1kEWlH0T3x1u+N9PfSVuRTJvYfFsSz8ue1I4VOGbWFb
 A7FQ==
X-Gm-Message-State: ALoCoQm0cYaJPtpGANcmde/5iljoUKwdTbSyf/y7VgqnHCcdLxULjA+jaABbTiyjcmTeC2iKF3Zl
X-Received: by 10.180.80.34 with SMTP id o2mr63829835wix.75.1425549151592;
 Thu, 05 Mar 2015 01:52:31 -0800 (PST)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id fm10sm10863856wib.7.2015.03.05.01.52.30
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 05 Mar 2015 01:52:30 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Qiu, Michael" <michael.qiu@intel.com>
Date: Thu, 05 Mar 2015 10:51:57 +0100
Message-ID: <8539092.UnIgVbWq12@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; )
In-Reply-To: <533710CFB86FA344BFBF2D6802E60286CEED33@SHSMSX101.ccr.corp.intel.com>
References: <1425372295-27839-1-git-send-email-thomas.monjalon@6wind.com>
 <1637153.LCrn9VkBbJ@xps13>
 <533710CFB86FA344BFBF2D6802E60286CEED33@SHSMSX101.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal/linux: fix build
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Mar 2015 09:52:32 -0000

Hi Michael,

2015-03-05 09:13, Qiu, Michael:
> On 3/4/2015 6:24 AM, Thomas Monjalon wrote:
> >>> Compilation fails in some distributions because of missing unistd=
.h
> >>> needed for pread/pwrite (seen with Suse):
> >>>         lib/librte_eal/linuxapp/eal/eal_pci_uio.c:62:2:
> >>>         error: implicit declaration of function =E2=80=98pread=E2=
=80=99
> >>>
> >>> Fixes: 4a499c649590 ("eal/linux: enable uio_pci_generic support")=

> >>>
> >>> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> >> Acked-by: David Marchand <david.marchand@6wind.com>
> > Applied
>=20
> Hi, Thomas
>=20
> This patch may be need to be reverted, as the error still exists.

No I don't think it should be reverted. It must be completed.

[...]
> NAME
>        pread, pwrite - read from or write to a file descriptor at a
> given offset
>=20
> SYNOPSIS
>        #define _XOPEN_SOURCE 500
>=20
>        #include <unistd.h>
[...]
> While I try to add marco #define _XOPEN_SOURCE 500

I think that the good thing to do.

> Other errors show up

Are they hard to fix?

> Who knows how to solve this issue?