From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 04058316B for ; Thu, 17 Jan 2019 18:26:17 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id D61C3145A; Thu, 17 Jan 2019 12:26:15 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 17 Jan 2019 12:26:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=mJxnvvxXTJ7weCeRGIysVsky8o5WuXO1Gl1EzvqCDpY=; b=TdUrQKyRHweX /BjkUM705ZhwJ77VlKqzkZJIiUDkcrwmSNN7yhLKDTMhI+AVOLgFBytXqUnpGKS7 IZ2rIDrjN1+vtoG9IJsEHJZx4lRR+n9LN5WGAVYtqYhCtE1STJvCKRSSPp8h3Ki/ vb73KuqBuWj8OHIFkI5Rh3LODzRTlKQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=mJxnvvxXTJ7weCeRGIysVsky8o5WuXO1Gl1EzvqCD pY=; b=Q0Yjb+rlBsh0qDQkcyJlPrChLfwuE1JEmvCqx/Amc4aIa0HOme8BtmG4N SK+m+YLxXtF24+tehHjTQauvYFdtHcUTaHTcyoNzj2bGbtic+xhIJjgE6RcbFIKU 03nPbC2sV+LWa8WcgIG2s+G1xmiLC5UHvzbq1uWr7RQv/9XWNK1fc2R/ObI8nEbX 4IuG6+4ynBMnbeIktioC53elWoI+9jLpDVvDMzHVlXMlFwGCw8kAvx2Mpe4EoFEy JztKQ/fX+GUw6JNz8F8LfY79wzp/a+UODjpKjK3TwvB3aXtSmuO7Fz+3Aki3bMGE XzpUj4qlNoJia9bT+A8xIliZSXUcQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrgeekgdeliecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecufedt tdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufffkfgjfh gggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceo thhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvddtfe drudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id ED55710085; Thu, 17 Jan 2019 12:26:13 -0500 (EST) From: Thomas Monjalon To: David Hunt , liang.j.ma@intel.com Cc: dev@dpdk.org, lei.a.yao@intel.com Date: Thu, 17 Jan 2019 18:26:12 +0100 Message-ID: <8559866.tXW0UHnbt0@xps> In-Reply-To: <20190115100137.47470-1-david.hunt@intel.com> References: <1545996779-4098-1-git-send-email-liang.j.ma@intel.com> <20190115100137.47470-1-david.hunt@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] libs/power: fix the resource leaking issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jan 2019 17:26:17 -0000 15/01/2019 11:01, David Hunt: > From: Liang Ma > > Fixes: e6c6dc0f96c8 ("power: add p-state driver compatibility") > Coverity issue: 328528 > > v2: focus just on the resource leak. Remove additional code around > Turbo Boost frequency handling. > > Signed-off-by: Liang Ma > Reviewed-by: Lei Yao > Tested-by: Lei Yao > Signed-off-by: David Hunt > --- > --- a/lib/librte_power/power_pstate_cpufreq.c > +++ b/lib/librte_power/power_pstate_cpufreq.c > f_max = fopen(fullpath_max, "rw+"); > + > + if (f_max == NULL) > + fclose(f_min); No need to insert a blank line before "if". Removing on apply. Applied, thanks