From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 731D3A0C41; Thu, 16 Sep 2021 17:51:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 10FE6407FF; Thu, 16 Sep 2021 17:51:11 +0200 (CEST) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by mails.dpdk.org (Postfix) with ESMTP id 6B7514069E for ; Thu, 16 Sep 2021 17:51:09 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id E10B0580C2C; Thu, 16 Sep 2021 11:51:08 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 16 Sep 2021 11:51:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= Wl+IZgfNhOabxD0h6a8qN/xPPIOoq2tQysIIeEneMCs=; b=XOTCoL9YNhDArSYD IhwOykQBnF5AuHIbN+y0jk1zuYa28hmdK/kPW2f98adpdXcZd78onvkHwqFxBP5b oEW9Kt0OsuffgXTBjz2J9vKfIYyi2G7hqMMNtrldFrhvPBRyvvdVS908DQcglD4I yen9U7/91uViRPpn3/VzNCw8hT372ei4ZIuC5lIbIXgOmEwCCWa3sHTek1sYE6Zd 5JvxZjnb42JpK+s1qXIJSde2oMLlu35JqFrgl0xMXofn8RW71ST6RNjGaEQS+0RW 5RNG+yw1NGDo5yohrah84ZYq73Hjn3vmnu8jHMj3IIUV8p9wdxQmvng71S6SS9rc FAxQXA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=Wl+IZgfNhOabxD0h6a8qN/xPPIOoq2tQysIIeEneM Cs=; b=khedObHgKce7fITg4ch/ozmQneKRYh+Ev+MLkJQL1vr3zoRInh1xmVlmS bT5jfc+k9ilTNmtiLr9Ebv5yKprM3RjxfTmjW86SxyHtcmvrdtWqPurH8eeJ2vaI Lw8nFNJNxvLt1I3psxgIpbY0gmHynfR6RKU7Qsn7dE3X69w9Me2uI3hAUHO1RfJs Eqnp+/PjMA59x8gyMr6pMTLaiwFolPAfIuMk91BUqVsQ3fMud+xvFHU5F6vyOwNt N51eoAkoGHPKkQTGgGtApEe0P7PyNkd0XTplW68wUtaiQ7UPIcCQUu/fEzSdkT7l viRzIqb8xJ4QQutv9XmdZnbtW7vUQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudehgedgkeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 16 Sep 2021 11:50:58 -0400 (EDT) From: Thomas Monjalon To: "Xueming(Steven) Li" Cc: "zhouguoyang@huawei.com" , "mczekaj@marvell.com" , "radhac@marvell.com" , "bruce.richardson@intel.com" , "sthotton@marvell.com" , Matan Azrad , "kirankumark@marvell.com" , "linville@tuxdriver.com" , "beilei.xing@intel.com" , "rmody@marvell.com" , "dev@dpdk.org" , "vburru@marvell.com" , "somnath.kotur@broadcom.com" , "jiawenwu@trustnetic.com" , "chenbo.xia@intel.com" , "heinrich.kuhn@corigine.com" , "hemant.agrawal@nxp.com" , "maxime.coquelin@redhat.com" , "asomalap@amd.com" , "yongwang@vmware.com" , "andrew.rybchenko@oktetlabs.ru" , "skori@marvell.com" , "ajit.khaparde@broadcom.com" , "hkalra@marvell.com" , "shaibran@amazon.com" , "chas3@att.com" , "cloud.wangxiaoyun@huawei.com" , "sthemmin@microsoft.com" , "jerinj@marvell.com" , "qiming.yang@intel.com" , "pnalla@marvell.com" , "srinivasan@marvell.com" , "mk@semihalf.com" , "mw@semihalf.com" , "xiao.w.wang@intel.com" , "keith.wiles@intel.com" , "xuanziyang2@huawei.com" , "mtetsuyah@gmail.com" , "qi.z.zhang@intel.com" , "ciara.loftus@intel.com" , "g.singh@nxp.com" , "aboyer@pensando.io" , "steven.webster@windriver.com" , "evgenys@amazon.com" , "humin29@huawei.com" , "spinler@cesnet.cz" , "johndale@cisco.com" , "irusskikh@marvell.com" , "dsinghrawat@marvell.com" , "shshaikh@marvell.com" , "oulijun@huawei.com" , "ferruh.yigit@intel.com" , "lironh@marvell.com" , Slava Ovsiienko , "aman.deep.singh@intel.com" , "sachin.saxena@oss.nxp.com" , "rahul.lakkireddy@chelsio.com" , "matt.peters@windriver.com" , "jianwang@trustnetic.com" , "skoteshwar@marvell.com" , "rosen.xu@intel.com" , "zr@semihalf.com" , "jingjing.wu@intel.com" , NBU-Contact-longli , "yisen.zhuang@huawei.com" , "igorch@amazon.com" , "grive@u256.net" , "haiyue.wang@intel.com" , "jgrajcia@cisco.com" , "hyonkim@cisco.com" , "ndabilpuram@marvell.com" Date: Thu, 16 Sep 2021 17:50:56 +0200 Message-ID: <85886773.1W8YL658bg@thomas> In-Reply-To: <286d36d191dfbde87213191a217eb861b6196b99.camel@nvidia.com> References: <20210727034134.20556-1-xuemingl@nvidia.com> <16158406.yydg6pnXu9@thomas> <286d36d191dfbde87213191a217eb861b6196b99.camel@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] ethdev: change queue release callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 16/09/2021 17:43, Xueming(Steven) Li: > On Thu, 2021-09-16 at 10:09 +0200, Thomas Monjalon wrote: > > 15/09/2021 15:02, Xueming Li: > > > --- a/lib/ethdev/rte_ethdev.c > > > +++ b/lib/ethdev/rte_ethdev.c > > > - RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_release, -ENOTSUP); > > > > Why removing this check? > > It is changing the behaviour. > > Some PMD implemented a dummy callback, so I think maybe it good to make > this callback optional to make PMD clean, how do you think? I agree but it should be a separate patch.