From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 10E70A034C;
	Tue, 18 Aug 2020 10:05:33 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 103851C020;
	Tue, 18 Aug 2020 10:05:32 +0200 (CEST)
Received: from mail.chinasoftinc.com (unknown [114.113.233.8])
 by dpdk.org (Postfix) with ESMTP id 1E02B14581
 for <dev@dpdk.org>; Tue, 18 Aug 2020 10:05:29 +0200 (CEST)
Received: from [192.168.1.199] (139.159.243.11) by INCCAS001.ito.icss
 (10.168.0.60) with Microsoft SMTP Server id 14.3.487.0; Tue, 18 Aug 2020
 16:05:27 +0800
To: Jerin Jacob <jerinjacobk@gmail.com>
CC: Ruifeng Wang <Ruifeng.Wang@arm.com>, "dev@dpdk.org" <dev@dpdk.org>,
 "xavier.huwei@huawei.com" <xavier.huwei@huawei.com>, nd <nd@arm.com>,
 Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
References: <20200817124703.58157-1-huwei013@chinasoftinc.com>
 <20200818024355.23364-1-huwei013@chinasoftinc.com>
 <HE1PR0801MB2025B666B290DB3E309312599E5C0@HE1PR0801MB2025.eurprd08.prod.outlook.com>
 <CALBAE1Ob2sroj+mR8KHsdD0hNvuzqU2hNBh6H5xpxbCRvPCvBg@mail.gmail.com>
From: "Wei Hu (Xavier)" <huwei013@chinasoftinc.com>
Message-ID: <859efea3-7962-e264-2d6d-2fb7ba95c0f8@chinasoftinc.com>
Date: Tue, 18 Aug 2020 16:05:26 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101
 Thunderbird/68.11.0
MIME-Version: 1.0
In-Reply-To: <CALBAE1Ob2sroj+mR8KHsdD0hNvuzqU2hNBh6H5xpxbCRvPCvBg@mail.gmail.com>
Content-Language: en-US
X-Originating-IP: [139.159.243.11]
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH v3] eal/arm64: update CPU flags
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi, Jerin Jacob

On 2020/8/18 13:07, Jerin Jacob wrote:
> On Tue, Aug 18, 2020 at 9:11 AM Ruifeng Wang <Ruifeng.Wang@arm.com> wrote:
>> Hi,
>>
>>> -----Original Message-----
>>> From: Wei Hu (Xavier) <huwei013@chinasoftinc.com>
>>> Sent: Tuesday, August 18, 2020 10:44 AM
>>> To: dev@dpdk.org
>>> Cc: xavier.huwei@huawei.com; nd <nd@arm.com>; Honnappa Nagarahalli
>>> <Honnappa.Nagarahalli@arm.com>; Ruifeng Wang
>>> <Ruifeng.Wang@arm.com>; jerinjacobk@gmail.com
>>> Subject: [PATCH v3] eal/arm64: update CPU flags
>>>
>>> From: "Wei Hu (Xavier)" <xavier.huwei@huawei.com>
>>>
>>> SVE is the next-generation SIMD extension of the ARMv8-A AArch64
>>> instruction set.
>>> The related marco definition can be found in linux kernel:
>>>    arch/arm64/include/uapi/asm/hwcap.h
>>>
>>> This patch updates cpu SVE flags on ARM64 platform, such as SVE, etc.
> Suggested rewording:
>
> ARM64 Linux kernel updated the CPU flags using the HWCAP scheme.
> This patch incorporates those changes to the eal library.
>
Ok, I will update it in V4.
>>> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
>>> Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
>>> ---
>>> v2 -> v3:
>>>        1. Change commit log.
>>>        2. Add HWCAP2_FLAGM2 and HWCAP2_FRINT to
>>> rte_cpu_feature_table[].
>>>        3. Add the flags for newly added items into enum rte_cpu_flag_t.
>>> v1 -> v2:
>>>        Adds more sve-related definition to rte_cpu_feature_table,
>>>        sunch as SVE2, etc.
>>> ---
>>>   lib/librte_eal/arm/include/rte_cpuflags_64.h | 13 +++++++++++++
>>>   lib/librte_eal/arm/rte_cpuflags.c            | 13 +++++++++++++
>>>   2 files changed, 26 insertions(+)
>>>
>> How about updating test_cpuflags() too to cover these new flags?
> +1 . Wei, Please update the test_cpuflags() functions for new flags.

OK, I will update this test function in V4.


Thanks

Xavier