From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 7E798101B for ; Mon, 4 Sep 2017 23:34:40 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Sep 2017 14:34:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,476,1498546800"; d="scan'208";a="125510711" Received: from ewright1-mobl3.ger.corp.intel.com (HELO [10.252.24.105]) ([10.252.24.105]) by orsmga004.jf.intel.com with ESMTP; 04 Sep 2017 14:34:38 -0700 To: Markus Theil , dev@dpdk.org Cc: stephen@networkplumber.org, nicolas.dichtel@6wind.com References: <1503336825-7700-1-git-send-email-markus.theil@tu-ilmenau.de> <1504549066-11067-1-git-send-email-markus.theil@tu-ilmenau.de> <1504549066-11067-3-git-send-email-markus.theil@tu-ilmenau.de> From: Ferruh Yigit Message-ID: <85a270e6-2f45-7b64-52b3-da6a9935fee7@intel.com> Date: Mon, 4 Sep 2017 22:34:37 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1504549066-11067-3-git-send-email-markus.theil@tu-ilmenau.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6 3/5] igb_uio: fix MSI-X IRQ assignment with new IRQ function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Sep 2017 21:34:41 -0000 On 9/4/2017 7:17 PM, Markus Theil wrote: > The patch which introduced the usage of pci_alloc_irq_vectors > came after the patch which switched to non-threaded ISR (f0d1896fa1), > but did not use non-threaded ISR, if pci_alloc_irq_vectors > is used. > > Fixes: 99bb58f3adc7 ("igb_uio: switch to new irq function for > MSI-X") > Cc: nicolas.dichtel@6wind.com > > Signed-off-by: Markus Theil > --- > lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > index 9bb74b2..6885e72 100644 > --- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > +++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > @@ -323,6 +323,7 @@ igbuio_pci_enable_interrupts(struct rte_uio_pci_dev *udev) > msix_entry.entry = 0; > if (pci_enable_msix(udev->pdev, &msix_entry, 1) == 0) { > dev_dbg(&udev->pdev->dev, "using MSI-X"); > + udev->info.irq_flags = IRQF_NO_THREAD; This should be in #else part (pci_alloc_irq_vectors() call one), I guess when issue in patch 2/5 fixed, this patch also will be correct. > udev->info.irq = msix_entry.vector; > udev->mode = RTE_INTR_MODE_MSIX; > break; >