From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 948AF43B4B; Mon, 19 Feb 2024 14:41:21 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4558740289; Mon, 19 Feb 2024 14:41:21 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by mails.dpdk.org (Postfix) with ESMTP id 98C6540275 for <dev@dpdk.org>; Mon, 19 Feb 2024 14:41:20 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N5RX/Drij5ia/gB1qdPwwNrodPVP0rgOFYlh3aEVuwosUlDvJVpqZYrgL91Wd8btjB67l0ZZNaMpKCLAOqviyu/CUJdPITerG75IjPcdQCKh+hG38yApj/AOkx1c478VCmdGYVwQ73zgJTEtkC/cBEZD43S2c1Ra0WrkJqu8JjSQfZ3GQvNJBW34+oJ0rZWYn07z9wd55fWGVbAqc4RB1xUgxBhNzCk77td5axqt/R3FNsG7IjRUigc9+Pv/55IfUXvm31dEesFwzRlEATljIHsSuUXWZd2cP+zYmpZuoYgsiqA6OJjTaWvBkqqXyXxMLva4fuWjfML8b7u7GZ7UgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uyMqM5bI5DThjUXTOLj+cLwPrRSPcfY+e3aNl1hz6BA=; b=BTj3/dez6CNEaucWwMZQik+HYFU8vJYC33FYMRnO/hiv0ktopDA33oyIQGf16z/C/7bQvt/pKHALkTfQxekHfCosYOfEfvR/3AtlT98dMT198fpqYuuNMxnkneFVkwT321kenw6iXBvKC00TZX/mnkjhOh+Wsb6qFfHuWy8pNm+cSXI76yOhA7JtVHvIZw3961m9VuYuqAmZulfGIVFgzNhNDD+MbER1NF1y1BnULVBwFQbMveGcbk8Zpp4fs5TiRKAWzb0hDfhmcZ+u4B4JPav+iRaCQ45MoRbDLp7dU59x6H6lYJMK/NnW9dMJcZV0EZ3A2Nl+LErGYojqYNIjlA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uyMqM5bI5DThjUXTOLj+cLwPrRSPcfY+e3aNl1hz6BA=; b=QX634xQkDMQpirbjQqrgZJE8q405Ma0GAJV7+x2rVcoRhtAQ/3OC2C7tZ2L7Gqmcsf4el5nGSUEsEKxml9ST6dzhNootfyON4wiDstnklzmlveJEH3pOltYYP34v0LdJksNnLbpHziAOphh5ghjQDAx70PJmdRWx7gl8NMT8KyM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DS0PR12MB7780.namprd12.prod.outlook.com (2603:10b6:8:152::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.19; Mon, 19 Feb 2024 13:41:18 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529%5]) with mapi id 15.20.7316.018; Mon, 19 Feb 2024 13:41:18 +0000 Message-ID: <85ac4c1d-6801-46e4-a337-01f1b47cd05d@amd.com> Date: Mon, 19 Feb 2024 13:41:14 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net/nfp: add support of UDP fragmentation offload Content-Language: en-US To: Chaoyong He <chaoyong.he@corigine.com>, dev@dpdk.org Cc: oss-drivers@corigine.com, Long Wu <long.wu@corigine.com>, Peng Zhang <peng.zhang@corigine.com> References: <20240217015410.2163102-1-chaoyong.he@corigine.com> From: Ferruh Yigit <ferruh.yigit@amd.com> Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240217015410.2163102-1-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DUZPR01CA0310.eurprd01.prod.exchangelabs.com (2603:10a6:10:4ba::10) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DS0PR12MB7780:EE_ X-MS-Office365-Filtering-Correlation-Id: 42a468d8-7683-4af6-b4bf-08dc31507384 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zPXcLShmrgVM+yRN89qG5aVGvjFDJdAb4TOw5IClbQw/lMLvCH/clw088PTBji1NysYRlGM8knAdNGQ23wAX2E7eqv1OZxsN2CkjJhOj90uxUXJFYpMCj8UYLtNaD/oKu5uErNOAWKtn2UMuE3cN3GhJAqkJrsHpmbG/AvuTVOcVoKOXdfBJoNZEKLCO+Kzcf0fPdVwgKhbEG5rEv956duvtW9L/29J/pYTh/uXaewEFAyyxEGJv9gh2Ry3awZitm4u9FzNqcsPcB1zvmjZwJbxk8Dou8zfbO/8IPsO/+cIHPwBhA43VlWpj/fiLGe1kPZtRuEn9f1Kq1KngNrCCczCgcsB0WsdD7v7UpYLIeOn/xflEMs0cOUsLBYDu973WGchLUIYzBfngdJxCUZ1hyiPV9ICGBD607Ed9ASxbYvL7BiToJXlieTjRU+jWTsW8IybdxNSFAundmnELAeLFF56IRNuU4/T7zIMoZ9dS9zUE7pBmcDqqLO38TjWjR2h/dMbV2F7e6gmd/ix9EYm3IUM4VBe7wvZ9ptEd75cZSEw= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dXJsZmlTS1kzRmlJYXFkM1dRckF1a1A3ZStacWFPSXZCTmUxUFZFNFB3QWY2?= =?utf-8?B?L042RHZUc2pXMmkxa0liWmZaVkN1NXZPNFp5dmt5QkVRWmFOa2RCaTZYTldW?= =?utf-8?B?dTVlMHUrTGgybzlmNndRTUZNV3hleFAwK2JNSUxIQWZRRDFSS3pjVURPTHVK?= =?utf-8?B?blc3U0o2eTBYSFBneEtFbThEUUQ4MHR1eURnNmR5N2R4U2M2MHdQRHgwTmdJ?= =?utf-8?B?OUl5cHdlRVZwaUFITXV4SmtoVTVUTmRiMmlNVnF0eStPVnlLRjVvSlNnZC9I?= =?utf-8?B?N0s0SzZKSEJSbDRTbE1rUG1zdFg5VXV5Y2VtdGR1eWZQWFo5NDRxUUk0c2lZ?= =?utf-8?B?elRxeTNwUGg4TUg5czBYOFcrc0RTcUN5Z1huZWVZSUtCSzBYMHgxRFBsQlAr?= =?utf-8?B?S2wrTnpSS3pGd2tORWhwK0ZmWHdraG00cmJEUUxXTVBtS1o5RFVtTTlzOWJN?= =?utf-8?B?YUNyaTVNaS83bjdTRkxRTkxISU0xZndOMm45Um9VcmxPTUpsMGc5QXdHS3VR?= =?utf-8?B?bjNrSUdIZUlhZldEa0swSU5iUkhqdGs1RWhvOWU4TVJmNXhaOUlZZW93UFV0?= =?utf-8?B?Syt3TzdrY2FRUWdJWkI3cWZCK0VFZy9KRFZ0cm1XdHYzZndsRjl6M2pVL0dJ?= =?utf-8?B?ay8rc2RZRkJqS04yUWdDQmo5Y2xqWWhZMWVMTnV3WnhYYzExSG1SdmxzeTZE?= =?utf-8?B?SEpvTHVxYm8zU21xODl1emdJNlQvZHcxK28wa0ZUV0hRQlZ6QlFicjRId0pQ?= =?utf-8?B?Z3FMRHU1SnZwSXI2N2pPei85dWlOSkpNUm9ubEYyN29BN0duRDZXUnhyVTRn?= =?utf-8?B?QU5ZQm1KNzVIWW5yYzdCSTgzTVpoM3Y4WldmK1JYdkxtWEgrQmtFQVRGSGpG?= =?utf-8?B?WHhPbkNGdWs1elFiaWpLc1hkeUc4RWlqaVA3djRQdk5GM3dkV3BRcFpCRlVx?= =?utf-8?B?N2xtMks2dUl0OGlyRndFdVJOU09udDFFdlFyK0tQRU1QeVpGVVlPVE1SUjdu?= =?utf-8?B?bWFuLytqcTI3RFNDQzQ5UkNEM3IvcjVTSlRSbzNmOEtvQXN3QTIyTXFaaEZV?= =?utf-8?B?dWdsd2VIR2F6em50TkIzb2Z6TVhPeGNnSEQrSWExQW5xVjdJajBVRXJmY0NS?= =?utf-8?B?bVpEV2J1V29QZGs2MGUrMmNzSG1uaCt5TEhoNFpjT2V2bXZ3d3VpOUUwKzQ4?= =?utf-8?B?YXZtVW5qczBCQVpiaXplWGxjNHN3eFBlMVhyMHdzUEJ3QWhNSExZSlVKRkhE?= =?utf-8?B?aXdjUWpkZk1nTmQ0QVpDd09raXUxS1RmR3FwcGYzZnk5WEVTM3NlVmpCdTRo?= =?utf-8?B?TG85UFh6cDlBeE42R2JvNGRibjhzSllmSG5xQjRQajJjYkNBRnc4M0dIL1hV?= =?utf-8?B?K1N4bVpNZXp4K0thTkJFTjZIc2dQdkFkYlphQ20vYWhMd1ZJOHZJT3BhcFlJ?= =?utf-8?B?bDNORjc4NVUyS0tXN3VLNTVObi9sdmErWG1ZcWlZZFZBV2NueCtDNnFvU01w?= =?utf-8?B?Z016TW1DWm5MZjZqWXRVdDdGblRzTjFPVXZmc3FXcEVTb3o1ZWorczNHQUVu?= =?utf-8?B?aXlvUDcwOFRHVDZOSUlwUEwwTExUUG5wM2RDZnBSYjc5aGV6Tm5WS2gyV3Ro?= =?utf-8?B?TEkvd1d5N1FZRFozZWlqRTlzVmFEM3hBMkxvY2xGbUt6K3hqbk5WUS9OMm4x?= =?utf-8?B?aXlNNElNTVh0cXB3SGhHd0RUK2V3T1JlY2MxNUpPSTJkYnB1aEdPK2g2b1la?= =?utf-8?B?UkZ0RlA3cjZtOHQ4T0ZuRmkvQlNOcGJVdDlqbWo3QnJDY1YyaTJmUTR3MGQ1?= =?utf-8?B?cmlJMW9hSGhZcHRZODd0U0JSOS8wUkVuV09aSTRaTGpIWlhTVUFmNHRiMjcx?= =?utf-8?B?bVJ1c202OXdkcmp6RlAyUncrOENPRzV3QWtwNzVMMXdZVHBIcmZuR1lNZDBq?= =?utf-8?B?czhSK0d4UDRlSTRTYkJmdFJyUkNmTWxsN1E3UE1Mb0p2eElNT3ZweW04VlBD?= =?utf-8?B?WG9YWndIS0NIQ2gwbWpNaTcvTUZ3UnZYZkxQRmNETGoxWVR6bmxFRHZMd3JV?= =?utf-8?B?Wjl5L25YUmhRWU1IVk80b1h6K3ZnRFVZRklkNzhXSDFjNEFpd3NMTU11NHRK?= =?utf-8?Q?RxXU/PSoL3orQzTe3e9YkAS84?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 42a468d8-7683-4af6-b4bf-08dc31507384 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Feb 2024 13:41:18.6079 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: At/K22K0eyqwgR2j2vJtkU5DvCuaHhqYs+pFDhM1knSAD2/GA4AsWtOjk5pXSFOy X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7780 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On 2/17/2024 1:54 AM, Chaoyong He wrote: > Add the support of UDP fragmentation offload feature. > > Signed-off-by: Chaoyong He <chaoyong.he@corigine.com> > Reviewed-by: Long Wu <long.wu@corigine.com> > Reviewed-by: Peng Zhang <peng.zhang@corigine.com> <...> > diff --git a/drivers/net/nfp/nfp_net_common.c b/drivers/net/nfp/nfp_net_common.c > index 72c9a41b00..99c319eb2d 100644 > --- a/drivers/net/nfp/nfp_net_common.c > +++ b/drivers/net/nfp/nfp_net_common.c > @@ -312,7 +312,7 @@ nfp_net_log_device_information(const struct nfp_net_hw *hw) > hw->ver.major, hw->ver.minor, hw->max_mtu); > > PMD_INIT_LOG(INFO, "CAP: %#x", cap); > - PMD_INIT_LOG(INFO, "%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s", > + PMD_INIT_LOG(INFO, "%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s", > This seems getting out of hand, I assume this is done like this (instead of multiple print lines) to prevent line break, if so what do you think add a new macro that doesn't append \n automatically and refactor this code (in a separate patch) ?