From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 384752BCE for ; Thu, 17 Jan 2019 09:34:16 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8FFC07F40E; Thu, 17 Jan 2019 08:34:15 +0000 (UTC) Received: from [10.36.112.28] (ovpn-112-28.ams2.redhat.com [10.36.112.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DE7A8101963A; Thu, 17 Jan 2019 08:34:12 +0000 (UTC) To: Xiaolong Ye , dev@dpdk.org, Tiwei Bie Cc: xiao.w.wang@intel.com References: <20190114073424.15519-1-xiaolong.ye@intel.com> From: Maxime Coquelin Message-ID: <85bfe3aa-e54c-4705-1d1b-436a4fb8870b@redhat.com> Date: Thu, 17 Jan 2019 09:34:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 In-Reply-To: <20190114073424.15519-1-xiaolong.ye@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 17 Jan 2019 08:34:15 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] vhost: invoke dev configuration after set vring call message X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jan 2019 08:34:16 -0000 On 1/14/19 8:34 AM, Xiaolong Ye wrote: > As qemu will only send VHOST_USER_SET_VRING_ENABLE message for guest > enabled vrings (only first queue pair will be enabled at initialized > stage), this will cause trouble for multiqueue case, vDPA's dev_conf > callback will get no chance be invoked. Decouple the dev_conf callback from > VHOST_USER_SET_VRING_ENABLE solves this issue. > > Signed-off-by: Xiaolong Ye > --- > lib/librte_vhost/vhost_user.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Maxime Coquelin Thanks, Maxime