From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 208132B91
 for <dev@dpdk.org>; Sun, 28 Oct 2018 12:04:22 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id B15B721E09;
 Sun, 28 Oct 2018 07:04:21 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Sun, 28 Oct 2018 07:04:21 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=mesmtp;
 bh=e9asrHE5uyY/OwfaBDXMeko0yXpUpAYTQdg/a9nbbZ0=; b=gTRNCeYew6uy
 3cwQZNPsWaRWFmbp6diq7LiUjyWRYvRUSi/s3QCo2TD+sExypfxUpTblFa4PUhhT
 Z6RwK2Yvr2WEnPTDxj13hvrpgQ58xldVAu/0YbvnPKxwOh0sUcXkrEp5H90sHo+/
 nirBYGVfi5Gn4y+F9j2LyDLlqmRlYpE=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm1; bh=e9asrHE5uyY/OwfaBDXMeko0yXpUpAYTQdg/a9nbb
 Z0=; b=MLCnQFfTloWmxpuZqUXFSJGr/IJTCi2yA4iNy27TbCEKhr25mIb0wtaek
 gc2P27Tz3anlqlPiBD4WPMIjoUluFzaAK+rRAECgWP5yPh6eONp0wT1sW8nOwMgc
 QeITsDN8/7qyR/rp9FTjbbDrjaN3EDYAxoGNd9QFkkF5B4doDsUVbYwA7pp1/mV/
 bLwCgd4xRIVJBWHtpaWYSCMh8x7mOnSG4XnYqvKIJ/Vf13qM6n+y95icINwmCF0Q
 lz8t6+ze2J+YB+Ax0lQyIrEbpCadIiEafMXT8cFIdkUS86QVtA+CyK00WWHxa2e3
 YOTkztsUuqKe6ts38wsC+Z3vAsdcA==
X-ME-Sender: <xms:tJfVW2iFDcPUWm-FNqQxabLrwhQcgl-yTn7MNLV-4SefqBjR3XTmsg>
X-ME-Proxy: <xmx:tJfVW5oy9Nno-Xbo2DK7wxGaSBCll2TkXv-r3Fhx-7Whi9xQ9J8-JA>
 <xmx:tJfVW8wqYWn9Tlegbu5JhrHhBQlKIAoep_WhIgAd71OR3duL6ZpbUQ>
 <xmx:tJfVW3JGKDHrIB_K6Cr28iP7jHlAb-demF7vvZnZCrZnsTiD6uCRCQ>
 <xmx:tJfVW_8OPB0fGa8O7a9HakIDVR2ka6B4vVo6-sEDuFJLP_hAjfH3rw>
 <xmx:tJfVWxvOB9zwwrAbQnpxeQQE24z9cmSN9FbtlUJV7rUKOwVbKJX8ng>
 <xmx:tZfVW-0xhSXch-adNCRNa3T9KkLTUt718k9vG3YMKB-VQoHDV-Bc7A>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 6546EE44DC;
 Sun, 28 Oct 2018 07:04:17 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Andrew Rybchenko <arybchenko@solarflare.com>,
 Reshma Pattan <reshma.pattan@intel.com>,
 Hemant Agrawal <hemant.agrawal@nxp.com>,
 Shreyansh Jain <shreyansh.jain@nxp.com>,
 Ashish Gupta <ashish.gupta@cavium.com>,
 Fiona Trahe <fiona.trahe@intel.com>,
 Pablo de Lara <pablo.de.lara.guarch@intel.com>,
 Akhil Goyal <akhil.goyal@nxp.com>,
 Declan Doherty <declan.doherty@intel.com>,
 Fan Zhang <roy.fan.zhang@intel.com>,
 Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
 Gaetan Rivet <gaetan.rivet@6wind.com>, Qi Zhang <qi.z.zhang@intel.com>,
 Xiao Wang <xiao.w.wang@intel.com>, Beilei Xing <beilei.xing@intel.com>,
 Wenzhuo Lu <wenzhuo.lu@intel.com>,
 Konstantin Ananyev <konstantin.ananyev@intel.com>,
 Rasesh Mody <rasesh.mody@cavium.com>,
 Harish Patil <harish.patil@cavium.com>,
 Shahed Shaikh <shahed.shaikh@cavium.com>,
 Jasvinder Singh <jasvinder.singh@intel.com>,
 Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
 Keith Wiles <keith.wiles@intel.com>, Nipun Gupta <nipun.gupta@nxp.com>,
 Anatoly Burakov <anatoly.burakov@intel.com>,
 Jerin Jacob <jerin.jacob@caviumnetworks.com>,
 Olivier Matz <olivier.matz@6wind.com>
Date: Sun, 28 Oct 2018 12:04:23 +0100
Message-ID: <8612622.zZWGxMPIhl@xps>
In-Reply-To: <bf870874-bc3d-a142-119b-608aea894536@solarflare.com>
References: <20181004034047.26824-1-ferruh.yigit@intel.com>
 <20181005162612.31906-1-ferruh.yigit@intel.com>
 <bf870874-bc3d-a142-119b-608aea894536@solarflare.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2 1/4] add missing static keyword to globals
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 28 Oct 2018 11:04:22 -0000

05/10/2018 17:55, Andrew Rybchenko:
> On 10/5/18 7:26 PM, Ferruh Yigit wrote:
> > --- a/drivers/net/sfc/sfc_rx.c
> > +++ b/drivers/net/sfc/sfc_rx.c
> > -struct sfc_rss_hf_rte_to_efx sfc_rss_hf_map[] = {
> > +static struct sfc_rss_hf_rte_to_efx sfc_rss_hf_map[] = {
> 
> I'd prefer "static const" in fact

Yes, please add const to such structures in a v3.