DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] ixgbe: fix the issue second 5tuple filter overwrites the first one
@ 2015-03-25  4:47 Jingjing Wu
  2015-03-25  4:56 ` Liu, Yong
  0 siblings, 1 reply; 3+ messages in thread
From: Jingjing Wu @ 2015-03-25  4:47 UTC (permalink / raw)
  To: dev

This patch corrects the index to fix the issue that is second 5tuple filter
overwrites the first one.

Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
---
 lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
index 92d75db..5caee22 100644
--- a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
+++ b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
@@ -3882,10 +3882,10 @@ ixgbe_add_5tuple_filter(struct rte_eth_dev *dev,
 	ftqf |= IXGBE_FTQF_POOL_MASK_EN;
 	ftqf |= IXGBE_FTQF_QUEUE_ENABLE;
 
-	IXGBE_WRITE_REG(hw, IXGBE_DAQF(idx), filter->filter_info.dst_ip);
-	IXGBE_WRITE_REG(hw, IXGBE_SAQF(idx), filter->filter_info.src_ip);
-	IXGBE_WRITE_REG(hw, IXGBE_SDPQF(idx), sdpqf);
-	IXGBE_WRITE_REG(hw, IXGBE_FTQF(idx), ftqf);
+	IXGBE_WRITE_REG(hw, IXGBE_DAQF(i), filter->filter_info.dst_ip);
+	IXGBE_WRITE_REG(hw, IXGBE_SAQF(i), filter->filter_info.src_ip);
+	IXGBE_WRITE_REG(hw, IXGBE_SDPQF(i), sdpqf);
+	IXGBE_WRITE_REG(hw, IXGBE_FTQF(i), ftqf);
 
 	l34timir |= IXGBE_L34T_IMIR_RESERVE;
 	l34timir |= (uint32_t)(filter->queue <<
-- 
1.9.3

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] ixgbe: fix the issue second 5tuple filter overwrites the first one
  2015-03-25  4:47 [dpdk-dev] [PATCH] ixgbe: fix the issue second 5tuple filter overwrites the first one Jingjing Wu
@ 2015-03-25  4:56 ` Liu, Yong
  2015-03-27 10:33   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Liu, Yong @ 2015-03-25  4:56 UTC (permalink / raw)
  To: Wu, Jingjing, dev

> -----Original Message-----
> From: Wu, Jingjing
> Sent: Wednesday, March 25, 2015 12:47 PM
> To: dev@dpdk.org
> Cc: Wu, Jingjing; Liu, Yong
> Subject: [PATCH] ixgbe: fix the issue second 5tuple filter overwrites the
> first one
> 
> This patch corrects the index to fix the issue that is second 5tuple
> filter
> overwrites the first one.
> 
> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>

Acked-by: Marvin Liu <yong.liu@intel.com>
> ---
>  lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
> b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
> index 92d75db..5caee22 100644
> --- a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
> +++ b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
> @@ -3882,10 +3882,10 @@ ixgbe_add_5tuple_filter(struct rte_eth_dev *dev,
>  	ftqf |= IXGBE_FTQF_POOL_MASK_EN;
>  	ftqf |= IXGBE_FTQF_QUEUE_ENABLE;
> 
> -	IXGBE_WRITE_REG(hw, IXGBE_DAQF(idx), filter->filter_info.dst_ip);
> -	IXGBE_WRITE_REG(hw, IXGBE_SAQF(idx), filter->filter_info.src_ip);
> -	IXGBE_WRITE_REG(hw, IXGBE_SDPQF(idx), sdpqf);
> -	IXGBE_WRITE_REG(hw, IXGBE_FTQF(idx), ftqf);
> +	IXGBE_WRITE_REG(hw, IXGBE_DAQF(i), filter->filter_info.dst_ip);
> +	IXGBE_WRITE_REG(hw, IXGBE_SAQF(i), filter->filter_info.src_ip);
> +	IXGBE_WRITE_REG(hw, IXGBE_SDPQF(i), sdpqf);
> +	IXGBE_WRITE_REG(hw, IXGBE_FTQF(i), ftqf);
> 
>  	l34timir |= IXGBE_L34T_IMIR_RESERVE;
>  	l34timir |= (uint32_t)(filter->queue <<
> --
> 1.9.3

Acked-by: Marvin Liu <yong.liu@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] ixgbe: fix the issue second 5tuple filter overwrites the first one
  2015-03-25  4:56 ` Liu, Yong
@ 2015-03-27 10:33   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2015-03-27 10:33 UTC (permalink / raw)
  To: Wu, Jingjing; +Cc: dev

> > This patch corrects the index to fix the issue that is second 5tuple
> > filter
> > overwrites the first one.
> > 
> > Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
> 
> Acked-by: Marvin Liu <yong.liu@intel.com>

Fixes: 4c54a7e7bd42 ("ixgbe: migrate ntuple filter to new API")

Applied, thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-03-27 10:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-25  4:47 [dpdk-dev] [PATCH] ixgbe: fix the issue second 5tuple filter overwrites the first one Jingjing Wu
2015-03-25  4:56 ` Liu, Yong
2015-03-27 10:33   ` Thomas Monjalon

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git