From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 62C61379E for ; Wed, 25 Mar 2015 05:57:55 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP; 24 Mar 2015 21:57:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,463,1422950400"; d="scan'208";a="670191293" Received: from pgsmsx103.gar.corp.intel.com ([10.221.44.82]) by orsmga001.jf.intel.com with ESMTP; 24 Mar 2015 21:57:53 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by PGSMSX103.gar.corp.intel.com (10.221.44.82) with Microsoft SMTP Server (TLS) id 14.3.224.2; Wed, 25 Mar 2015 12:56:08 +0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.108]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.149]) with mapi id 14.03.0224.002; Wed, 25 Mar 2015 12:56:06 +0800 From: "Liu, Yong" To: "Wu, Jingjing" , "dev@dpdk.org" Thread-Topic: [PATCH] ixgbe: fix the issue second 5tuple filter overwrites the first one Thread-Index: AQHQZrbLsjuqfDU+W0e7cSNOb3KtBJ0sobnw Date: Wed, 25 Mar 2015 04:56:06 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E10DA9C09@SHSMSX103.ccr.corp.intel.com> References: <1427258833-5070-1-git-send-email-jingjing.wu@intel.com> In-Reply-To: <1427258833-5070-1-git-send-email-jingjing.wu@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] ixgbe: fix the issue second 5tuple filter overwrites the first one X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Mar 2015 04:57:55 -0000 > -----Original Message----- > From: Wu, Jingjing > Sent: Wednesday, March 25, 2015 12:47 PM > To: dev@dpdk.org > Cc: Wu, Jingjing; Liu, Yong > Subject: [PATCH] ixgbe: fix the issue second 5tuple filter overwrites the > first one >=20 > This patch corrects the index to fix the issue that is second 5tuple > filter > overwrites the first one. >=20 > Signed-off-by: Jingjing Wu Acked-by: Marvin Liu > --- > lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c > b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c > index 92d75db..5caee22 100644 > --- a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c > +++ b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c > @@ -3882,10 +3882,10 @@ ixgbe_add_5tuple_filter(struct rte_eth_dev *dev, > ftqf |=3D IXGBE_FTQF_POOL_MASK_EN; > ftqf |=3D IXGBE_FTQF_QUEUE_ENABLE; >=20 > - IXGBE_WRITE_REG(hw, IXGBE_DAQF(idx), filter->filter_info.dst_ip); > - IXGBE_WRITE_REG(hw, IXGBE_SAQF(idx), filter->filter_info.src_ip); > - IXGBE_WRITE_REG(hw, IXGBE_SDPQF(idx), sdpqf); > - IXGBE_WRITE_REG(hw, IXGBE_FTQF(idx), ftqf); > + IXGBE_WRITE_REG(hw, IXGBE_DAQF(i), filter->filter_info.dst_ip); > + IXGBE_WRITE_REG(hw, IXGBE_SAQF(i), filter->filter_info.src_ip); > + IXGBE_WRITE_REG(hw, IXGBE_SDPQF(i), sdpqf); > + IXGBE_WRITE_REG(hw, IXGBE_FTQF(i), ftqf); >=20 > l34timir |=3D IXGBE_L34T_IMIR_RESERVE; > l34timir |=3D (uint32_t)(filter->queue << > -- > 1.9.3 Acked-by: Marvin Liu