From: "Liu, Yong" <yong.liu@intel.com>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Tahhan, Maryam" <maryam.tahhan@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 1/1] ixgbe: Fix phy errors in stats->ierrors
Date: Tue, 21 Jul 2015 12:41:24 +0000 [thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E10E67623@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC0909CFB94D@shsmsx102.ccr.corp.intel.com>
Tested-by: Marvin Liu <yong.liu@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Lu, Wenzhuo
> Sent: Tuesday, July 21, 2015 1:41 PM
> To: Tahhan, Maryam; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 1/1] ixgbe: Fix phy errors in stats-
> >ierrors
>
> Hi,
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Maryam Tahhan
> > Sent: Monday, July 20, 2015 8:28 PM
> > To: dev@dpdk.org
> > Subject: [dpdk-dev] [PATCH v2 1/1] ixgbe: Fix phy errors in stats-
> >ierrors
> >
> > Fixes: f6bf669b990004dc69231476d9fcf0b80574e568. Bug fix to remove
> > (rxnfgpc - hw_stats->gprc) which does not account for phy errors.
> > hw_stats->gprc is the Number of good (non-erred) Rx packets (from the
> > network) that pass L2 filtering and has a legal length as defined by
> > LongPacketEnable. While rxnfgpc is the Number of good (non-erred with
> legal
> > length) Rx packets (from the network) regardless of packet filtering and
> receive
> > enablement. Thus hw_stats->gprc can be > rxnfgpc and this calculation
> should
> > be removed from the calculation of ierrors.
> > Validated with testpmd by sending packets to the interface without
> forwarding
> > enabled - packets should be dropped and the error counters incremented.
> >
> > v2:
> > - specified the commit that this bug fix fixes.
> >
> > Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
> Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
next prev parent reply other threads:[~2015-07-21 12:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 12:28 Maryam Tahhan
2015-07-20 12:48 ` Balazs Nemeth
2015-07-21 5:41 ` Lu, Wenzhuo
2015-07-21 12:41 ` Liu, Yong [this message]
2015-07-23 13:00 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E10E67623@SHSMSX103.ccr.corp.intel.com \
--to=yong.liu@intel.com \
--cc=dev@dpdk.org \
--cc=maryam.tahhan@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).