From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id C3B495A0C for ; Tue, 21 Jul 2015 14:41:30 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP; 21 Jul 2015 05:41:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,516,1432623600"; d="scan'208";a="732717707" Received: from kmsmsx154.gar.corp.intel.com ([172.21.73.14]) by orsmga001.jf.intel.com with ESMTP; 21 Jul 2015 05:41:28 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by KMSMSX154.gar.corp.intel.com (172.21.73.14) with Microsoft SMTP Server (TLS) id 14.3.224.2; Tue, 21 Jul 2015 20:41:26 +0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.46]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.146]) with mapi id 14.03.0224.002; Tue, 21 Jul 2015 20:41:25 +0800 From: "Liu, Yong" To: "Lu, Wenzhuo" , "Tahhan, Maryam" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 1/1] ixgbe: Fix phy errors in stats->ierrors Thread-Index: AQHQwueimD/GHq+L/EKRCvz/omWYIJ3k472AgAD7HbA= Date: Tue, 21 Jul 2015 12:41:24 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E10E67623@SHSMSX103.ccr.corp.intel.com> References: <1437395309-197026-1-git-send-email-maryam.tahhan@intel.com> <6A0DE07E22DDAD4C9103DF62FEBC0909CFB94D@shsmsx102.ccr.corp.intel.com> In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC0909CFB94D@shsmsx102.ccr.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/1] ixgbe: Fix phy errors in stats->ierrors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jul 2015 12:41:31 -0000 Tested-by: Marvin Liu > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Lu, Wenzhuo > Sent: Tuesday, July 21, 2015 1:41 PM > To: Tahhan, Maryam; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 1/1] ixgbe: Fix phy errors in stats- > >ierrors >=20 > Hi, >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Maryam Tahhan > > Sent: Monday, July 20, 2015 8:28 PM > > To: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH v2 1/1] ixgbe: Fix phy errors in stats- > >ierrors > > > > Fixes: f6bf669b990004dc69231476d9fcf0b80574e568. Bug fix to remove > > (rxnfgpc - hw_stats->gprc) which does not account for phy errors. > > hw_stats->gprc is the Number of good (non-erred) Rx packets (from the > > network) that pass L2 filtering and has a legal length as defined by > > LongPacketEnable. While rxnfgpc is the Number of good (non-erred with > legal > > length) Rx packets (from the network) regardless of packet filtering an= d > receive > > enablement. Thus hw_stats->gprc can be > rxnfgpc and this calculation > should > > be removed from the calculation of ierrors. > > Validated with testpmd by sending packets to the interface without > forwarding > > enabled - packets should be dropped and the error counters incremented. > > > > v2: > > - specified the commit that this bug fix fixes. > > > > Signed-off-by: Maryam Tahhan > Acked-by: Wenzhuo Lu