From: "Liu, Yong" <yong.liu@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] app test: fix mempool cache_size not match limited cache_size
Date: Mon, 3 Aug 2015 00:51:40 +0000 [thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E10EB3A52@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <3134557.VXyn7jiyUM@xps13>
Thanks Thomas.
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Monday, August 03, 2015 5:27 AM
> To: Liu, Yong
> Cc: dev@dpdk.org; olivier.matz@6wind.com; Wu, Jingjing
> Subject: Re: [dpdk-dev] [PATCH] app test: fix mempool cache_size not match
> limited cache_size
>
> 2015-07-29 11:22, Yong Liu:
> > In previous setting, mempool size and cache_size are both 32.
> > This is not satisfied with cache_size checking rule by now.
> > Cache size should less than CONFIG_RTE_MEMPOOL_CACHE_MAX_SIZE and
> mempool size / 1.5.
>
> Sorry I don't really understand this explanation.
>
This information is stripped from the description for parameter cache_size of function rte_mempool_create.
Now rte_mempool_create function will check cache_size value less than mempool size /1.5.
In test_sched.c, mempool size and cache size are all 32 and not match mempool cache size checking rule.
This will cause sched_autotest not work.
> > #define NB_MBUF 32
> > #define MBUF_DATA_SZ (2048 + RTE_PKTMBUF_HEADROOM)
> > -#define PKT_BURST_SZ 32
> > +#define PKT_BURST_SZ 0
> > #define MEMPOOL_CACHE_SZ PKT_BURST_SZ
>
> Shouldn't be MEMPOOL_CACHE_SZ to set to 0?
Macro PKT_BURST_SZ not used in this file, MEMPOOL_CACHE_SZ should be set to 0.
prev parent reply other threads:[~2015-08-03 0:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-29 3:22 Yong Liu
2015-07-30 5:49 ` Wu, Jingjing
2015-08-03 21:45 ` Thomas Monjalon
2015-08-02 21:26 ` Thomas Monjalon
2015-08-03 0:51 ` Liu, Yong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E10EB3A52@SHSMSX103.ccr.corp.intel.com \
--to=yong.liu@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).