* [dpdk-dev] [PATCH] i40e:remove unlikely check in i40e_xmit_pkts for checksum offload
@ 2015-08-04 7:57 Jijiang Liu
2015-08-04 9:12 ` Liu, Yong
0 siblings, 1 reply; 3+ messages in thread
From: Jijiang Liu @ 2015-08-04 7:57 UTC (permalink / raw)
To: dev
The i40e_xmit_pkts() is called, which often means HW offload is used here, so we had better remove 'unlikely' check for checksum offload.
Signed-off-by: Jijiang Liu <jijiang.liu@intel.com>
---
drivers/net/i40e/i40e_rxtx.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
index 6cc069b..eae4ab0 100644
--- a/drivers/net/i40e/i40e_rxtx.c
+++ b/drivers/net/i40e/i40e_rxtx.c
@@ -1917,12 +1917,12 @@ i40e_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
/* Enable checksum offloading */
cd_tunneling_params = 0;
- if (unlikely(ol_flags & I40E_TX_CKSUM_OFFLOAD_MASK)) {
+ if (ol_flags & I40E_TX_CKSUM_OFFLOAD_MASK) {
i40e_txd_enable_checksum(ol_flags, &td_cmd, &td_offset,
tx_offload, &cd_tunneling_params);
}
- if (unlikely(nb_ctx)) {
+ if (nb_ctx) {
/* Setup TX context descriptor if required */
volatile struct i40e_tx_context_desc *ctx_txd =
(volatile struct i40e_tx_context_desc *)\
--
1.7.7.6
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] i40e:remove unlikely check in i40e_xmit_pkts for checksum offload
2015-08-04 7:57 [dpdk-dev] [PATCH] i40e:remove unlikely check in i40e_xmit_pkts for checksum offload Jijiang Liu
@ 2015-08-04 9:12 ` Liu, Yong
2015-08-09 18:00 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Liu, Yong @ 2015-08-04 9:12 UTC (permalink / raw)
To: Liu, Jijiang, dev
Acked-by: Marvin Liu <yong.liu@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jijiang Liu
> Sent: Tuesday, August 04, 2015 3:57 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] i40e:remove unlikely check in i40e_xmit_pkts
> for checksum offload
>
> The i40e_xmit_pkts() is called, which often means HW offload is used here,
> so we had better remove 'unlikely' check for checksum offload.
>
> Signed-off-by: Jijiang Liu <jijiang.liu@intel.com>
> ---
> drivers/net/i40e/i40e_rxtx.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
> index 6cc069b..eae4ab0 100644
> --- a/drivers/net/i40e/i40e_rxtx.c
> +++ b/drivers/net/i40e/i40e_rxtx.c
> @@ -1917,12 +1917,12 @@ i40e_xmit_pkts(void *tx_queue, struct rte_mbuf
> **tx_pkts, uint16_t nb_pkts)
>
> /* Enable checksum offloading */
> cd_tunneling_params = 0;
> - if (unlikely(ol_flags & I40E_TX_CKSUM_OFFLOAD_MASK)) {
> + if (ol_flags & I40E_TX_CKSUM_OFFLOAD_MASK) {
> i40e_txd_enable_checksum(ol_flags, &td_cmd, &td_offset,
> tx_offload, &cd_tunneling_params);
> }
>
> - if (unlikely(nb_ctx)) {
> + if (nb_ctx) {
> /* Setup TX context descriptor if required */
> volatile struct i40e_tx_context_desc *ctx_txd =
> (volatile struct i40e_tx_context_desc *)\
> --
> 1.7.7.6
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] i40e:remove unlikely check in i40e_xmit_pkts for checksum offload
2015-08-04 9:12 ` Liu, Yong
@ 2015-08-09 18:00 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2015-08-09 18:00 UTC (permalink / raw)
To: Liu, Jijiang; +Cc: dev
> > The i40e_xmit_pkts() is called, which often means HW offload is used here,
> > so we had better remove 'unlikely' check for checksum offload.
> >
> > Signed-off-by: Jijiang Liu <jijiang.liu@intel.com>
> Acked-by: Marvin Liu <yong.liu@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-08-09 18:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-04 7:57 [dpdk-dev] [PATCH] i40e:remove unlikely check in i40e_xmit_pkts for checksum offload Jijiang Liu
2015-08-04 9:12 ` Liu, Yong
2015-08-09 18:00 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).