From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 89B688DA5 for ; Fri, 30 Oct 2015 02:32:34 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 29 Oct 2015 18:32:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,217,1444719600"; d="scan'208";a="838472842" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga002.jf.intel.com with ESMTP; 29 Oct 2015 18:32:33 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 29 Oct 2015 18:32:32 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 29 Oct 2015 18:32:32 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.204]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.106]) with mapi id 14.03.0248.002; Fri, 30 Oct 2015 09:32:30 +0800 From: "Liu, Yong" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v4 0/7] e1000: add rx interrupt support Thread-Index: AQHREmJ27zoh/hr+QUiqOdXppbnSkp6CQY4AgAD8lHA= Date: Fri, 30 Oct 2015 01:32:30 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E10F3803E@SHSMSX103.ccr.corp.intel.com> References: <1446134187-4573-1-git-send-email-yong.liu@intel.com> <1603993.a4RWodNe3S@xps13> In-Reply-To: <1603993.a4RWodNe3S@xps13> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v4 0/7] e1000: add rx interrupt support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Oct 2015 01:32:35 -0000 Thanks Thomas. > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Friday, October 30, 2015 2:19 AM > To: Liu, Yong > Cc: dev@dpdk.org; Mcnamara, John > Subject: Re: [dpdk-dev] [PATCH v4 0/7] e1000: add rx interrupt support >=20 > 2015-10-29 23:56, Yong Liu: > > This patch set will enable interrup for physical and emulated e1000 > device. > > Rx queue interrupt will work with uio driver or vfio driver with msi > mode. > > l3fwd-power will disable interrupt immediately when wake-up for that > e1000 not > > support interrupt auto clear. > > LSC and rxq interrupt will be seperated for e1000 can only support one > > interrupt cause in the same time. >=20 > Don't you think it should be explained in a doc? > doc/guides/nics/e1000em.rst Yes, will update those information in the doc. > I'm especially confused by the need of changing an example for this PMD. > Does it mean the API behaviour must be changed? >=20 After return back from sleep, Rx interrupt should always disabled until ret= urn to sleep. Some NICs like Niantic and Fortville support interrupt auto disable, so it = worked normally. But e1000 not support that, so add rte_eth_dev_rx_intr_disable here to disa= ble related interrupt. > [...] > > Marvin Liu (7): > > e1000: add rx interrupt support > > e1000: separate lsc and rxq interrupt disable function > > e1000: add ethdev rxq enable and disable function > > e1000: add rxq interrupt handler > > e1000: check lsc and rxq not enable in the same time > > e1000: lsc interrupt setup function only enable itself > > l3fwd-power: disable interrupt when wake up from sleep >=20 > Announcing a support in first patch and making it work later > is a strange logic to review. >=20 > You forgot to keep the Acked-by: Cunming Liang >=20 > Applied in this order: > e1000: restrict link interrupt setup scope > e1000: separate link and Rx interrupt disabling > e1000: support Rx interrupt setup > e1000: add Rx interrupt handler > l3fwd-power: disable Rx interrupt when waking up > Thanks