Re: [dpdk-dev] [PATCH v3 1/3] examples/ip_reassembly: add parse-ptype option

["Liu, Yong" <yong.liu@intel.com>]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Friday, February 10, 2017 5:27 AM
> To: Liu, Yong <yong.liu@intel.com>; Tan, Jianfeng <jianfeng.tan@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 1/3] examples/ip_reassembly: add parse-
> ptype option
> 
> 2017-02-09 22:25, Marvin Liu:
> > Add new option parse-ptype in this sample in case of pmd driver
> > not provide packet type info. If this option enabled, packet type
> > will be analyzed in Rx callback function.
> [...]
> > +		if (parse_ptype) {
> > +			if (add_cb_parse_ptype(portid, queueid) < 0)
> > +				rte_exit(EXIT_FAILURE,
> > +					"Fail to add ptype cb\n");
> > +		} else if (!check_ptype(portid))
> > +			rte_exit(EXIT_FAILURE,
> > +				"PMD can not provide needed ptypes\n");
> 
> Instead of adding a new option, why not adding the callback automatically
> if the packet type is not supported by the hardware?

Thomas,
We want to let user choice which kind of method for packet type parsing. 
If start application with parse-type option, is meaning user want to use software parsing otherwise will use hardware parsing.

BRs,
Marvin