From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id B0424952 for ; Fri, 10 Feb 2017 08:53:58 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP; 09 Feb 2017 23:53:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,140,1484035200"; d="scan'208";a="1105539368" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga001.fm.intel.com with ESMTP; 09 Feb 2017 23:53:57 -0800 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 9 Feb 2017 23:53:57 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 9 Feb 2017 23:53:57 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.20]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.132]) with mapi id 14.03.0248.002; Fri, 10 Feb 2017 15:53:55 +0800 From: "Liu, Yong" To: Thomas Monjalon , "Tan, Jianfeng" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 1/3] examples/ip_reassembly: add parse-ptype option Thread-Index: AQHSgxtU3mTXyaaKW0K9S+/Y3AvyGqFh3YPQ Date: Fri, 10 Feb 2017 07:53:54 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62D5E2F6@SHSMSX103.ccr.corp.intel.com> References: <1485156509-4919-1-git-send-email-yong.liu@intel.com> <1486650334-34300-1-git-send-email-yong.liu@intel.com> <4997476.25NJoPJnWZ@xps13> In-Reply-To: <4997476.25NJoPJnWZ@xps13> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 1/3] examples/ip_reassembly: add parse-ptype option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Feb 2017 07:53:59 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Friday, February 10, 2017 5:27 AM > To: Liu, Yong ; Tan, Jianfeng > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 1/3] examples/ip_reassembly: add parse- > ptype option >=20 > 2017-02-09 22:25, Marvin Liu: > > Add new option parse-ptype in this sample in case of pmd driver > > not provide packet type info. If this option enabled, packet type > > will be analyzed in Rx callback function. > [...] > > + if (parse_ptype) { > > + if (add_cb_parse_ptype(portid, queueid) < 0) > > + rte_exit(EXIT_FAILURE, > > + "Fail to add ptype cb\n"); > > + } else if (!check_ptype(portid)) > > + rte_exit(EXIT_FAILURE, > > + "PMD can not provide needed ptypes\n"); >=20 > Instead of adding a new option, why not adding the callback automatically > if the packet type is not supported by the hardware? Thomas, We want to let user choice which kind of method for packet type parsing.=20 If start application with parse-type option, is meaning user want to use so= ftware parsing otherwise will use hardware parsing. BRs, Marvin