DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] vhost: fix zmbuf buffer id invalid
@ 2020-02-24 14:50 Marvin Liu
  2020-02-24  7:25 ` Ye Xiaolong
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Marvin Liu @ 2020-02-24 14:50 UTC (permalink / raw)
  To: maxime.coquelin; +Cc: dev, tiwei.bie, zhihong.wang, Marvin Liu, stable

zc mbufs should record available buffer id when doing dequeue zcopy.
There's no guarantee that local queue avail index equal to buffer index.

Fixes: d1eafb532268 ("vhost: add packed ring zcopy batch and single dequeue")
Cc: stable@dpdk.org

Signed-off-by: Marvin Liu <yong.liu@intel.com>
Reported-by: Yinan Wang <yinan.wang@intel.com>

diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c
index 37c47c7dc..210415904 100644
--- a/lib/librte_vhost/virtio_net.c
+++ b/lib/librte_vhost/virtio_net.c
@@ -2004,7 +2004,7 @@ virtio_dev_tx_batch_packed_zmbuf(struct virtio_net *dev,
 
 	vhost_for_each_try_unroll(i, 0, PACKED_BATCH_SIZE) {
 		zmbufs[i]->mbuf = pkts[i];
-		zmbufs[i]->desc_idx = avail_idx + i;
+		zmbufs[i]->desc_idx = ids[i];
 		zmbufs[i]->desc_count = 1;
 	}
 
@@ -2045,7 +2045,7 @@ virtio_dev_tx_single_packed_zmbuf(struct virtio_net *dev,
 		return -1;
 	}
 	zmbuf->mbuf = *pkts;
-	zmbuf->desc_idx = vq->last_avail_idx;
+	zmbuf->desc_idx = buf_id;
 	zmbuf->desc_count = desc_count;
 
 	rte_mbuf_refcnt_update(*pkts, 1);
-- 
2.17.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2020-02-24 11:15 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-24 14:50 [dpdk-dev] [PATCH] vhost: fix zmbuf buffer id invalid Marvin Liu
2020-02-24  7:25 ` Ye Xiaolong
2020-02-24  7:39   ` Liu, Yong
2020-02-24  7:27 ` Maxime Coquelin
2020-02-24 15:14 ` [dpdk-dev] [PATCH v2] vhost: fix packed ring zero-copy Marvin Liu
2020-02-24  8:28   ` Maxime Coquelin
2020-02-24 10:32     ` David Marchand
2020-02-24 11:14       ` Maxime Coquelin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).