From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E05FDA034F; Fri, 15 May 2020 04:41:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1490C1D9C8; Fri, 15 May 2020 04:41:18 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 590311D9B9 for ; Fri, 15 May 2020 04:41:16 +0200 (CEST) IronPort-SDR: X3bCkd3CE5L9ne/G67AhU8+cAvP7OAnEL86e0VYBSz42KS9ktPJPnGE2RmS0a3HvNDGAHKghsE NnwL+BcjL1hA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2020 19:41:15 -0700 IronPort-SDR: q+vO6sZhVcTMZiqjhJIv/fWDcFs5rcwcxBhICn/QOWxeLuZdY+HizvbJpNcxoiga27nnOPV+YQ /w/ZROKinB8A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,393,1583222400"; d="scan'208";a="298908876" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga008.jf.intel.com with ESMTP; 14 May 2020 19:41:14 -0700 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 14 May 2020 19:41:14 -0700 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 14 May 2020 19:41:13 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.241]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.232]) with mapi id 14.03.0439.000; Fri, 15 May 2020 10:41:11 +0800 From: "Liu, Yong" To: "Wang, Xiao W" , "maxime.coquelin@redhat.com" , "Ye, Xiaolong" , "Wang, Zhihong" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/virtio: disable event suppression when reconnect Thread-Index: AQHWKluViGcWvgZpM0WT5ymEc2ko7aiobnvw Date: Fri, 15 May 2020 02:41:10 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E635AFDD0@SHSMSX103.ccr.corp.intel.com> References: <20200515014056.44949-1-yong.liu@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/virtio: disable event suppression when reconnect X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thanks for reminder, xiao. v2 will cc stable branch.=20 As spec mentioned, notification is more precise in semantic. Will do /even= t suppression/event notification/s.=20 Regards, Marvin > -----Original Message----- > From: Wang, Xiao W > Sent: Friday, May 15, 2020 9:53 AM > To: Liu, Yong ; maxime.coquelin@redhat.com; Ye, > Xiaolong ; Wang, Zhihong > > Cc: dev@dpdk.org; Liu, Yong > Subject: RE: [dpdk-dev] [PATCH] net/virtio: disable event suppression whe= n > reconnect >=20 > Hi Marvin, >=20 > Comments inline. > Thanks for the fix. >=20 > Best Regards, > Xiao >=20 > > -----Original Message----- > > From: dev On Behalf Of Marvin Liu > > Sent: Friday, May 15, 2020 9:41 AM > > To: maxime.coquelin@redhat.com; Ye, Xiaolong ; > > Wang, Zhihong > > Cc: dev@dpdk.org; Liu, Yong > > Subject: [dpdk-dev] [PATCH] net/virtio: disable event suppression when > > reconnect > > > > Event suppression should be disabled after virtqueue initialization. It >=20 > s/Event suppression/interrupt/g >=20 > > can be enabled by calling rte_eth_dev_rx_intr_enable later. > > > > Signed-off-by: Marvin Liu > > > > diff --git a/drivers/net/virtio/virtqueue.c b/drivers/net/virtio/virtqu= eue.c > > index 408bba236a..2702e120ee 100644 > > --- a/drivers/net/virtio/virtqueue.c > > +++ b/drivers/net/virtio/virtqueue.c > > @@ -175,6 +175,7 @@ virtqueue_rxvq_reset_packed(struct virtqueue *vq) > > > > vring_desc_init_packed(vq, size); > > > > +virtqueue_disable_intr(vq); > > return 0; > > } > > > > @@ -211,5 +212,6 @@ virtqueue_txvq_reset_packed(struct virtqueue *vq) > > > > vring_desc_init_packed(vq, size); > > > > +virtqueue_disable_intr(vq); > > return 0; > > } > > -- > > 2.17.1 >=20 > Can we backport it to LTS by cc stable? >=20