From: "Liu, Yong" <yong.liu@intel.com>
To: "Fu, Patrick" <patrick.fu@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
"Xia, Chenbo" <chenbo.xia@intel.com>,
"Wang, Zhihong" <zhihong.wang@intel.com>
Cc: "Fu, Patrick" <patrick.fu@intel.com>,
"Wang, Yinan" <yinan.wang@intel.com>,
"Jiang, Cheng1" <cheng1.jiang@intel.com>,
"Liang, Cunming" <cunming.liang@intel.com>
Subject: Re: [dpdk-dev] [PATCH v4 1/2] vhost: introduce async enqueue registration API
Date: Mon, 6 Jul 2020 03:05:49 +0000 [thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E63616C54@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1593778906-47832-2-git-send-email-patrick.fu@intel.com>
Hi Patrick,
Few comments are inline, others are fine to me.
Regards,
Marvin
> diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c
> index 0d822d6..58ee3ef 100644
> --- a/lib/librte_vhost/vhost.c
> +++ b/lib/librte_vhost/vhost.c
> @@ -332,8 +332,13 @@
> {
> if (vq_is_packed(dev))
> rte_free(vq->shadow_used_packed);
> - else
> + else {
> rte_free(vq->shadow_used_split);
> + if (vq->async_pkts_pending)
> + rte_free(vq->async_pkts_pending);
> + if (vq->async_pending_info)
> + rte_free(vq->async_pending_info);
Missed pointer set and feature set to 0.
> +int rte_vhost_async_channel_unregister(int vid, uint16_t queue_id)
> +{
> + struct vhost_virtqueue *vq;
> + struct virtio_net *dev = get_device(vid);
> + int ret = -1;
> +
> + if (dev == NULL)
> + return ret;
> +
> + vq = dev->virtqueue[queue_id];
> +
> + if (vq == NULL)
> + return ret;
> +
> + ret = 0;
> + rte_spinlock_lock(&vq->access_lock);
> +
> + if (!vq->async_registered)
> + goto out;
> +
> + if (vq->async_pkts_inflight_n) {
> + VHOST_LOG_CONFIG(ERR, "Failed to unregister async
> channel. "
> + "async inflight packets must be completed before
> unregistration.\n");
> + ret = -1;
> + goto out;
> + }
> +
> + if (vq->async_pkts_pending) {
> + rte_free(vq->async_pkts_pending);
> + vq->async_pkts_pending = 0;
> + }
> +
> + if (vq->async_pending_info) {
> + rte_free(vq->async_pending_info);
> + vq->async_pending_info = 0;
> + }
> +
Please unify the async pending pointer check and free logic and pointer should be set to NULL.
> + vq->async_ops.transfer_data = NULL;
> + vq->async_ops.check_completed_copies = NULL;
> + vq->async_registered = false;
> +
> +out:
> + rte_spinlock_unlock(&vq->access_lock);
> +
> + return ret;
> +}
> +
next prev parent reply other threads:[~2020-07-06 3:05 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 10:02 [dpdk-dev] [PATCH v1 0/2] introduce asynchronous data path for vhost patrick.fu
2020-06-11 10:02 ` [dpdk-dev] [PATCH v1 1/2] vhost: introduce async data path registration API patrick.fu
2020-06-18 5:50 ` Liu, Yong
2020-06-18 9:08 ` Fu, Patrick
2020-06-19 0:40 ` Liu, Yong
2020-06-25 13:42 ` Maxime Coquelin
2020-06-26 14:28 ` Maxime Coquelin
2020-06-29 1:15 ` Fu, Patrick
2020-06-26 14:44 ` Maxime Coquelin
2020-06-11 10:02 ` [dpdk-dev] [PATCH v1 2/2] vhost: introduce async enqueue for split ring patrick.fu
2020-06-18 6:56 ` Liu, Yong
2020-06-18 11:36 ` Fu, Patrick
2020-06-26 14:39 ` Maxime Coquelin
2020-06-26 14:46 ` Maxime Coquelin
2020-06-29 1:25 ` Fu, Patrick
2020-06-26 14:42 ` [dpdk-dev] [PATCH v1 0/2] introduce asynchronous data path for vhost Maxime Coquelin
2020-07-03 10:27 ` [dpdk-dev] [PATCH v3 " patrick.fu
2020-07-03 10:27 ` [dpdk-dev] [PATCH v3 1/2] vhost: introduce async enqueue registration API patrick.fu
2020-07-03 10:27 ` [dpdk-dev] [PATCH v3 2/2] vhost: introduce async enqueue for split ring patrick.fu
2020-07-03 12:21 ` [dpdk-dev] [PATCH v4 0/2] introduce asynchronous data path for vhost patrick.fu
2020-07-03 12:21 ` [dpdk-dev] [PATCH v4 1/2] vhost: introduce async enqueue registration API patrick.fu
2020-07-06 3:05 ` Liu, Yong [this message]
2020-07-06 9:08 ` Fu, Patrick
2020-07-03 12:21 ` [dpdk-dev] [PATCH v4 2/2] vhost: introduce async enqueue for split ring patrick.fu
2020-07-06 11:53 ` [dpdk-dev] [PATCH v5 0/2] introduce asynchronous data path for vhost patrick.fu
2020-07-06 11:53 ` [dpdk-dev] [PATCH v5 1/2] vhost: introduce async enqueue registration API patrick.fu
2020-07-06 11:53 ` [dpdk-dev] [PATCH v5 2/2] vhost: introduce async enqueue for split ring patrick.fu
2020-07-07 5:07 ` [dpdk-dev] [PATCH v6 0/2] introduce asynchronous data path for vhost patrick.fu
2020-07-07 5:07 ` [dpdk-dev] [PATCH v6 1/2] vhost: introduce async enqueue registration API patrick.fu
2020-07-07 8:22 ` Xia, Chenbo
2020-07-07 5:07 ` [dpdk-dev] [PATCH v6 2/2] vhost: introduce async enqueue for split ring patrick.fu
2020-07-07 8:22 ` Xia, Chenbo
2020-07-07 16:45 ` [dpdk-dev] [PATCH v6 0/2] introduce asynchronous data path for vhost Ferruh Yigit
2020-07-20 13:26 ` Maxime Coquelin
2020-07-21 2:28 ` Fu, Patrick
2020-07-21 8:28 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E63616C54@SHSMSX103.ccr.corp.intel.com \
--to=yong.liu@intel.com \
--cc=chenbo.xia@intel.com \
--cc=cheng1.jiang@intel.com \
--cc=cunming.liang@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=patrick.fu@intel.com \
--cc=yinan.wang@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).