From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id CF7A37CD2 for ; Tue, 25 Sep 2018 13:30:28 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Sep 2018 04:30:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,301,1534834800"; d="scan'208";a="89153083" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.39]) ([10.237.221.39]) by fmsmga002.fm.intel.com with ESMTP; 25 Sep 2018 04:30:13 -0700 To: Ajit Khaparde , dev@dpdk.org Cc: yongping References: <20180922045559.27438-1-ajit.khaparde@broadcom.com> <20180922045559.27438-9-ajit.khaparde@broadcom.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: <862648c7-bf26-7ddd-aee1-08c2d2a1b299@intel.com> Date: Tue, 25 Sep 2018 12:30:13 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180922045559.27438-9-ajit.khaparde@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 08/12] net/bnxt: use correct macro to register VF async event completion ring X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Sep 2018 11:30:29 -0000 On 9/22/2018 5:55 AM, Ajit Khaparde wrote: > From: yongping > > While registering vf's event completion ring to FW, use the wrong > macro, FW doesn't set up the event completion ring successfully, > VF can't receive any async event. Isn't this a fix that you would want to backport? If so can you please update the commit log according, and perhaps it can be better to move this patch before HWRM update patch, to help stable tree maintainers. > > Signed-off-by: yongping Can you please use "Name Surname " syntax? > Signed-off-by: Ajit Khaparde > --- > drivers/net/bnxt/bnxt_hwrm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c > index 62da254b9..51fe3a4c2 100644 > --- a/drivers/net/bnxt/bnxt_hwrm.c > +++ b/drivers/net/bnxt/bnxt_hwrm.c > @@ -3001,7 +3001,7 @@ int bnxt_hwrm_vf_func_cfg_def_cp(struct bnxt *bp) > HWRM_PREP(req, FUNC_VF_CFG, BNXT_USE_CHIMP_MB); > > req.enables = rte_cpu_to_le_32( > - HWRM_FUNC_CFG_INPUT_ENABLES_ASYNC_EVENT_CR); > + HWRM_FUNC_VF_CFG_INPUT_ENABLES_ASYNC_EVENT_CR); > req.async_event_cr = rte_cpu_to_le_16( > bp->def_cp_ring->cp_ring_struct->fw_ring_id); > rc = bnxt_hwrm_send_message(bp, &req, sizeof(req), BNXT_USE_CHIMP_MB); >