From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57FA943C12; Fri, 1 Mar 2024 18:16:48 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 453564025C; Fri, 1 Mar 2024 18:16:48 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2078.outbound.protection.outlook.com [40.107.243.78]) by mails.dpdk.org (Postfix) with ESMTP id 8E61F400D5 for ; Fri, 1 Mar 2024 18:16:46 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dCA8WyCkzIA+9rsnVJn6lMw/58BYtcmQB/OpvSZTsosv9KiE8CQ3tRasZoGJcz1U/I2nsbRHtlFSWVxOsXC/DtRPrXCEDXGBqqqzatt+892vQFmQbXguutHy0yPmX/eJmHhZVROnjzNFp9FITMf+C4LoTRq0SJNtlqkT+gsGv0jYzlCtnBB84vRIqw/Slk31rxRyU1TjxUtDIReRhOlDImYqBBynpPMMktl2VLPOu/fuE047JVq0yLg81JxuUcDHyl9qUf61UJsu1qw4py7p9lgCdizihJxReywNxm28YU327ToHKOdFxRosLGL8z9luBD3qqnlAiV+pKGphRPodvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JdL3xLNscoaDmHdausLgJkRCQK9zHXpNsvply86cOuU=; b=UomUSIEqT3zXGXwAI3J5ixjAejIUQxPgzpmmW6uM7bTI25Iwb/+8nf7EmIeW2Stzm8h37rPQeNxC2V2nz7PTeAzhXTQTrmRh/cfMpTn0lgmTCRw1Tu50AmIUEFAgNODb8um/H6Y7NzbQcnmjSoFHViVAqgjC3iwM5SgvnGr6DIEtyMVbg2iOrPDerOTGFRz/CP0MVnhj21YaVWQ1Haq5x7X1bo0BKaPFt0XOPiHTctFa5ElTe1SinpXnSNf8kwbAyT9N9pL5CXF2xtNcW4rNtvbS0insJYDn4UlDceC6Crq3tEegu+2r5bTxB2TqIfUMF582N8gvnUlUSvPQEIcyIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JdL3xLNscoaDmHdausLgJkRCQK9zHXpNsvply86cOuU=; b=mW253/JV7wd5vgr+75gN8lMuAxSHMsEtYDQ9qI1cVEnPZ3Oe1GSI8SPZeUrn3ma+EU2VQKJ9IghlNRHBmmJ9pm3VXHW6GedAPJijDSUGXdS0X9lFaGPHo/Rxi1tkVVskBaN0WuUv+qhSkUutLLNWUrP1+0PRd6AfzwdyMJlvinc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH7PR12MB6761.namprd12.prod.outlook.com (2603:10b6:510:1ab::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.33; Fri, 1 Mar 2024 17:16:44 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529%5]) with mapi id 15.20.7316.039; Fri, 1 Mar 2024 17:16:44 +0000 Message-ID: <86341b1e-a20f-4ab3-84ac-a9d912fe5ff8@amd.com> Date: Fri, 1 Mar 2024 17:16:41 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] ethdev: add Linux ethtool link mode conversion Content-Language: en-US To: Thomas Monjalon Cc: dev@dpdk.org, Andrew Rybchenko References: <20240229123653.1379466-1-thomas@monjalon.net> <3271586.N7aMVyhfb1@thomas> <14dcf7c4-2e9d-459e-b701-5f26ab4174a1@amd.com> <1743963.yIU609i1g2@thomas> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <1743963.yIU609i1g2@thomas> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0280.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a1::28) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH7PR12MB6761:EE_ X-MS-Office365-Filtering-Correlation-Id: d7bd1787-92b5-43b1-6125-08dc3a135e65 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5dAVcQ7TM9yZ6XwHPsu+qB/flzBXwiXCUyO2HI60bGZkmImnek2m9u6QIAQ8Jflw25QaCJy9uF8sVh3QemxRPwXtq61r0qKri27dRdWtUe0AX7vVI9X1SFWEkBA8INHqVQHv6Q+jDwA4UGruYCtPklmGp3ASXpmGgR8S9BE7kfVPSXfCo8t34b30TY6E/nPsl77r5Oj8GNFCs4AOU/WMrUjs+Dksv5KKNDOXIt0uEiItETiG2IDl+3GYGKzz6VClOiXL2SHOPfvbJo3ui78ee4JtZ5zq2+ri1uwPz8jxPl2sh70Mp7OSJ95FBk4XESV/HSxmtVBO0/s/RC0Q4QPi/XetIQ7hewYNz+/ICGcsE8DxK8VCtwqiJ03TM1NmI04tHYKjUxOBwfdYxd6raNtrPeqFb0wpGk9Gg8zD5hj8xCtOFOWtrdO9CceH4Dawlqlg2PmVzDIEyT6Pg69HiDS4vdZQMaGNhzXAM/ig0/t1CXyLwnBfF/E+SXTWaASy/WsBgKR2ozh4hOSdEM+MCENYLUN/du6gp4eE4Jrqp+OXyZbC3YHiNnB4Jmh3+5eBK8CYfamZh+JxzFeXmaS1//9o//QqFzK1JTlBwmypokOSLfNfSplbsw9HhiNIbZM7LahIPVZwuSkYn4K9LXK/olUqkA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c2JOOTVKblZwbVJUb2ppWnlyUWZzd3VGT1RvM1hDQ0ozakozQ1NVclB4aVk1?= =?utf-8?B?YjRzbFZTeDJ5WlVaZzJNK09uZGhneFp1bWRxTzkwVzBpaFZKV0ZKblV2Skts?= =?utf-8?B?dGV5ZUJ1T2pNTVYzR2FNWE9zSitDejRxdjdOWTdmMzhmSVREWllDQnZjRjJ6?= =?utf-8?B?dXJtTEZPRzhJWWJXc1IyNzlITEVaWFVxWGh6RDJrc29lcTZSZ3pHcjFjVGZG?= =?utf-8?B?NEM5NVZMdy9NcVZrczZzQ2d4ekJuSGF5MmpkSGxKaENLNU5QU0NxOHNqcXlB?= =?utf-8?B?d1FkQm5MRjFyVVgyRHYxcFdGODM4ZmcwWnhOUjFTQjhaU2ZWYTVDWkNiaWVy?= =?utf-8?B?Q01lQituSFpldStXVkF0bDlnUU16UnMyZTBTZGRZVmptODhxSjY3cE0vNUln?= =?utf-8?B?WFlVZ2NlTkttbHFDUmhlY3JhMTloY0hwcnNhU1hicFE3MTNrSG5vUGQ5QjBG?= =?utf-8?B?bUUxY29vVzdZS01pOHJDM1hETGt4WHdORWVEaGM4U1AwcWdsRzZMWjF1ZmRX?= =?utf-8?B?RDVSM0VnYkZYU01ZMUtqYldiaTZQZWRDc3l1T3Z0Z2UyWk1YUkNJLzAzbWZH?= =?utf-8?B?dlFYQ1I5RnpQMS9ISGViZGF1T0lUMTdiN1lpcFlDMGc1V1JhZGpyK2x1Nlox?= =?utf-8?B?U2grcUlDTGdVQUU4OFVQWVNDTlJ5V2YzSVhPWDluWndEb253a3BiVXpUOFkw?= =?utf-8?B?aW5NdVRPT0NiQmd1dDNNYVpkR3hQS0tGMVRKM0FlcmpLcXAxbGxwSGQ0emly?= =?utf-8?B?aTNBMTk5WFBqeWhJYmxXZXFsSzdzVVAveDkycjNJa29NcjRFVlY1NlpPSHpY?= =?utf-8?B?NFpSQlQyeHRkT1RWcW5RQ3NOUnlXd2x4RFBMbnc1NUNUQXY0eGdtSjVabGRt?= =?utf-8?B?d2pQa0s5OXZBUlUvNGczVEFuOElBcGowMVpLZVdaZVAvdnZvaU5oWG5hOC8y?= =?utf-8?B?bC93dFJsTHJrZUtFdUhWNnNUdTNWUTBrdU5LcjRLczYzdUlIRmJpYnJ4ZE10?= =?utf-8?B?MzZxVXBpUkEvYmVLc0RIaGhSVk8rSWpueVcxenBlVTN4K1JmMjk1UHlmOHY3?= =?utf-8?B?S1pJY2JQemJjd3lBTVhVM2pPK1dTbk9kZ1IwdmFtQW1zK21kMDY3Q0JsNGh4?= =?utf-8?B?Z2RRU0NEUnZPdjd5Q0F5VDVxaGxHNlhYYXdDYUs4d25UWVQ0eTlrOHphSUpF?= =?utf-8?B?UzJkRnhWdHJ5a0xSZXIwMlg4WWxpbjVrRm1QQ3hoOVJySU0wWEVoYTlOM29j?= =?utf-8?B?Y25scVQxWjFwajloRWFQV25QdGJEa1BuTXp6MGxla3BGWjFYSlBTYTc0SU9N?= =?utf-8?B?WDBTMkN3TWJqNUV1aWQ2N0VTR3hGN0t5YXRKdkZWeUZFWlpvRGh3SE9UcVhj?= =?utf-8?B?Tk1jOXVWaU9aTmg3Y1pkTUo2NVRJT0xGTlRvYmM3aEhLeHVWUHNrWVRnUGli?= =?utf-8?B?S2gybWF3aWNScmZPWWNZdWZqQmx6M0oyY2VQdU5ONyszOVFyYitSb2VtYU93?= =?utf-8?B?eGcxNjhlZlBlSlh5eWV0Y285UkNyUFhQRk1jRWVQTXJ5VnBvanpwYi8wS0hj?= =?utf-8?B?anVhUkVMYlRBdTg3N0dZaFBvYVZYT3E1MmdBa1piZEZpd1BzQ0ZFL1pPVXlE?= =?utf-8?B?WUFkTkNlY0lYeUVrY2ZFOEZMUm94M0JMU0JHbWFzN3pIemkvY0g5UWtJQThP?= =?utf-8?B?U1JhWC95eXBnLzAwWjlubzdxQzNHS2wzS0d5STNQZ3hPQmphdU5LemNmSFdY?= =?utf-8?B?YnRMS0tpN051V3hsVDBkcWxiZzR5alBiQURxbTJHaFNtM0lIaTY4cW5HMXRU?= =?utf-8?B?OXRmT1JoRGgzZERETkl2ZERDMnIvM0w0L2Znamp6RUNmSHV2WjFqQ3ZPQ3di?= =?utf-8?B?VGVYeGp2YnFlSXlScmZKWERRMXBGRzNTZFU3aFpTM3ZrdnBsWEJ5NTJ2cVd0?= =?utf-8?B?eGtKUU1xWFRVZjd0NDJ1L0lQeXl2K0YyMlF2cWRESE5XRGVFa0d0cFdwWkhQ?= =?utf-8?B?cFJ2SUY4bDdTQmdkL29Jb3hzT1E3VjhONkZnanNhY3hHVk9ZRW9XODJsM3BE?= =?utf-8?B?SEErRzJZWExFNlFLNmdqZmFHd3RqT2d5S281eG9tZ0JJRFNiTXpCMWR6am5B?= =?utf-8?Q?Nam1K88cAKk+ZZiAs4zUAuOnx?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: d7bd1787-92b5-43b1-6125-08dc3a135e65 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2024 17:16:44.4314 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8Bcj+Jq8EhPI3foBB4NeWeipQ7RFdkZSXpvmQSkhoSM78/7/tX/wUlHXB+66PJx/ X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6761 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/1/2024 3:20 PM, Thomas Monjalon wrote: > 01/03/2024 16:08, Ferruh Yigit: >> On 3/1/2024 1:37 PM, Thomas Monjalon wrote: >>> 01/03/2024 14:12, Ferruh Yigit: >>>> On 2/29/2024 3:42 PM, Thomas Monjalon wrote: >>>>> Speed capabilities of a NIC may be discovered through its Linux >>>>> kernel driver. It is especially useful for bifurcated drivers, >>>>> so they don't have to duplicate the same logic in the DPDK driver. >>>>> >>>>> Parsing ethtool speed capabilities is made easy thanks to >>>>> the functions added in ethdev for internal usage only. >>>>> Of course these functions work only on Linux, >>>>> so they are not compiled in other environments. >>>>> >>>>> In order to ease parsing, the ethtool macro names are parsed >>>>> externally in a shell command which generates a C array >>>>> included in this patch. >>>>> It also avoids to depend on a kernel version. >>>>> This C array should be updated in future to get latest ethtool bits. >>>>> Note it is easier to update this array than adding new cases >>>>> in a parsing code. >>>>> >>>>> The types in the functions are following the ethtool type: >>>>> uint32_t for bitmaps, and int8_t for the number of 32-bitmaps. >>>>> >>>>> Signed-off-by: Thomas Monjalon >>>>> --- >>>>> >>>>> A follow-up patch will be sent to use these functions in mlx5. >>>>> I suspect mana could use this parsing as well. >>>>> >>>> >>>> Is the usecase driver get link info via ibverbs and convert it to DPDK >>>> link info? >>> >>> The use case is to get capabilities from the kernel driver via ethtool ioctl. >>> >> >> Sure, as it is adding kernel ethtool conversion, DPDK driver will get >> link from kernel driver, thanks for clarification. > > Yes the PMD uses ethtool API to get device capabilies. > >>>> How complex or duplicated effort to get link info directly via DPDK >>>> functions? >>> >>> This is done by the driver. >>> This is how mlx5 driver is getting speed capabilities. >>> >>>> Because this approach is can be applied to only limited devices in DPDK >>>> and solving an issue DPDK already has a solution, does it worth to the >>>> code it adds? >>> >>> It is going to replace code in mlx5 driver. >>> I could add this code in mlx5 driver, >>> but it could help other drivers in future like mana. >> >> Why replace, is there anything to fix in the DPDK link get code? > > There is nothing to fix in ethdev layer. > I want to replace PMD code doing ethtool queries > with something cleaner and easier to update. > ack, I will proceed with the patch for -rc2