From: Michael Frasca <michael.frasca@oracle.com>
To: "Chen, Jing D" <jing.d.chen@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] fm10k: conditionally disable RSS during device initialization
Date: Wed, 23 Mar 2016 09:42:36 -0400 [thread overview]
Message-ID: <8634D5E0-C1B2-4194-B9A4-E0BDC982B36B@oracle.com> (raw)
In-Reply-To: <4341B239C0EFF9468EE453F9E9F4604D04464381@shsmsx102.ccr.corp.intel.com>
Hi Jing,
I ran into this issue while trying to run experiments with different RSS
configurations (no RSS being one cases). It is not clear to me that setting this
register to zero is the best way to disable RSS.
After digging further, I have a theory that I'm having this issues because I've
only attached my DPDK application to SR-IOV ports. In
fm10k_dev_dglort_map_configure(), I see that 'RSS Length' is set for the DGLORT
decoder. However, it appears that this is only invoked for physical functions.
Could this be my problem? Is it required that I bind to the physical function
if I want to properly manipulate RSS?
Thanks,
Mike
> On Mar 22, 2016, at 11:14 PM, Chen, Jing D <jing.d.chen@intel.com> wrote:
>
> Hi,
>
>> -----Original Message-----
>> From: Michael Frasca [mailto:michael.frasca@oracle.com]
>> Sent: Wednesday, March 23, 2016 12:58 AM
>> To: Chen, Jing D
>> Cc: dev@dpdk.org; Michael Frasca
>> Subject: [PATCH] fm10k: conditionally disable RSS during device initialization
>>
>> If the provided configuration does not call for RSS, then RSS is
>> explicitly disabled. Without this change, the device continues to
>> operate under the previous RSS configuration.
>>
>> Fixes: 57033cdf8fdc ("fm10k: add PF RSS")
>>
>> Signed-off-by: Michael Frasca <michael.frasca@oracle.com>
> Acked-by : Jing Chen <jing.d.chen@intel.com>
>
next prev parent reply other threads:[~2016-03-23 13:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 16:58 Michael Frasca
2016-03-23 3:14 ` Chen, Jing D
2016-03-23 13:42 ` Michael Frasca [this message]
2016-03-24 6:40 ` Chen, Jing D
2016-03-24 17:35 ` Michael Frasca
2016-03-31 13:57 ` Thomas Monjalon
2016-03-31 14:15 ` Chen, Jing D
2016-03-31 15:10 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8634D5E0-C1B2-4194-B9A4-E0BDC982B36B@oracle.com \
--to=michael.frasca@oracle.com \
--cc=dev@dpdk.org \
--cc=jing.d.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).