From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D51D0A0597; Wed, 8 Apr 2020 15:26:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1EA6B1C194; Wed, 8 Apr 2020 15:26:47 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id C54D91C193; Wed, 8 Apr 2020 15:26:45 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 698CB5C020B; Wed, 8 Apr 2020 09:26:45 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 08 Apr 2020 09:26:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=VzMHp1X1nZmrLf16+xan5mwITPUmt4/qDH0dHYOPTxg=; b=EbFY/elwkxpa ryE5DAm8cDvVPoJ/T6lAb7NqAXG13DDs9S5FFOu4ia4c+sVz0GcMc3TiGi5MezAY vQNDqSumQZH0MrocKLXprqP71k99P94ZKg8J3o/6/942w6sEX5TaW3gwtjUDAT4j rSMTkNw4cDAmuTwOixzVNyX7735kkU8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=VzMHp1X1nZmrLf16+xan5mwITPUmt4/qDH0dHYOPT xg=; b=2RmqEFogrglyFvyPI2XWIm1qpUA/Bkmj4UZPDjZXQt0OBh9pXenAmtlBO YjSNofqOWN3FQ9MmPYOjR/neavYK4t6q4ENFRKKzssipC2PWYL+hNdeaJMEootlN 3FRNQDcqOwL9jJ6AQJLVYO5a4qGBcow7k8d0hTBdzD0XHzTixGFtpdIs2T1OkVj7 H6oAE1Jngg9If6I3bVlzauOPABKlOpL152Nu+o6g6zanvQaxCEgkUAyrRfji/DRD s75Iy+cVOmwpZ8TqQsPZZpPk3MdN2Svlwo+4sWbYDSj88f/drnXafBrGo7pq4lvj hoJhx10H9l5Ptjx3GLZC8SNUq4hiw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudejgdeifecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh hmrghinhepughpughkrdhorhhgnecukfhppeejjedrudefgedrvddtfedrudekgeenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrsh esmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7847B3060060; Wed, 8 Apr 2020 09:26:40 -0400 (EDT) From: Thomas Monjalon To: Lukasz Wojciechowski , Anoob Joseph Cc: Akhil Goyal , Declan Doherty , Aviad Yehezkel , Boris Pismenny , Radu Nicolau , Anoob Joseph , "dev@dpdk.org" , "stable@dpdk.org" Date: Wed, 08 Apr 2020 15:26:38 +0200 Message-ID: <8635541.CDJkKcVGEf@thomas> In-Reply-To: References: <20200312151654.7218-1-l.wojciechow@partner.samsung.com> <1875710.PYKUYFuaPT@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 01/13] security: fix verification of parameters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 08/04/2020 15:02, Anoob Joseph: > Hi Thomas, > > > 08/04/2020 05:13, Lukasz Wojciechowski: > > > This patch adds verification of the parameters to the ret_security API > > > functions. All required parameters are checked if they are not NULL. > > [...] > > > --- a/config/common_base > > > +++ b/config/common_base > > > CONFIG_RTE_LIBRTE_SECURITY=y > > > +CONFIG_RTE_LIBRTE_SECURITY_DEBUG=n > > > > Is it a leftover? > > > > [Anoob] It is similar to 'RTE_LIBRTE_ETHDEV_DEBUG' for usage in datapath. Like in, http://code.dpdk.org/dpdk/latest/source/lib/librte_ethdev/rte_ethdev.h#L4378 1/ I don't see it used in this patch 2/ Adding makefile-only option is weird 3/ Adding new compile-time options is discouraged