From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id E149A5B20 for ; Wed, 3 Apr 2019 00:51:56 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 710122208C; Tue, 2 Apr 2019 18:51:56 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 02 Apr 2019 18:51:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=69k6UjuU0KT4IeJIMkhtsnfjl2pXCKLpN0THbo7YjJ4=; b=n/msUVX0rFo3 bQvuMqEOrN/1dZr/5fmugSBF8EBkf1zGEUVe118JowXx5ZZd/t4z6B5VxoWMl2+L b49dpIkRdbVMrp0M4AM3X539p/UP+Rj06LHm8IVDyMH/u5QF4Ostm+JP04oKN8/y PPigUcr6AjtDr6fVHNu21GXn8OGNqlc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=69k6UjuU0KT4IeJIMkhtsnfjl2pXCKLpN0THbo7Yj J4=; b=A2/mynlxZabBha4TJ63a7Ic8xWijIEvmPfjXIPgA+HJpz1r9CKpVv7EAd xK3/gOZMMnTutOa7rGMZN6b8+fn0nYCsKYN52J6LqS26dOBVcjmv/CgI8aM8rom8 Cqpfdqz+/+5gijIrWtynHcEhC0mrj5KmtfXb+DTyFILFsDUpsilTfq1AgmTmq0pM Wjiyymes7+teW/WEa1Q+LU5olgIipkOhLtUhfU9Z0pQK1VJbcC6TOJOOLchmhBow pSXTktEVBXHbO8JMYsvTNvAOoAE8DppFTfnZ2r5N2/XLZa1t0vF2r/EkQcFJK20a hh52r3uI6p9cEcNm7L76kbn/JpEYg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrtddugddugeculddtuddrgedutddrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvden ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhep mhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsth gvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 15FE7E43A3; Tue, 2 Apr 2019 18:51:54 -0400 (EDT) From: Thomas Monjalon To: Anand Rawat Cc: dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com, jeffrey.b.shaw@intel.com, bruce.richardson@intel.com Date: Wed, 03 Apr 2019 00:51:53 +0200 Message-ID: <8636883.cOhKqkjfg7@xps> In-Reply-To: <20190402035458.14664-11-anand.rawat@intel.com> References: <20190306041634.12976-1-anand.rawat@intel.com> <20190402035458.14664-1-anand.rawat@intel.com> <20190402035458.14664-11-anand.rawat@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v8 10/10] build: meson changes to build on windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Apr 2019 22:51:57 -0000 02/04/2019 05:54, Anand Rawat: > Added meson workarounds to build helloworld on Windows. > Windows currently only supports kvargs and eal libraries. > This change restricts the build flow to supported libraries > only. > > Signed-off-by: Anand Rawat > Signed-off-by: Pallavi Kadam > Reviewed-by: Jeff Shaw > Reviewed-by: Ranjit Menon > --- > --- a/examples/meson.build > +++ b/examples/meson.build > @@ -35,7 +35,9 @@ foreach example: examples > > ext_deps = [execinfo] > includes = [include_directories(example)] > - deps = ['eal', 'mempool', 'net', 'mbuf', 'ethdev', 'cmdline'] > + if host_machine.system() == 'windows' > + deps = ['eal'] # only supported lib on Windows currently > + endif > subdir(example) This is not what I call keeping build intact for Linux/BSD :) I did not catch it before because test-meson-builds.sh is not testing compilation of the examples with meson. Bruce, may we add it? I will add back the original deps line in master branch. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id A8D7AA0679 for ; Wed, 3 Apr 2019 00:51:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0EBB55B3E; Wed, 3 Apr 2019 00:51:58 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id E149A5B20 for ; Wed, 3 Apr 2019 00:51:56 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 710122208C; Tue, 2 Apr 2019 18:51:56 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 02 Apr 2019 18:51:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=69k6UjuU0KT4IeJIMkhtsnfjl2pXCKLpN0THbo7YjJ4=; b=n/msUVX0rFo3 bQvuMqEOrN/1dZr/5fmugSBF8EBkf1zGEUVe118JowXx5ZZd/t4z6B5VxoWMl2+L b49dpIkRdbVMrp0M4AM3X539p/UP+Rj06LHm8IVDyMH/u5QF4Ostm+JP04oKN8/y PPigUcr6AjtDr6fVHNu21GXn8OGNqlc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=69k6UjuU0KT4IeJIMkhtsnfjl2pXCKLpN0THbo7Yj J4=; b=A2/mynlxZabBha4TJ63a7Ic8xWijIEvmPfjXIPgA+HJpz1r9CKpVv7EAd xK3/gOZMMnTutOa7rGMZN6b8+fn0nYCsKYN52J6LqS26dOBVcjmv/CgI8aM8rom8 Cqpfdqz+/+5gijIrWtynHcEhC0mrj5KmtfXb+DTyFILFsDUpsilTfq1AgmTmq0pM Wjiyymes7+teW/WEa1Q+LU5olgIipkOhLtUhfU9Z0pQK1VJbcC6TOJOOLchmhBow pSXTktEVBXHbO8JMYsvTNvAOoAE8DppFTfnZ2r5N2/XLZa1t0vF2r/EkQcFJK20a hh52r3uI6p9cEcNm7L76kbn/JpEYg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrtddugddugeculddtuddrgedutddrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvden ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhep mhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsth gvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 15FE7E43A3; Tue, 2 Apr 2019 18:51:54 -0400 (EDT) From: Thomas Monjalon To: Anand Rawat Cc: dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com, jeffrey.b.shaw@intel.com, bruce.richardson@intel.com Date: Wed, 03 Apr 2019 00:51:53 +0200 Message-ID: <8636883.cOhKqkjfg7@xps> In-Reply-To: <20190402035458.14664-11-anand.rawat@intel.com> References: <20190306041634.12976-1-anand.rawat@intel.com> <20190402035458.14664-1-anand.rawat@intel.com> <20190402035458.14664-11-anand.rawat@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v8 10/10] build: meson changes to build on windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190402225153.pEMdt3JgLI5gZc2l8q6fqIMTKaGir_aSQqeWh8Nz8ZI@z> 02/04/2019 05:54, Anand Rawat: > Added meson workarounds to build helloworld on Windows. > Windows currently only supports kvargs and eal libraries. > This change restricts the build flow to supported libraries > only. > > Signed-off-by: Anand Rawat > Signed-off-by: Pallavi Kadam > Reviewed-by: Jeff Shaw > Reviewed-by: Ranjit Menon > --- > --- a/examples/meson.build > +++ b/examples/meson.build > @@ -35,7 +35,9 @@ foreach example: examples > > ext_deps = [execinfo] > includes = [include_directories(example)] > - deps = ['eal', 'mempool', 'net', 'mbuf', 'ethdev', 'cmdline'] > + if host_machine.system() == 'windows' > + deps = ['eal'] # only supported lib on Windows currently > + endif > subdir(example) This is not what I call keeping build intact for Linux/BSD :) I did not catch it before because test-meson-builds.sh is not testing compilation of the examples with meson. Bruce, may we add it? I will add back the original deps line in master branch.