From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0086.outbound.protection.outlook.com [104.47.38.86]) by dpdk.org (Postfix) with ESMTP id 86D031BAC4 for ; Thu, 26 Oct 2017 14:59:47 +0200 (CEST) Received: from DM5PR03CA0032.namprd03.prod.outlook.com (10.174.189.149) by MWHPR03MB2703.namprd03.prod.outlook.com (10.168.207.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.156.4; Thu, 26 Oct 2017 12:59:46 +0000 Received: from BN1BFFO11FD038.protection.gbl (2a01:111:f400:7c10::1:187) by DM5PR03CA0032.outlook.office365.com (2603:10b6:4:3b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.178.6 via Frontend Transport; Thu, 26 Oct 2017 12:59:45 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BN1BFFO11FD038.mail.protection.outlook.com (10.58.144.101) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.156.4 via Frontend Transport; Thu, 26 Oct 2017 12:59:45 +0000 Received: from [10.232.134.49] ([10.232.134.49]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id v9QCxb1i027392; Thu, 26 Oct 2017 05:59:38 -0700 To: Thomas Monjalon , Radu Nicolau CC: David Marchand , , Declan Doherty , Pablo de Lara , Hemant Agrawal , , , , Jerin Jacob , "Mcnamara, John" , "Ananyev, Konstantin" , , Olivier Matz References: <1509013365-13819-1-git-send-email-radu.nicolau@intel.com> <2193963.B775pDLU5T@xps> <99778dc4-9fea-e859-71b8-c1ff910eebd2@intel.com> <1837995.9rLZR0Gx80@xps> From: Akhil Goyal Message-ID: <8645d9c8-c2e6-b033-1438-97ef2021ccb2@nxp.com> Date: Thu, 26 Oct 2017 18:29:36 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1837995.9rLZR0Gx80@xps> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131534963853609096; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(7966004)(346002)(376002)(39860400002)(39380400002)(2980300002)(1110001)(1109001)(339900001)(199003)(24454002)(189002)(2950100002)(83506002)(97736004)(23676002)(53546010)(54906003)(110136005)(53936002)(106466001)(105606002)(316002)(69596002)(58126008)(50466002)(86362001)(33646002)(189998001)(31696002)(85426001)(93886005)(561944003)(8676002)(81166006)(8936002)(2906002)(498600001)(47776003)(104016004)(68736007)(81156014)(65806001)(65956001)(4326008)(36756003)(7416002)(6246003)(54356999)(77096006)(356003)(31686004)(65826007)(229853002)(305945005)(5660300001)(50986999)(76176999)(64126003)(230700001)(8656006); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR03MB2703; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD038; 1:mo3197eKu3r3C6hvdBcBfe5M2AxOIfH0UeaCl4E1R/GEME49pgCQGcecsvF8E1BiDzCW0gawdjrk38UoxCkRaK7SyD36OoGnFZJhuFWVFrOY89e94LX1jaOJUVhMRqhU X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 33ae76c7-6a65-47df-c888-08d51c716e80 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(4534020)(4628075)(201703131517081)(2017052603199); SRVR:MWHPR03MB2703; X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2703; 3:HalR4w96Wr+PXKaSwu+mF2ZBihw2IUcIyZXEd7ZVsLlT2l9lOiMyxZV+6xcRF3jdrrFKb5vHAEbOafova8Noh0qn77DAi2pgr8gw3q6Uvjsr0Jx0yFdoytqlh3P3NVtLac7zw3hpEvbvOdBJzEmSIKSiNq0KJdPEPkVsKj1Qdb869bsH5SEURQUuuV4yvzyW0h7IGtfMI3Yp38aXVLz/eEJ/YHxMuYRBgZGWEinRm/XwyjltT3qStkBRIhY+jOOIcXQ/FBRbhwSQ3Z3LJeDK7FRVeyC8NWyU3iJSVAyGBEHu3hZ1lUXq61GDE5E5wPMgAw3yaeDJAIr29OitrfC5Ow==; 25:UYe2LN0YfnbkB84CjWcSLLr3yfcQ1vLKw/VVS2OrkPvSZk6/uzndjpNaeb7mvLmbwKz7BZh+aRvA8CKjEnt3HaBRNSWHlMFgwCldHyggbjkC6b7qhH3/ueLMBXLxB8tI5EH4O99TuqmlDYXkgD1JFIbGA2Ub5zTGyMNoRdgRprshQYUXmD+abeE08NkIorqvWSDZ3mEq2c2vyjgzJPaBHxaXl+1N4AxjUv69xLcdFB8NA0QvaCU8fykH1NzfYPPWnM7RzecIMxn/RGKif5iZ2C6Qp4KPAWs2ovR6S8N7K3DNZqbfAlcXyx254SW4b//HLGfqalId70HM3FU5FwMbKQ==; 31:2S+ecZrd+d3k1Ei4V2z0RVqUr/r3EC/ozgEr6uvuZo85MFjeKOlR7ueEFAC3IaexgtNbqhPkuH6gd8nCoUo63qPPqV5H7807Q7CpoXsIIAOBj3KyJcmqLEF4gm4yHnpcm7vI4Rc/GfAqejJpV4KAH+/krcOedjT6LYTuommpAW9t2Sc00x2JRCju29+2RNsN6j4Gf2nLbs/dwGTbtfeoWVhAY/eXZL7pGGOiGu+oJb8= X-MS-TrafficTypeDiagnostic: MWHPR03MB2703: X-Exchange-Antispam-Report-Test: UriScan:(192374486261705)(228905959029699); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(5005006)(8121501046)(3002001)(3231020)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6096035)(20161123565025)(201703131430075)(201703131433075)(201703131441075)(201703131448075)(201703161259150)(20161123561025)(20161123556025)(20161123559100)(20161123563025)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:MWHPR03MB2703; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:MWHPR03MB2703; X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2703; 4:cgWiW298DV/PMFxJhpRJAlhYIGiSB8jNCtEdnALVI6QNx8hAPAFh+54ud2Zl5EQb3aUSK5WaShDSkzIZPsKaZrYJOdRzhd9TeyhecOgF/s4ZL6k3fNWG0NMKAUyxUBHbKAqGVOXKq7i3Q7adyR4mO0f5WJE+yRrP3ftqw/q/qpWoJGCBBkyzFibbAuVN72tdNATtNmAYUKdV6b1H3+hgANUhSDcVBYHxbaHoZrZViRSut2BDID9vLpEdMHbInDbS1hA7Shzdq22col+lwV6G5HU+DZJ8Lo8SkLkHmpjlfDHQnh7Ya4fr1eeUYqFy695cEfdyfcPf2mozxkPRs0T3DQ== X-Forefront-PRVS: 04724A515E X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtNV0hQUjAzTUIyNzAzOzIzOjRkaDVQalUzbkdYRjZYQU1OWit5Uit1dWk3?= =?utf-8?B?VWtzRWNPeDc4cGpUWHRKVTFUYXRVY0F6b3prbC9JUEN5VmYraVNicXFYRW1u?= =?utf-8?B?SGRtelhTRUdidFBFTXBqelNYUks3WWRNdVV6SUJiU0VmVjZnVzg4Qmp5SzNK?= =?utf-8?B?TFNYSkE0V09LM2NYWEtBMmgrUlRFcnlzSGdZaFN1MnB0UldXVThEMk9FUmI2?= =?utf-8?B?RWNBRDFjbGZ6YWF4K0tPS05ncjNJZVpydXp6akNielh1YkhLdGhadURaTTRj?= =?utf-8?B?WFpFWm90amhDd0I2NFNwNTBsamxDY2N3ajkzVFN0YkRrdGR1c01QTHcyY3JM?= =?utf-8?B?aFlqMXI1cmRTNkpRb2ZkN3NWT0lVdUZGcjNVeHk5ekt5MmpRL1FmbEdjaTNQ?= =?utf-8?B?aDhGRHJyT1dCNHEyemJJNW85blhwWTl2eGE2SjQ0Y3ppUXJmaDZ2WUJwTkJu?= =?utf-8?B?dDBHcExxcVFjZ0xqVXhPcW1CWWpSYUNlL3l3MGROcUR2Njk3L0RWT2kxYXBj?= =?utf-8?B?bTJFNVhYelEydUpZUkhxVys2V2Y0U3lrODZTUFVTNEFaTk9SOFhZYjBhbkdQ?= =?utf-8?B?eGFEVVVFamIrV29YV1BRM1V4ZkRUeExSV1Y5M3dmTCtJSEJrOHo3UmZSK2pv?= =?utf-8?B?YlpYeVJUNVpMaHFPNHpkR0NPRVk2NU8vMkh4WjFIbCtDdXI3Y3VWUVFBdTVt?= =?utf-8?B?VlFiR2F6VmdPL0JESXNQMkYxVkRpYkhmekZlc3g2YXZoWHFFRnRjeXFxQmYr?= =?utf-8?B?dmNPSFhrcVVJbldiUlNERnM2NDF6OHpFejlQMUxNYWwybXJnQ1p2a2Z3OFlE?= =?utf-8?B?Vy82ZTU1USt0ajFiR2FCdXJRRFpnQTRDODJvT09qQ2ViY1hsc3Uva3g4QjBC?= =?utf-8?B?NG5zWnVhaFVGUjFieE9ESTcvTTF5UzJ1WTNGei8zRHYvZEZ1alY2Y0F0RVMw?= =?utf-8?B?a1F1NEhobEhvbkxXcWhqRWd3amVyZmNIZkJ0UUNUWWU3NXdKaUxzMGZXbVJF?= =?utf-8?B?S1BaY0JVcURjWUE5M2xBY1VNa1lkMzNhTjNDanRIOFNuVUxBaWRDWVVueWQv?= =?utf-8?B?bU1PR1NnM3lOY2VNSXJxbnZYaFlCYXZ2NXlxS2t2WGt2QjVPL3VNalM1Y1M2?= =?utf-8?B?YmxKcWEwcDVyQVBjcUwxMThrY2VvUm9LZ29JRzFNd2FpRDg0T0YxdG5qenAy?= =?utf-8?B?ZXl6elFlcENFcks0M3A0RFA4dldna0I2TWJ5OUl2aVo0M1lNMjFkbElMRjRl?= =?utf-8?B?cU5NMG1IZ1ZJSCtCSnRLK05MWVMvb0NGZXRYdVBidE1SZDRPcittNHE4amVZ?= =?utf-8?B?a3dVY1EyMG82ZXlkSlVaQUR3WkdxUDUreU92K2JjN2N4SnFxL1UvQU43bTM5?= =?utf-8?B?cWVnK3FvWTEwbStJVGlPNjlDclNwbXlxanNsZko1ZHl1bDNmQllkUkZNL2Zr?= =?utf-8?B?azBNcDFDczllVmlkYXM0VkZTOWpkNDVwT3ZQNVpUbEt2Zm05RHQ3TCs3M1Jx?= =?utf-8?B?TVlvWmJ0OW9acDl2ejMrbXZoek9iV25DenYxUkdWdGJkWUpVSllUTitEZnJL?= =?utf-8?B?SGp4Q3NsMGhYaE5JeGZQaW1WdzJvQ3lPd3U5WEErcmdwNXNzOGdPMlhIR2FG?= =?utf-8?B?Q0dTTEUvTnZoWnE1YlJiMTV3bWtrNWJMa1gxdzZ5V1dRb1ljbE9xWURsL1Y2?= =?utf-8?B?NVRKcjUzOERPZGdYUFBaK29kQ3pWb3ltbk44ZWViNzcrT3c3bkhaSGdzOEpv?= =?utf-8?B?cGJ2NEUrYzJidi8rVEc5YU4xNzlSbUpxTWVLZERNK2NCR2NVVDlON29zcy9Y?= =?utf-8?B?MGRDbEFqV1BpcmlNdDY0elBwdVJBZnpvZjVFYXhRK2ZhNzdtSHlyVWgyU0ky?= =?utf-8?B?cnpBZ0xjL0tUYWlhTE9vQjd2ckpZdTlHbFJDUnlqWHBwYXo3L2swNll5U0pJ?= =?utf-8?B?TUZXb1BJQWJFZ2RURGN6UFFJY2E2Mzd1T3dQa0tPZnF5dHZOeXhSOGhrTk5v?= =?utf-8?Q?r8Q5ft?= X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2703; 6:5+R+l1zqvEt+O76KT/gJ/hjmBBUXlTxShaWQ7nZvagF+bV0zfpvtT09X7b0NLmj9AOj7sJlBcIlAtDNsbWxlKZ7VnmnVIkC8oTmbq0SyAmjXN46RpmVaRtfhasHXSukTUiiBL6XvTn5AciWosdARA++qU1LnouPMY0FjoJkltP8MTXc8YFWhnXI4w3FBZ12H+3HIMpeAri0gPxKIGa9cB/eka3PHJD1KQgpRA3DataLFC3ddp/t7qSeYvDhjhaOgDZ13W7uFTh6wLFhPNPNOHIdb0dk9j51wQx4h4mS9osij+5TJay3M9Pxtc2FSAen2uaY+IZbfNHSuT02BlQtieg==; 5:ZED6APYdvAT1tODyXAsFJfGBGYAco9tEqVJ7wvA12Zf5ROCywgFGwZ9QEejUvvsdEr15O3CuLSnsJASidm0l3odJdfBHFl2ZG7afaM745bJhKWDgWK3zviGlQi1gS5V8T+HEOd1MMSdQzuVkLZp4ng==; 24:WsNNNyOls8usg0Yi2TsdnKxfwZG1FxB+bBgw5SOgbVpnP9D9yvnloWMpABCijmfflK8r/dFMI1syseqowF4VvFQTqw/OSCF7bvEEYU6forU=; 7:02rfbqJKAcF5WtoNaZEbmsPISV6pLdD57subyUW2kRL88bnXqF4et4WIZJwRZ7R44ZTZY1ri4MZeuA+uOoanYLLeR4u/F71sQI8+bCz+OR7tiSVEW8sreplEcyO0DI52Qtopi8bdBU/jBuS8WeX1Av5HVU3jne3+xOTg7wu4K1q41IQAQMHZQAEX1Y5D8ekryCMKygiCqf7SanLPr1x8cA8ePBlsd/Zr/rYa5+qi3mA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2017 12:59:45.0021 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 33ae76c7-6a65-47df-c888-08d51c716e80 X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2703 Subject: Re: [dpdk-dev] [PATCH 2/3] net/ixgbe: fix build issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Oct 2017 12:59:48 -0000 Hi Thomas, On 10/26/2017 6:03 PM, Thomas Monjalon wrote: > 26/10/2017 14:28, Radu Nicolau: >> >> On 10/26/2017 12:39 PM, Thomas Monjalon wrote: >>> 26/10/2017 13:27, David Marchand: >>>> On Thu, Oct 26, 2017 at 1:01 PM, Radu Nicolau wrote: >>>>> On 10/26/2017 11:36 AM, David Marchand wrote: >>>>>> On Thu, Oct 26, 2017 at 12:22 PM, Radu Nicolau >>>>>> wrote: >>>>>>> --- a/drivers/net/ixgbe/Makefile >>>>>>> +++ b/drivers/net/ixgbe/Makefile >>>>>>> +ifneq ($(MAKECMDGOALS),clean) >>>>>>> +ifneq ($(CONFIG_RTE_LIBRTE_SECURITY),y) >>>>>>> +$(error "RTE_LIBRTE_SECURITY is required to build RTE_LIBRTE_IXGBE_PMD") >>>>>>> +endif >>>>>>> +endif >>>>>> This is a no go for me unless you explain how it is impossible to >>>>>> disable it in the code. >>>>>> >>>>>> >>>>> It can be disabled in the code, but as far as I know there is a general push >>>>> back against having conditionally compiled code. I originally had the >>>>> security sections in ixgbe PMD isolated, but the feedback was to have them >>>>> always on. >>>> In my mind, this was to stop having features enabled per pmd (and stop >>>> the nightmare with 10 options in a pmd). >>>> Having features globally enabled for all or nothing is still >>>> acceptable, is it not ? >>> Yes there is a config option for rte_security, >>> and it is acceptable. >>> The code depending on it must be ifdef'ed. >> >> Given that both ixgbe and dpaa2_sec are now security enabled PMDs, I >> would go with Konstantin's proposal, have rte_security listed as a >> dependency (instead of the explicit check). > > Please consider my request instead. > Until now we are ifdef'ing code to allow disabling any lib. > We are not going to change our mind during the last days of a release. > Please just fix it for now. > > For dpaa2_sec we do not want to make the driver run without rte_security. We do not see people using it without rte_security. Will take the Makefile changes that Radu has done in 1st patch of this series. -Akhil