From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3E6A9A0543; Tue, 21 Jun 2022 09:57:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2F8F64069C; Tue, 21 Jun 2022 09:57:12 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2077.outbound.protection.outlook.com [40.107.243.77]) by mails.dpdk.org (Postfix) with ESMTP id DBF4440151 for ; Tue, 21 Jun 2022 09:57:10 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Cwd048GL0i0zS8iGUpzFOtrUTyJS0oVyjH3wsmEGNHgPoPLqgu5x4zrT2wJUFqM88u3GBa6jhYAPrrIFxRMDEmrwLerNF8DwibKALMRlrd7eG2L5mXGGTzmssL6uenmJHsZhVdTpWhYEOayjFkwtr9DWi/pkHQE6ktm4wtQH2ayk2+jRKNmYUk0MyQnTt9UHCeu0wNwPrYnxsUDLUH1qZRDF3jJR2hvDuIrlmn5b0ikwO7vofSkTFV50igpWZjhT1l5XGtUABhuqCpCvTxyx/n1CsMueZ49lUFRbGssllFqyv3dLtsVbf3BN1l7hETcBAl1OdKywMrwzTStgSZuYZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZBJYkLysdm/PBWjyv2SfE4yA2pY684Y0eMcAPiw3ulk=; b=SfTGU2v/WR8U9WWJ67qYhDcB+ZxG3asLnV8mB1ocJ/9vY18lrqtsCc5EZ5BlrvKordh7tgTSivSMmY1pqm1F7F+hPGnDnqiAklB7UbH3t2No0DqP6CNR/AoyyyJQioIIS8+5kR/tqD2+A1UNqutgX6+WXMrj+XhBpXgteM4BVMbiDIJMFsOssWL97/IFFxy5cuzfftJ6KhRtrEAneDiDNCprDF7CORXuGaXJRqRTvYJ086L6LwRnO/7Zk/xDzO8v0fikJ6PYKMt51GG1o+UQqKCGtv5EiFbLCkTYw7VgsX+vLklmL4Mo6mYlr1wiPrgzIDZexoCq52Lww6IZWs+1Xw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=broadcom.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZBJYkLysdm/PBWjyv2SfE4yA2pY684Y0eMcAPiw3ulk=; b=T7423JvUbayIwP+K6CWU7wETC3jVsp0aimIbOELEgqhGQhk6xk2u1rx4msGxhCex0vqOUkxVlmqBuH5PTHkXuGSWvQhXxcjqicJpotyMrydMIU8FiHqr0Mx5ARovVnaBaAgrQTTf4s5LiKFyTxbvEXxgMkaYEIXoP6McjscyEE4= Received: from SN1PR12CA0094.namprd12.prod.outlook.com (2603:10b6:802:21::29) by MW4PR02MB7412.namprd02.prod.outlook.com (2603:10b6:303:70::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.16; Tue, 21 Jun 2022 07:57:09 +0000 Received: from SN1NAM02FT0041.eop-nam02.prod.protection.outlook.com (2603:10b6:802:21:cafe::31) by SN1PR12CA0094.outlook.office365.com (2603:10b6:802:21::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.16 via Frontend Transport; Tue, 21 Jun 2022 07:57:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com; pr=C Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by SN1NAM02FT0041.mail.protection.outlook.com (10.97.5.44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5353.14 via Frontend Transport; Tue, 21 Jun 2022 07:57:07 +0000 Received: from xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Tue, 21 Jun 2022 08:57:06 +0100 Received: from smtp.xilinx.com (172.21.105.197) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Tue, 21 Jun 2022 08:57:06 +0100 Envelope-to: damodharam.ammepalli@broadcom.com, ajit.khaparde@broadcom.com, dev@dpdk.org Received: from [10.71.119.54] (port=50626) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1o3Yl0-0006y9-0n; Tue, 21 Jun 2022 08:57:06 +0100 Message-ID: <8645e0d1-9878-3f51-99c3-4d472bc9940a@xilinx.com> Date: Tue, 21 Jun 2022 08:57:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [dpdk-dev] [PATCH 4/8] net/bnxt: allow Tx only or Rx only configs in PMD Content-Language: en-US To: Damodharam Ammepalli CC: 'Ajit Kumar Khaparde' , 'dpdk-dev' References: <20220615145703.6613-1-kalesh-anakkur.purayil@broadcom.com> <20220615145703.6613-5-kalesh-anakkur.purayil@broadcom.com> <82e65d9f-7b5f-25de-65db-6d3f2f67fe27@xilinx.com> <00f201d8852b$006b0050$014100f0$@broadcom.com> From: Ferruh Yigit In-Reply-To: <00f201d8852b$006b0050$014100f0$@broadcom.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b4fb5205-165f-4c73-2510-08da535ba3d0 X-MS-TrafficTypeDiagnostic: MW4PR02MB7412:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: alMDtUzP/5PbSZYOp1sWCUh7yxOI6P7G/nD6AfhZXxf/RCe+e6s4JMy5LHEceK3Ouk6DR6xoJS8tieyoFGgKKm/9aoip8mKtfyPe25fVV1ZUtsKXgvYykOV1nsxdKnMBN94V3Te6UVjKTlsG9ikPkdyOh7Sxt6aizhNoM7DEkqHtZF6pCQdGN8/KQjfgFO0UkSJ8g3DkAIenEn0UeRT5Knq4PZpgYDIl8Lp43TGYGpepkx6PWSO8a3LQ1Sgtu3NvlqzQSocWQrM5lK435kl9tCAdhFBnnX8aFrTMb8gAiP5LDLP2+pALpfVs8LuBhf3d9dkeg9v7gfN7VMjntHVRt2yr/kVcgjPGlT7QB7E8wUy+gCQdXmeH1a0OQSqjcnp8U7WcshWElCqbsT0pQ25EQVYl8BIgps82haNUuXUVxdPn3gHcAELEXgcp87dOmq1dIAHf1n/g2lgIScNQasAysGw+7F1cwJi6uZpR2dvvfdlZ4u9e3GW/YwIgSQKb5enjWV6Ks9mAJWcttADvYCf5lHfse3VQK2g/qXaKEh+C0gC40dt9WFfFQw2suzhoNXI9MCdoLchmhafBxtSchBKqCii0NOmokl6pCc+ShAsYb11tyTud2GxBmJLAzoYAUW8P25asBWkzhf4tQ3en49n8FGrnRYZdhKPmwKWtXVORVCHCzSIYLYUT/3QAICtC3vliXPkeN0Yg/tYjrRZkJVGsIJTMwW9wNbcOOHc3+Gs/k1xW+wQKYcRWDpX3xs+Vivpr9KXdPFB7CeqXoKPAu9FG1g== X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch01.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230016)(4636009)(346002)(39860400002)(136003)(376002)(396003)(36840700001)(46966006)(40470700004)(2616005)(40480700001)(426003)(8676002)(336012)(186003)(82310400005)(41300700001)(31686004)(316002)(47076005)(70206006)(70586007)(83380400001)(36756003)(4326008)(54906003)(40460700003)(26005)(9786002)(44832011)(478600001)(5660300002)(8936002)(31696002)(7636003)(53546011)(36860700001)(356005)(2906002)(82740400003)(6916009)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2022 07:57:07.8990 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b4fb5205-165f-4c73-2510-08da535ba3d0 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0041.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR02MB7412 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/21/2022 5:54 AM, Damodharam Ammepalli wrote: > Hi Ferruh, > > Please see my inline responses [Damo]; > > Thanks > > Damo > > *From:*Kalesh Anakkur Purayil > *Sent:* Monday, June 20, 2022 9:47 PM > *To:* Ferruh Yigit ; Damodharam Ammepalli > > *Cc:* Ajit Kumar Khaparde ; dpdk-dev > > *Subject:* Re: [dpdk-dev] [PATCH 4/8] net/bnxt: allow Tx only or Rx only > configs in PMD > > Hi Damo, > > Could you please respond to Ferruh's question? > > Regards, > > Kalesh > > On Thu, Jun 16, 2022 at 10:33 PM Ferruh Yigit > wrote: > > On 6/15/2022 3:56 PM, Kalesh A P wrote: > > > > > From: Damodharam Ammepalli > > > > > Currently, we fail the init/probe of pmd if > eth_dev->data->nb_tx_queues > > or eth_dev->data->nb_rx_queues is 0. We are removing this check. > > > > Is there a valid usecase for Rx only or Tx only config? > I assume testpmd doesn't support it, how are you testing this? > [Damo]: > > Yes. There is a valid use case. We are trying to address a > > customer request, to deploy an application in Rxonly mode. > OK, I just want to confirm this is a valid usecase. > This is the sample testpmd command we used in our unit tests. > > ./build/app/dpdk-testpmd -c 0xff  -n 4 --log-level="pmd.",7 > > --socket-mem 0,1024  -- --forward-mode=rxonly --txq=0 -i > Got it, testpmd 'rxonly', and possibly 'txonly', mode is working. > We can update the commit headline to indicate Rx only configuration to > > prevent misunderstanding. > > Please let me know and we will address accordingly. > I think it is OK as it is, thanks for clarification. > > > Fixes: daef48efe5e5 ("net/bnxt: support set MTU") > > Cc: stable@dpdk.org > > > > Signed-off-by: Damodharam Ammepalli > > > > Reviewed-by: Ajit Khaparde > > > Reviewed-by: Somnath Kotur > > > --- > >   drivers/net/bnxt/bnxt_ethdev.c | 7 +------ > >   1 file changed, 1 insertion(+), 6 deletions(-) > > > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c > b/drivers/net/bnxt/bnxt_ethdev.c > > index 34f2149..8181e1f 100644 > > --- a/drivers/net/bnxt/bnxt_ethdev.c > > +++ b/drivers/net/bnxt/bnxt_ethdev.c > > @@ -723,7 +723,7 @@ static int bnxt_alloc_prev_ring_stats(struct > bnxt *bp) > >                                               sizeof(struct > bnxt_ring_stats) * > >                                               bp->tx_cp_nr_rings, > >                                               0); > > -       if (bp->prev_tx_ring_stats == NULL) > > +       if (bp->tx_cp_nr_rings > 0 && bp->prev_tx_ring_stats == NULL) > >                  goto error; > > > >          return 0; > > @@ -1567,11 +1567,6 @@ int bnxt_dev_start_op(struct rte_eth_dev > *eth_dev) > >          int vlan_mask = 0; > >          int rc, retry_cnt = BNXT_IF_CHANGE_RETRY_COUNT; > > > > -       if (!eth_dev->data->nb_tx_queues || > !eth_dev->data->nb_rx_queues) { > > -               PMD_DRV_LOG(ERR, "Queues are not configured yet!\n"); > > -               return -EINVAL; > > -       } > > - > >          if (bp->rx_cp_nr_rings > RTE_ETHDEV_QUEUE_STAT_CNTRS) > >                  PMD_DRV_LOG(ERR, > >                              "RxQ cnt %d > > RTE_ETHDEV_QUEUE_STAT_CNTRS %d\n", > > -- > > 2.10.1 > > > > > -- > > Regards, > > Kalesh A P > > > This electronic communication and the information and any files > transmitted with it, or attached to it, are confidential and are > intended solely for the use of the individual or entity to whom it is > addressed and may contain information that is confidential, legally > privileged, protected by privacy laws, or otherwise restricted from > disclosure to anyone else. If you are not the intended recipient or the > person responsible for delivering the e-mail to the intended recipient, > you are hereby notified that any use, copying, distributing, > dissemination, forwarding, printing, or copying of this e-mail is > strictly prohibited. If you received this e-mail in error, please return > the e-mail to the sender, delete it from your computer, and destroy any > printed copy of it.