From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, david.hunt@intel.com, john.mcnamara@intel.com,
ferruh.yigit@intel.com
Subject: Re: [dpdk-dev] [PATCH] devbind: don't display non-existent device categories
Date: Mon, 19 Nov 2018 10:03:40 +0000 [thread overview]
Message-ID: <864f7743-aaaf-8f6a-d37e-c182a9b4f88d@intel.com> (raw)
In-Reply-To: <2050019.mpedAaAYAq@xps>
On 18-Nov-18 11:13 PM, Thomas Monjalon wrote:
> 13/11/2018 17:42, Anatoly Burakov:
>> --- a/usertools/dpdk-devbind.py
>> +++ b/usertools/dpdk-devbind.py
>> + n_devs = len(dpdk_drv) + len(kernel_drv) + len(no_drv)
>> +
>> + # don't bother displaying anything if there are no devices
>> + if n_devs == 0:
>> + msg = "No '%s' devices detected" % device_name
>> + print("")
>> + print(msg)
>> + print("".join('=' * len(msg)))
>> + return
>> +
>
> Indentation is wrong here:
> TabError: inconsistent use of tabs and spaces in indentation
>
Oops, auto indentation in my editor strikes again... i'll submit a v2.
--
Thanks,
Anatoly
next prev parent reply other threads:[~2018-11-19 10:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 16:42 Anatoly Burakov
2018-11-15 13:27 ` Hunt, David
2018-11-15 14:06 ` Wiles, Keith
2018-11-18 23:13 ` Thomas Monjalon
2018-11-19 10:03 ` Burakov, Anatoly [this message]
2018-11-19 10:33 ` [dpdk-dev] [PATCH v2] " Anatoly Burakov
2018-11-22 17:12 ` Thomas Monjalon
2018-11-23 9:23 ` Burakov, Anatoly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=864f7743-aaaf-8f6a-d37e-c182a9b4f88d@intel.com \
--to=anatoly.burakov@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=john.mcnamara@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).