From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 005652B92 for ; Mon, 19 Nov 2018 11:03:43 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Nov 2018 02:03:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,252,1539673200"; d="scan'208";a="93167880" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.124]) ([10.237.220.124]) by orsmga008.jf.intel.com with ESMTP; 19 Nov 2018 02:03:41 -0800 To: Thomas Monjalon Cc: dev@dpdk.org, david.hunt@intel.com, john.mcnamara@intel.com, ferruh.yigit@intel.com References: <07b7c67be5adc770b028212ef8918d4ae8f11255.1542127066.git.anatoly.burakov@intel.com> <2050019.mpedAaAYAq@xps> From: "Burakov, Anatoly" Message-ID: <864f7743-aaaf-8f6a-d37e-c182a9b4f88d@intel.com> Date: Mon, 19 Nov 2018 10:03:40 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <2050019.mpedAaAYAq@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] devbind: don't display non-existent device categories X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Nov 2018 10:03:44 -0000 On 18-Nov-18 11:13 PM, Thomas Monjalon wrote: > 13/11/2018 17:42, Anatoly Burakov: >> --- a/usertools/dpdk-devbind.py >> +++ b/usertools/dpdk-devbind.py >> + n_devs = len(dpdk_drv) + len(kernel_drv) + len(no_drv) >> + >> + # don't bother displaying anything if there are no devices >> + if n_devs == 0: >> + msg = "No '%s' devices detected" % device_name >> + print("") >> + print(msg) >> + print("".join('=' * len(msg))) >> + return >> + > > Indentation is wrong here: > TabError: inconsistent use of tabs and spaces in indentation > Oops, auto indentation in my editor strikes again... i'll submit a v2. -- Thanks, Anatoly