[dpdk-dev] [PATCH] maintainers: claim co-maintainership of LPM

[dpdk-dev] [PATCH] maintainers: claim co-maintainership of LPM

[Vladimir Medvedkin]

Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 835d8a201..eef480ab5 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1133,6 +1133,7 @@ F: test/test/test_func_reentrancy.c
 
 LPM
 M: Bruce Richardson <bruce.richardson@intel.com>
+M: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
 F: lib/librte_lpm/
 F: doc/guides/prog_guide/lpm*
 F: test/test/test_lpm*
-- 
2.17.1

--------------------------------------------------------------
Intel Research and Development Ireland Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263


This e-mail and any attachments may contain confidential material for the sole
use of the intended recipient(s). Any review or distribution by others is
strictly prohibited. If you are not the intended recipient, please contact the
sender and delete all copies.

[dpdk-dev] [PATCH] maintainers: claim maintainership of Toeplitz hash

[Vladimir Medvedkin]

Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
---
 MAINTAINERS | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index eef480ab5..81affda53 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1131,6 +1131,9 @@ F: doc/guides/prog_guide/hash_lib.rst
 F: test/test/test_*hash*
 F: test/test/test_func_reentrancy.c
 
+M: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
+F: lib/librte_hash/rte_thash.h
+
 LPM
 M: Bruce Richardson <bruce.richardson@intel.com>
 M: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
-- 
2.17.1

--------------------------------------------------------------
Intel Research and Development Ireland Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263


This e-mail and any attachments may contain confidential material for the sole
use of the intended recipient(s). Any review or distribution by others is
strictly prohibited. If you are not the intended recipient, please contact the
sender and delete all copies.

[dpdk-dev] [PATCH] rte_thash: replace license text with SPDX tag

[Vladimir Medvedkin]

Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
---
 lib/librte_hash/rte_thash.h | 33 ++-------------------------------
 1 file changed, 2 insertions(+), 31 deletions(-)

diff --git a/lib/librte_hash/rte_thash.h b/lib/librte_hash/rte_thash.h
index a6ddb7bf7..1b33f4813 100644
--- a/lib/librte_hash/rte_thash.h
+++ b/lib/librte_hash/rte_thash.h
@@ -1,34 +1,5 @@
-/*-
- *   BSD LICENSE
- *
- *   Copyright(c) 2015 Vladimir Medvedkin <medvedkinv@gmail.com>
- *   All rights reserved.
- *
- *   Redistribution and use in source and binary forms, with or without
- *   modification, are permitted provided that the following conditions
- *   are met:
- *
- *     * Redistributions of source code must retain the above copyright
- *       notice, this list of conditions and the following disclaimer.
- *     * Redistributions in binary form must reproduce the above copyright
- *       notice, this list of conditions and the following disclaimer in
- *       the documentation and/or other materials provided with the
- *       distribution.
- *     * Neither the name of Intel Corporation nor the names of its
- *       contributors may be used to endorse or promote products derived
- *       from this software without specific prior written permission.
- *
- *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2015-2019 Vladimir Medvedkin <medvedkinv@gmail.com>
  */
 
 #ifndef _RTE_THASH_H
-- 
2.17.1

--------------------------------------------------------------
Intel Research and Development Ireland Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263


This e-mail and any attachments may contain confidential material for the sole
use of the intended recipient(s). Any review or distribution by others is
strictly prohibited. If you are not the intended recipient, please contact the
sender and delete all copies.

Re: [dpdk-dev] [PATCH] maintainers: claim co-maintainership of LPM

[Bruce Richardson]

On Sun, Feb 03, 2019 at 04:34:45PM +0000, Vladimir Medvedkin wrote:
> Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 835d8a201..eef480ab5 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1133,6 +1133,7 @@ F: test/test/test_func_reentrancy.c
>  
>  LPM
>  M: Bruce Richardson <bruce.richardson@intel.com>
> +M: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
>  F: lib/librte_lpm/
>  F: doc/guides/prog_guide/lpm*
>  F: test/test/test_lpm*
> -- 
> 2.17.1
Thanks.
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

[dpdk-dev] [PATCH v2] maintainers: claim co-maintainership of LPM

[Vladimir Medvedkin]

Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
---
v2:
- remove mail footer

 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 835d8a2..eef480a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1133,6 +1133,7 @@ F: test/test/test_func_reentrancy.c
 
 LPM
 M: Bruce Richardson <bruce.richardson@intel.com>
+M: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
 F: lib/librte_lpm/
 F: doc/guides/prog_guide/lpm*
 F: test/test/test_lpm*
-- 
2.7.4

[dpdk-dev] [PATCH v2] maintainers: claim maintainership of Toeplitz hash

[Vladimir Medvedkin]

Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
---
v2:
- remove mail footer

 MAINTAINERS | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index eef480a..81affda 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1131,6 +1131,9 @@ F: doc/guides/prog_guide/hash_lib.rst
 F: test/test/test_*hash*
 F: test/test/test_func_reentrancy.c
 
+M: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
+F: lib/librte_hash/rte_thash.h
+
 LPM
 M: Bruce Richardson <bruce.richardson@intel.com>
 M: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
-- 
2.7.4

[dpdk-dev] [PATCH v2] rte_thash: replace license text with SPDX tag

[Vladimir Medvedkin]

Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
---
v2:
- remove mail footer

 lib/librte_hash/rte_thash.h | 33 ++-------------------------------
 1 file changed, 2 insertions(+), 31 deletions(-)

diff --git a/lib/librte_hash/rte_thash.h b/lib/librte_hash/rte_thash.h
index a6ddb7b..1b33f48 100644
--- a/lib/librte_hash/rte_thash.h
+++ b/lib/librte_hash/rte_thash.h
@@ -1,34 +1,5 @@
-/*-
- *   BSD LICENSE
- *
- *   Copyright(c) 2015 Vladimir Medvedkin <medvedkinv@gmail.com>
- *   All rights reserved.
- *
- *   Redistribution and use in source and binary forms, with or without
- *   modification, are permitted provided that the following conditions
- *   are met:
- *
- *     * Redistributions of source code must retain the above copyright
- *       notice, this list of conditions and the following disclaimer.
- *     * Redistributions in binary form must reproduce the above copyright
- *       notice, this list of conditions and the following disclaimer in
- *       the documentation and/or other materials provided with the
- *       distribution.
- *     * Neither the name of Intel Corporation nor the names of its
- *       contributors may be used to endorse or promote products derived
- *       from this software without specific prior written permission.
- *
- *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2015-2019 Vladimir Medvedkin <medvedkinv@gmail.com>
  */
 
 #ifndef _RTE_THASH_H
-- 
2.7.4

Re: [dpdk-dev] [PATCH v2] maintainers: claim maintainership of Toeplitz hash

[Thomas Monjalon]

05/02/2019 14:57, Vladimir Medvedkin:
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> +M: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> +F: lib/librte_hash/rte_thash.h

I'm not sure about adding maintainership for one file.
You are the author of this file, so you should be consulted
during reviews if you don't catch them by yourself.
But I prefer seeing maintainers as taking charge and understanding of
a full library as a block.

And unfortunately, it does not work with the script:
	devtools/get-maintainer.sh lib/librte_hash/rte_cuckoo_hash.h
You would appear as maintainer for all hash files.

Re: [dpdk-dev] [PATCH v2] maintainers: claim co-maintainership of LPM

[Thomas Monjalon]

05/02/2019 14:57, Vladimir Medvedkin:
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
>  LPM
>  M: Bruce Richardson <bruce.richardson@intel.com>
> +M: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
>  F: lib/librte_lpm/
>  F: doc/guides/prog_guide/lpm*
>  F: test/test/test_lpm*

Acked-by: Bruce Richardson <bruce.richardson@intel.com>
(from v1)

Applied, thanks

Re: [dpdk-dev] [PATCH v2] rte_thash: replace license text with SPDX tag

[Thomas Monjalon]

05/02/2019 14:57, Vladimir Medvedkin:
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2015-2019 Vladimir Medvedkin <medvedkinv@gmail.com>
>   */

Applied, thanks

Re: [dpdk-dev] [PATCH v2] maintainers: claim maintainership of Toeplitz hash

[Medvedkin, Vladimir]

On 06/02/2019 10:38, Thomas Monjalon wrote:
> 05/02/2019 14:57, Vladimir Medvedkin:
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> +M: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
>> +F: lib/librte_hash/rte_thash.h
> I'm not sure about adding maintainership for one file.
> You are the author of this file, so you should be consulted
> during reviews if you don't catch them by yourself.
> But I prefer seeing maintainers as taking charge and understanding of
> a full library as a block.
>
> And unfortunately, it does not work with the script:
> 	devtools/get-maintainer.sh lib/librte_hash/rte_cuckoo_hash.h
> You would appear as maintainer for all hash files.

It could be solved by adding header.

In fact thash is not used by other parts of the hash library (instead it 
could be used by softnic for example).

 From my point of view, hash library consists of two parts, hash table 
itself and a number of hash functions. Hash functions, in turn, can be 
used for many other purposes, not just for a hash table. Maybe we should 
separate hash functions and hash table? And if you think it is a bad 
idea, so be it, 4 maintainers for hash is enough.

>
>
>

Re: [dpdk-dev] [PATCH v2] maintainers: claim maintainership of Toeplitz hash

[Thomas Monjalon]

07/02/2019 20:28, Medvedkin, Vladimir:
> On 06/02/2019 10:38, Thomas Monjalon wrote:
> > 05/02/2019 14:57, Vladimir Medvedkin:
> >> --- a/MAINTAINERS
> >> +++ b/MAINTAINERS
> >> +M: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> >> +F: lib/librte_hash/rte_thash.h
> > I'm not sure about adding maintainership for one file.
> > You are the author of this file, so you should be consulted
> > during reviews if you don't catch them by yourself.
> > But I prefer seeing maintainers as taking charge and understanding of
> > a full library as a block.
> >
> > And unfortunately, it does not work with the script:
> > 	devtools/get-maintainer.sh lib/librte_hash/rte_cuckoo_hash.h
> > You would appear as maintainer for all hash files.
> 
> It could be solved by adding header.
> 
> In fact thash is not used by other parts of the hash library (instead it 
> could be used by softnic for example).
> 
>  From my point of view, hash library consists of two parts, hash table 
> itself and a number of hash functions. Hash functions, in turn, can be 
> used for many other purposes, not just for a hash table. Maybe we should 
> separate hash functions and hash table? And if you think it is a bad 
> idea, so be it, 4 maintainers for hash is enough.

I don't know.
It's opening the door for more split of maintainers areas.
I would like to get more opinions from other maintainers, please.

Re: [dpdk-dev] [PATCH v2] maintainers: claim maintainership of Toeplitz hash

[Gobriel, Sameh]

I agree with Thomas. It makes sense to separate out hash function from hash table implementation. 

Sameh

-----Original Message-----
From: Thomas Monjalon [mailto:thomas@monjalon.net] 
Sent: Thursday, February 7, 2019 1:25 PM
To: Medvedkin, Vladimir <vladimir.medvedkin@intel.com>
Cc: dev@dpdk.org; Wang, Yipeng1 <yipeng1.wang@intel.com>; Gobriel, Sameh <sameh.gobriel@intel.com>; Richardson, Bruce <bruce.richardson@intel.com>; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] maintainers: claim maintainership of Toeplitz hash

07/02/2019 20:28, Medvedkin, Vladimir:
> On 06/02/2019 10:38, Thomas Monjalon wrote:
> > 05/02/2019 14:57, Vladimir Medvedkin:
> >> --- a/MAINTAINERS
> >> +++ b/MAINTAINERS
> >> +M: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> >> +F: lib/librte_hash/rte_thash.h
> > I'm not sure about adding maintainership for one file.
> > You are the author of this file, so you should be consulted during 
> > reviews if you don't catch them by yourself.
> > But I prefer seeing maintainers as taking charge and understanding 
> > of a full library as a block.
> >
> > And unfortunately, it does not work with the script:
> > 	devtools/get-maintainer.sh lib/librte_hash/rte_cuckoo_hash.h You 
> > would appear as maintainer for all hash files.
> 
> It could be solved by adding header.
> 
> In fact thash is not used by other parts of the hash library (instead 
> it could be used by softnic for example).
> 
>  From my point of view, hash library consists of two parts, hash table 
> itself and a number of hash functions. Hash functions, in turn, can be 
> used for many other purposes, not just for a hash table. Maybe we 
> should separate hash functions and hash table? And if you think it is 
> a bad idea, so be it, 4 maintainers for hash is enough.

I don't know.
It's opening the door for more split of maintainers areas.
I would like to get more opinions from other maintainers, please.

Re: [dpdk-dev] [PATCH v2] maintainers: claim maintainership of Toeplitz hash

[Wang, Yipeng1]

Hi Vladimir,

Thanks for stepping up for the maintaining job.

I agree with you that they are two parts and we mixed hash table and hashing function from beginning. They are actually should be two libraries, but at this
Stage it is not very necessary to change the situation yet I think.

If you trust us, I will definitely consult with you for questions coming up about thash (also other hash functions like crc and jhash to the corresponding
Authors). I will also get more familiar with the code as the maintainer.

Thanks
Yipeng

>-----Original Message-----
>From: Gobriel, Sameh
>Sent: Thursday, February 7, 2019 1:33 PM
>To: Thomas Monjalon <thomas@monjalon.net>; Medvedkin, Vladimir <vladimir.medvedkin@intel.com>
>Cc: dev@dpdk.org; Wang, Yipeng1 <yipeng1.wang@intel.com>; Richardson, Bruce <bruce.richardson@intel.com>; De Lara Guarch,
>Pablo <pablo.de.lara.guarch@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>
>Subject: RE: [dpdk-dev] [PATCH v2] maintainers: claim maintainership of Toeplitz hash
>
>I agree with Thomas. It makes sense to separate out hash function from hash table implementation.
>
>Sameh
>
>-----Original Message-----
>From: Thomas Monjalon [mailto:thomas@monjalon.net]
>Sent: Thursday, February 7, 2019 1:25 PM
>To: Medvedkin, Vladimir <vladimir.medvedkin@intel.com>
>Cc: dev@dpdk.org; Wang, Yipeng1 <yipeng1.wang@intel.com>; Gobriel, Sameh <sameh.gobriel@intel.com>; Richardson, Bruce
><bruce.richardson@intel.com>; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>
>Subject: Re: [dpdk-dev] [PATCH v2] maintainers: claim maintainership of Toeplitz hash
>
>07/02/2019 20:28, Medvedkin, Vladimir:
>> On 06/02/2019 10:38, Thomas Monjalon wrote:
>> > 05/02/2019 14:57, Vladimir Medvedkin:
>> >> --- a/MAINTAINERS
>> >> +++ b/MAINTAINERS
>> >> +M: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
>> >> +F: lib/librte_hash/rte_thash.h
>> > I'm not sure about adding maintainership for one file.
>> > You are the author of this file, so you should be consulted during
>> > reviews if you don't catch them by yourself.
>> > But I prefer seeing maintainers as taking charge and understanding
>> > of a full library as a block.
>> >
>> > And unfortunately, it does not work with the script:
>> > 	devtools/get-maintainer.sh lib/librte_hash/rte_cuckoo_hash.h You
>> > would appear as maintainer for all hash files.
>>
>> It could be solved by adding header.
>>
>> In fact thash is not used by other parts of the hash library (instead
>> it could be used by softnic for example).
>>
>>  From my point of view, hash library consists of two parts, hash table
>> itself and a number of hash functions. Hash functions, in turn, can be
>> used for many other purposes, not just for a hash table. Maybe we
>> should separate hash functions and hash table? And if you think it is
>> a bad idea, so be it, 4 maintainers for hash is enough.
>
>I don't know.
>It's opening the door for more split of maintainers areas.
>I would like to get more opinions from other maintainers, please.
>

Re: [dpdk-dev] [PATCH v2] maintainers: claim maintainership of Toeplitz hash

[Medvedkin, Vladimir]

Hi Yipeng,

Yes, I agree with you point. So keep me in mind if you decide to split hash table and functions someday :)
Thomas, I think this patch could be rejected.

Thanks! 

-----Original Message-----
From: Wang, Yipeng1 
Sent: Thursday, February 7, 2019 11:14 PM
To: Gobriel, Sameh <sameh.gobriel@intel.com>; Thomas Monjalon <thomas@monjalon.net>; Medvedkin, Vladimir <vladimir.medvedkin@intel.com>
Cc: dev@dpdk.org; Richardson, Bruce <bruce.richardson@intel.com>; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>
Subject: RE: [dpdk-dev] [PATCH v2] maintainers: claim maintainership of Toeplitz hash

Hi Vladimir,

Thanks for stepping up for the maintaining job.

I agree with you that they are two parts and we mixed hash table and hashing function from beginning. They are actually should be two libraries, but at this Stage it is not very necessary to change the situation yet I think.

If you trust us, I will definitely consult with you for questions coming up about thash (also other hash functions like crc and jhash to the corresponding Authors). I will also get more familiar with the code as the maintainer.

Thanks
Yipeng

>-----Original Message-----
>From: Gobriel, Sameh
>Sent: Thursday, February 7, 2019 1:33 PM
>To: Thomas Monjalon <thomas@monjalon.net>; Medvedkin, Vladimir 
><vladimir.medvedkin@intel.com>
>Cc: dev@dpdk.org; Wang, Yipeng1 <yipeng1.wang@intel.com>; Richardson, 
>Bruce <bruce.richardson@intel.com>; De Lara Guarch, Pablo 
><pablo.de.lara.guarch@intel.com>; Yigit, Ferruh 
><ferruh.yigit@intel.com>
>Subject: RE: [dpdk-dev] [PATCH v2] maintainers: claim maintainership of 
>Toeplitz hash
>
>I agree with Thomas. It makes sense to separate out hash function from hash table implementation.
>
>Sameh
>
>-----Original Message-----
>From: Thomas Monjalon [mailto:thomas@monjalon.net]
>Sent: Thursday, February 7, 2019 1:25 PM
>To: Medvedkin, Vladimir <vladimir.medvedkin@intel.com>
>Cc: dev@dpdk.org; Wang, Yipeng1 <yipeng1.wang@intel.com>; Gobriel, 
>Sameh <sameh.gobriel@intel.com>; Richardson, Bruce 
><bruce.richardson@intel.com>; De Lara Guarch, Pablo 
><pablo.de.lara.guarch@intel.com>; Yigit, Ferruh 
><ferruh.yigit@intel.com>
>Subject: Re: [dpdk-dev] [PATCH v2] maintainers: claim maintainership of 
>Toeplitz hash
>
>07/02/2019 20:28, Medvedkin, Vladimir:
>> On 06/02/2019 10:38, Thomas Monjalon wrote:
>> > 05/02/2019 14:57, Vladimir Medvedkin:
>> >> --- a/MAINTAINERS
>> >> +++ b/MAINTAINERS
>> >> +M: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
>> >> +F: lib/librte_hash/rte_thash.h
>> > I'm not sure about adding maintainership for one file.
>> > You are the author of this file, so you should be consulted during 
>> > reviews if you don't catch them by yourself.
>> > But I prefer seeing maintainers as taking charge and understanding 
>> > of a full library as a block.
>> >
>> > And unfortunately, it does not work with the script:
>> > 	devtools/get-maintainer.sh lib/librte_hash/rte_cuckoo_hash.h You 
>> > would appear as maintainer for all hash files.
>>
>> It could be solved by adding header.
>>
>> In fact thash is not used by other parts of the hash library (instead 
>> it could be used by softnic for example).
>>
>>  From my point of view, hash library consists of two parts, hash 
>> table itself and a number of hash functions. Hash functions, in turn, 
>> can be used for many other purposes, not just for a hash table. Maybe 
>> we should separate hash functions and hash table? And if you think it 
>> is a bad idea, so be it, 4 maintainers for hash is enough.
>
>I don't know.
>It's opening the door for more split of maintainers areas.
>I would like to get more opinions from other maintainers, please.
>