From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id A574A5B2C for ; Tue, 16 Oct 2018 14:12:36 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 3930A222CA; Tue, 16 Oct 2018 08:12:36 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 16 Oct 2018 08:12:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=ou3lw9kmXHHC1F5q4fuUqFCFBQRpXET+ZFUi03DzFbk=; b=GbjkbJAqyDMw J69y8RVHxqHAfkO+NhgWg2GrqAKkHGHjfrsls3//8D1chw9HMlPoYhjpAuzW1j7z b5ba0Y3XTNB+cQLPZFPIJbyCpHRJrl5udwclkKaxqXdZLGq7gUjy5zt6c7MPRu3X q5jOV76Q5u7JjreBsGgPEPWUoKMnhrg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=ou3lw9kmXHHC1F5q4fuUqFCFBQRpXET+ZFUi03DzF bk=; b=FboRPtjISbXxJ9mwQmjhJcN8VEkn/HNXBF58SSknyY7DZeypsEv+odEl4 TlkvTjL4xHZd2+kyv+VzfSDMlPpkOq+wFf8km95m2BLRtEqkZ3m7PzjWZ6vYdJbq cYztM8Zj/yK0A3RPX3YbkANlCqwys9N+7anPM8ahjC1+YxYtNmDSHHvHnFuh61ue PsglSrxMgiyDHG26lWEVbQhzG+HqAk6AYgKpZrzkd6EPwB7geDiR10Rf+BgSM0bi CqPqzdInG/2mV2M+6r+MCYidMf2gx9/dDwOc6dNBw0hl9ctJxgsYwuI9VGXcFgNM rN/Q8YH70E/oW4bhEDvB/w6TjVDfA== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 0045EE455F; Tue, 16 Oct 2018 08:12:34 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, gaetan.rivet@6wind.com, ophirmu@mellanox.com, arybchenko@solarflare.com Date: Tue, 16 Oct 2018 14:12:37 +0200 Message-ID: <8663188.1RSN3G5ysp@xps> In-Reply-To: <9a6e10d4-be5e-5da6-c34f-aa3d4e2ed288@intel.com> References: <20181007222554.4886-1-thomas@monjalon.net> <20181009223338.18307-6-thomas@monjalon.net> <9a6e10d4-be5e-5da6-c34f-aa3d4e2ed288@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 5/6] ethdev: remove deprecated attach/detach functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2018 12:12:37 -0000 16/10/2018 13:03, Ferruh Yigit: > On 10/9/2018 11:33 PM, Thomas Monjalon wrote: > > The hotplug attach/detach features are implemented in EAL layer. > > There is a new ethdev iterator to retrieve ports from ethdev layer. > > > > As announced earlier, the (buggy) ethdev functions are now removed. > > > > Signed-off-by: Thomas Monjalon > > Reviewed-by: Andrew Rybchenko > > <...> > > > @@ -53,7 +53,6 @@ Programmer's Guide > > packet_framework > > vhost_lib > > metrics_lib > > - port_hotplug_framework > > Any replacement documentation for hotplug? No. We should improve the documentation about device management in general. I will try to improve it after -rc2. > > +* ethdev: The deprecated functions attach/detach were removed in 18.11. > > + ``rte_eth_dev_attach`` can be replaced by ``RTE_ETH_FOREACH_MATCHING_DEV`` > > + and ``rte_dev_probe`` or ``rte_eal_hotplug_add``. > > + ``rte_eth_dev_detach`` can be replaced by > > + ``rte_dev_remove`` or ``rte_eal_hotplug_remove``. > > What is the difference between ``rte_dev_remove`` or ``rte_eal_hotplug_remove``, > which one is good for which usage, is there any documentation explaining this? In doxygen, you can see that the parameters are differents, and new ones are experimental. That's why we'll keep old ones, at least for this release.