From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AFE98A00C3; Fri, 14 Jan 2022 18:53:51 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 67ACC4277D; Fri, 14 Jan 2022 18:53:51 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id AB4564115A; Fri, 14 Jan 2022 18:53:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642182828; x=1673718828; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=z/CxJHA7F2ytkLlRA8zpCjSEI5Ihwf4s3iK3FRtoNCo=; b=UXJj3dzo5dEO9D+BIuvSawm/0/+JXp1ToHFpN/oPzGfuv1rA2V9hO/17 qZ+T9Etc6KZ18TqD2ImegnNJ0XEqTj2TZDAdDuJN7xQmeZWTSh9+4WMP5 jwESuMR9wfz+i4wZri/ihL/VN5J8/TPR20uDn+U7KALeTmqNwIthhQyAw PIEPDmvN/wrdsWQwEUIPQXPHjnj7kLVn+GtQaenD0HOsX8a//IWnnnE+q yaMDNiknkUhifsOu50XNZBU5d7UjUdries5oK2DI5gIoLBP7ozcmpUR09 hWXOXVd3RbdhdiqR934tiX773H87/cHwIhrnc9DW53OwPTV+ZRJBEk5Xh g==; X-IronPort-AV: E=McAfee;i="6200,9189,10227"; a="244495912" X-IronPort-AV: E=Sophos;i="5.88,289,1635231600"; d="scan'208";a="244495912" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2022 09:53:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,289,1635231600"; d="scan'208";a="475858020" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga006.jf.intel.com with ESMTP; 14 Jan 2022 09:53:39 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 14 Jan 2022 09:53:39 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 14 Jan 2022 09:53:38 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Fri, 14 Jan 2022 09:53:38 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.102) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Fri, 14 Jan 2022 09:53:38 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h3jzQ9CHp+aXpYl9LsSdhj1Y2/+P0rwaM0TpwaPE9vu7o1Rji1U+TWehcWwDOEik3W5fUHSR3bYX/YTiDRZapvc8YP6JV/pK+41lBCEBuo00CeSUEN929S2FpcgCm4kpU8mazLE9QtWYi+TVYr6rxkUmyHyX+Im+zaMCwsPZvJqd9SHXLBhaMakPwOOYlvRIJfe5w90lEch1S1ZNjNpy2B391O4LxFeO1G0ius4/QK80SdfmqKXRTlw8rS2qXkM4PmTj2FWLJ2xuHZnl2wPpbXxmjzUC0gZacI3azWJBCjzWfWInYPE8X+Z9aFdvSfU5KzVcAPSuD4GSr/kRy4XkLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Keim0gs6X/3K27iiLrJIrm3Fb221NMbCluuotJSCqdE=; b=VaU23Giiw8C5dnqKofIuPuRl/j8zULLQFaavGIOstEg+lJZytn533HEKanq6ZBeeSZM4uJUDlQsP9xhfPBMep/cD+tKTkk9QJMnOP5kSDE/tBL6LF/kGKx+6PtatJGYZBKVS8ybBTHE9PKXhwXbE5XmM/jzuyvRK/bwGW6CXLpZH6AGqGZVNlIPusDG1EDkIIXwjxMRNw2KLexp7uFNPktu3faLrxgKsaEPwhVSiH951ZS86k/M0z98/R4eI40ayqpTYqvqXPjcT+maRHyKO0EHVKco0sArp7tjNvBix3I9m0Lv3to3esaY9uGqgV3txjER5jUlSTWhl9gxc+PldpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by CY4PR11MB1383.namprd11.prod.outlook.com (2603:10b6:903:2d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.11; Fri, 14 Jan 2022 17:53:37 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4888.012; Fri, 14 Jan 2022 17:53:36 +0000 Message-ID: <86835695-63a2-7409-2252-94f69271357d@intel.com> Date: Fri, 14 Jan 2022 17:53:30 +0000 Subject: Re: [PATCH] app/testpmd: fix scheduling send burst interval Content-Language: en-US To: Viacheslav Ovsiienko , CC: , , References: <20211123163258.14972-1-viacheslavo@nvidia.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211123163258.14972-1-viacheslavo@nvidia.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0051.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:152::20) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bc68268e-6bb3-43b5-464f-08d9d786ca1a X-MS-TrafficTypeDiagnostic: CY4PR11MB1383:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gWxy+Y9bkDMMkDyWp7Xdcemh2xMtUcAx0c7Rz8WpHBOTePwF9jnAHgwUSXi2YPJ/MRahZZLH6c6CyN0Btn9D2aT9w2EuFC3G+Xv8m/mSpenYCQdFzRWReO3uKP1a9CESp/L4HWPce9X6lGtZR+hfvc6qiLXnyknCicjxZSLRC1eQKNO8XDggMdkdZ42av95nhCdq/lj6pJbaoBr1EAYyqnDujTG/Mh0NUdFzcTABQrtUPi02qJBXEJNrgusVql7hokLvwxYEo1kF3Xo0a7mBtqynwtM0Z7OnNM1P//w+DTz1jtOcsAyrpreDRU/jw6cIUPtqpIlUDvMnfh9QQBRtOLrt1Vyppali4TLi1DY1IqCjg0Jn5HmudCMS7KLRcRO/2ZaDbapZv2iQ4dTffVbluWgdUN9VZ2SAhPtk/slfJmKZl8OfB+WHg8gQ8No3yjEaBbMDlhhoZDWv/CL2znB7TOGxZBbfwfCUomlVEi3QYn3XQceriCNP44ZoYWf19YWkHNYlBoFMh90mxiPNN1jcmZrtBJYw4ufz49RRGb9bGWeERoP5znbu2+oFDjCO2YHVRyugry4nLB1w74SCPrL3MmfAkRHL1c6RKhysENHDZDg/ckUp6Wpkp/w6OoFKBUg+nkJ1LJeoc9Ncaxd7P2e6NgmjuNB/SWsPiZuCRZ7DVyfT6aD6KBQgL2I97Q8BFtlBjdNPjmVGvTeHnOoU00umPg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(2616005)(38100700002)(82960400001)(6512007)(86362001)(31686004)(6506007)(53546011)(4744005)(4326008)(31696002)(36756003)(5660300002)(66556008)(186003)(2906002)(508600001)(316002)(26005)(6666004)(6486002)(8676002)(44832011)(8936002)(66476007)(66946007)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d29kQ3BWdEV2aGR1ZDlyWWJYZzBlRTN6OEZTUUdZTUxiRThCQnVWNUZHZ1ZX?= =?utf-8?B?aDRveUEyRjVQNDVtU092NEZ2TlZ6MEIramx3a1JRYXJOUjEzTWlWQ043UTln?= =?utf-8?B?QXRpSnh0ZjNMVU5HUDNhTW94d05zblFrRnFwWHVqTjF1WWxsR1lGbksySWV1?= =?utf-8?B?RTdnbXJOYk1DaG9pU2p4MEwyK3JYNkhGY1pkemZZRElDUmRaUU9vUVQ5cG05?= =?utf-8?B?MGdxOG5MM3liSXR3dUNuNG1tb0l4RDJ4NWE0Ty81bXFYMk9pUTdGK0JLZkxv?= =?utf-8?B?Z2Z6bUxuSzIwNVBrZjZQT0lNekkyOGlLQkcxLzcyM0FMWndrQlI5SUViQXRw?= =?utf-8?B?dTdnYUN5M2V1Q05HQjlkOS8yU1BjZXRDYSs0dVRKNlBTNEFxOUJoWmc5Tytx?= =?utf-8?B?UzBVWlRCVW9hcVNtS3NHVzdGM0hyVmNpbUk1RUgwUlF1Rmp2eUxadENvN0hZ?= =?utf-8?B?VysvbFp2a0grVlIrZ1BsQk96WnpzRlpqbGZnZC9GSTdtRVVnYUdtYU54QWIw?= =?utf-8?B?VFhGNFBxV2ZVaEVqTFNQaCtYeWdnR1VKaWcxWHNENTZFSWFLdzhMZ2hEZ2di?= =?utf-8?B?RDMvZ0cwam81TzhHNU05RWFIcXlGQWdGZFpBSXlJMVJRZGYreXNWMThtRUJR?= =?utf-8?B?V2thNHR2cHFrejlCcWZKWVR2dHRNWnV4NVdaVVlkNWk3L3BlVlMxQzRzUlU2?= =?utf-8?B?bTBGeFVHUHliL1diNU90NTMvVDcyNDlSR3hVK3lZbnJ6LzVPbTJKc3V2OGpm?= =?utf-8?B?UXpVZDhnY1RnTXRQZktqbVpuVmVRZVJvN2g2VGpqUUV1Y2JLTGJRN2w5SmdN?= =?utf-8?B?MWVqdTlrZUloa1hWeVVaaDduNWpiakt2M2ZFdzVVbHRPMjlyOC93QTFQb2N5?= =?utf-8?B?aEFHSHl1aXUxaGZSSnBsVXdHTjBCMmoyaVQrQzc3WitXbE1kNzhvRkppQWRB?= =?utf-8?B?SllaRU9EQ2Jta0dqMVhOT3YyZ1pzSnVJK1NKR1djUUJxZDFUZjFEUHg3MDBF?= =?utf-8?B?Q00yUEpCSHFxa1pPOXFFcHU3S2xLZWVmTUNNNjhpaVFVSnRGYnV3SW1NL2JM?= =?utf-8?B?Y1JjMGxkUVowNTNEWHBOY01Sdnp6ckVTbHR3TWRqNFYzYVhncUxOQmxlbDZH?= =?utf-8?B?eHJWbXk3SXBQbXVncTluc0pMbVhHd01VK3MzVEk2ZHgrZzdndU1UdVdNMXor?= =?utf-8?B?bytSSFk3cVJBd1E3LzduMU1CYkhFK2hBMmplaUJNdG9neFRGSTlnbEJjUGZs?= =?utf-8?B?TFd2aXF2L2VmTUZFZzVVVmlZTERvT1BIWW1qYjNBdm90V3ZVWVVkNHlIQ0Mv?= =?utf-8?B?VEN2cWdmUHpHV0JpQnlOcERicHc0a3AyYzQrc3NGWTNienJxS1hNUzEwZ0hu?= =?utf-8?B?ZStuZVYyMHlhRnVwZGxGNDc2Vkg4c2VqalUyZjJFUjFWeGU2VEl1bDZVTWR2?= =?utf-8?B?bTZ4Q2dyelZmTDR2RUVOUGtrdWl6VGo5dFhtMzhrZXRmOFJUWFFYc0JDZ1hF?= =?utf-8?B?cy9ndjloNnRTcGl6UXNlQUk0LzEydjUrQkVETyt1NFg0Y0hTa05PZS9UcENz?= =?utf-8?B?UHRSQ0V4Tk5udlhCblgwWnliaXJ4VnpMNDFvQXB3WVRJeGdUM0M0TEZDVVJw?= =?utf-8?B?R29BdUZSNk1kODdldG1DMCtDcnh6QnRjMmZXL2ZNUVUyWko1bXVnRzVRTnNh?= =?utf-8?B?ZTBTaDJ3QnkyUkdENjc4a2ozbzZEMmVvT3E2cVdHR0xxRDdKck1Ca2VORFYr?= =?utf-8?B?SXFMZjRJUFRxaktkYVY0eFN6bldhUmVOMCtrRTViOU1lTVFZOElhMUsxZFhx?= =?utf-8?B?RVRlT1VYY0pFQTFTWUovNllzQ1o0am5DRTRNRm1PSEVtajZaTyswV3k1bmNq?= =?utf-8?B?Y2JtN1Zxc1lxdHFCQjVLcHFDdExzN2ZSYWpDYmN0SG1iRkQrQjNiY1I2U2di?= =?utf-8?B?T2E3dUdXWGdMbG5RaW1qREZWYTZHUXlzYysvNEgrRjRTZXFUdTJrOHpzdGNp?= =?utf-8?B?bkowczRSMmxhYVEvMmFUNjQ5Uk1YUVFWYVp3QVlhSUgyaGdJUFlNQm5qVnFk?= =?utf-8?B?WVJMWnhEYnJKV05EdHFMNkNjUlBpeGVvQUVmenIwSVFQeERLdE9FeDZTeHFG?= =?utf-8?B?QjV5WUF1ejJqakFyZ1ptTXplbEJoMzY0Rmw5TEx2eEN4R1E4dmQ0Z05xczU5?= =?utf-8?Q?I/zhirZBFIkaHD42NK5OXdk=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: bc68268e-6bb3-43b5-464f-08d9d786ca1a X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jan 2022 17:53:36.8769 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EP7FHYp++s23YN9mIPmJ8lZEYKuGP0X275agE8z6HnoQZiQxqGrV7vXhrlPrPMhJQK+F8LBuEXjAIejdBXxDOA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1383 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/23/2021 4:32 PM, Viacheslav Ovsiienko wrote: > The first "set txtimes" command parameter specifies the time > interval between scheduled send bursts for single queue. This > interval should be the same for all the forwarding ports. > It requires to maintain the timing related variables on per > queue basis instead of per core, as currently implemented. > This resulted in wrong burst intervals if two or more cores > were generating the scheduled traffic for two or more ports > in txonly mode. > > This patch moves the timing variable to the fstream structure. > Only txonly forwarding mode with enabled send scheduling is > affected. > > Fixes: 4940344dab1d ("app/testpmd: add Tx scheduling command") > Cc: stable@dpdk.org > > Signed-off-by: Viacheslav Ovsiienko Acked-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.