From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 9374DA0542;
	Mon,  6 Jun 2022 13:45:51 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 3F88D4067E;
	Mon,  6 Jun 2022 13:45:51 +0200 (CEST)
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id AB1064021E
 for <dev@dpdk.org>; Mon,  6 Jun 2022 13:45:49 +0200 (CEST)
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
 by mailout.nyi.internal (Postfix) with ESMTP id 1EBD25C00FD;
 Mon,  6 Jun 2022 07:45:49 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute5.internal (MEProxy); Mon, 06 Jun 2022 07:45:49 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:cc:content-transfer-encoding:content-type:date:date:from:from
 :in-reply-to:in-reply-to:message-id:mime-version:references
 :reply-to:sender:subject:subject:to:to; s=fm2; t=1654515949; x=
 1654602349; bh=n48N65DwBYUJm+jvY68MaWed0YtDdp5g30ZnOJykKDw=; b=s
 gMDOIq8yON9Z4959Ew6DzpTS2WXs26Fl7Smxs49+6YCR+IuQYIhV+V0U2M5byVbv
 +Nkyg3ZU13F97kcq3Cb4P0UR09WlC/E/y/4u5mfWtowGuD8+K/PXBJSBjysnTKZv
 2y7s9Re9Wb75XEkkgszDTKV7nXcMnA7qkzshrqjd3uGBVum11/WIm8DqZTtAZIJw
 23iylF9XbJkttYHxTRbhAntrRWMlTIAzDOnqiZk0KEOL7v16CYG+OPkWSdYqKHsN
 R8OrrAXn6u7qhEm+B2thCrdTiVzEwJQO4IQi7AmsHAPAfN3P3OPJ1Lwc+RpkB/4n
 wOcqnz/ntg87VybreuJeg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-transfer-encoding
 :content-type:date:date:feedback-id:feedback-id:from:from
 :in-reply-to:in-reply-to:message-id:mime-version:references
 :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy
 :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1654515949; x=
 1654602349; bh=n48N65DwBYUJm+jvY68MaWed0YtDdp5g30ZnOJykKDw=; b=t
 tpHZ/YD6BcVMUVbIrJIGu9RjSEn/oEZYbGRVMuqjZPrdO48yUHo4ALvYNVn0kmu+
 Imn9HOasc+7zplkMW5RfCVnNIQGtiaTNZi7xji/ooyX1YW+qxFIaAWocJ4baHMVz
 SqbkieFlKz8dsCu5gBtUGjVqU8DQ2nCie4Oh1v+dN1SCh6y6sW6q82veIOQHbGg1
 WbuynJx4R5TisFcn1nl4gXN7ChMAkj8k/8WeQzs9YrqFy+aq6oetxnZFtNCc+hM8
 RSuIWcE8GwX5jT+xTvtB8OK3kQsyfQQgoviefa79ObA/fW1X/+o53nCOjrWwkL3/
 Z1suo9q/libidAcaYXRBA==
X-ME-Sender: <xms:7OidYq8YG1lSQleuZdQc3Vvnb2ecdKwu9pQtGjQGM_BgpgIxK6jKaQ>
 <xme:7OidYqvYABRW5nLGVqbsEd402TbOA1MlDu82p-IxD-PALxoxHOco043weXeT1n18r
 utDo82nYRNqbOJQMw>
X-ME-Received: <xmr:7OidYgA7CkZvj8DSP9Ilj2LdXZkXLBf0KmTLWnTnhk-B5jYyR5VfRIGULtNJRjCEOHBOYCTCwCRTOB4QwwsDOGg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedruddtvddggeefucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm
 rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc
 ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei
 kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh
 hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght
X-ME-Proxy: <xmx:7OidYieLQKw6stjPGwKsKGfGzPm9ubGXzRd3-bhbXo_bQqx-kUx49A>
 <xmx:7OidYvMNuKq9aF9XaolR5nRLKhXDPIlwUpPADtmP0uRulD1000bPoQ>
 <xmx:7OidYsne0COMOCz-Yc9N2MuUTEvM-Q9-KMr6iWKQyFG2MDA0eo6GwQ>
 <xmx:7eidYor0AEi-ikDGhkUHdhptG_GJoO2omRwJiA6GJ5RlXpBbzY78Xg>
Feedback-ID: i47234305:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon,
 6 Jun 2022 07:45:48 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: "Yang, Qiming" <qiming.yang@intel.com>, "Zhang,
 Qi Z" <qi.z.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Liu, KevinX" <kevinx.liu@intel.com>,
 john.mcnamara@intel.com
Subject: Re: [PATCH v2] net/igc: add I226 support
Date: Mon, 06 Jun 2022 13:45:43 +0200
Message-ID: <8688555.GXAFRqVoOG@thomas>
In-Reply-To: <DM4PR11MB5994F805DA3287FB3A5A9D47D7A29@DM4PR11MB5994.namprd11.prod.outlook.com>
References: <20220519060443.2585871-1-qiming.yang@intel.com>
 <8375134.LvFx2qVVIh@thomas>
 <DM4PR11MB5994F805DA3287FB3A5A9D47D7A29@DM4PR11MB5994.namprd11.prod.outlook.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

06/06/2022 12:54, Zhang, Qi Z:
> 
> > -----Original Message-----
> > From: Thomas Monjalon <thomas@monjalon.net>
> > Sent: Monday, June 6, 2022 6:49 PM
> > To: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> > <qi.z.zhang@intel.com>
> > Cc: dev@dpdk.org; Liu, KevinX <kevinx.liu@intel.com>
> > Subject: Re: [PATCH v2] net/igc: add I226 support
> > 
> > 06/06/2022 01:12, Zhang, Qi Z:
> > >
> > > > -----Original Message-----
> > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > Sent: Monday, June 6, 2022 12:42 AM
> > > > To: Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming
> > > > <qiming.yang@intel.com>
> > > > Cc: dev@dpdk.org; Liu, KevinX <kevinx.liu@intel.com>
> > > > Subject: Re: [PATCH v2] net/igc: add I226 support
> > > >
> > > > 25/05/2022 07:57, Qiming Yang:
> > > > > Added I226 Series device ID in igc driver and updated igc guide
> > > > > document for new devices.
> > > > >
> > > > > Signed-off-by: Qiming Yang <qiming.yang@intel.com>
> > > > > Signed-off-by: Kevin Liu <kevinx.liu@intel.com>
> > > > > ---
> > > > > v2:
> > > > > * rebased
> > > > > ---
> > > > >  doc/guides/nics/igc.rst                | 14 +++++++-------
> > > > >  doc/guides/rel_notes/release_22_03.rst |  5 +++++
> > > >
> > > > You are sending a patch after 22.03 is closed, so it should be listed in
> > 22.07!
> > > >
> > > > I will fix while pulling the tree prepared by Qi.
> > > > Please be more careful with the basic checks.
> > >
> > > Thanks for capture this, have dropped this patch in dpdk-next-net-intel.
> > > A new version is required.
> > 
> > Too late, it is in the main tree with release notes fixed.
> > Do you need more fix?
> 
> OK, I guess we need to revert it with a new fix.
> Sorry for the chaos...

Why revert? If there is a bug, just fix it.