DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@xilinx.com>
To: Dongdong Liu <liudongdong3@huawei.com>, <dev@dpdk.org>,
	<andrew.rybchenko@oktetlabs.ru>, <thomas@monjalon.net>
Cc: <stable@dpdk.org>, Chengwen Feng <fengchengwen@huawei.com>,
	"Min Hu (Connor)" <humin29@huawei.com>,
	Yisen Zhuang <yisen.zhuang@huawei.com>,
	Lijun Ou <oulijun@huawei.com>
Subject: Re: [PATCH V2 2/2] net/hns3: support backplane media type
Date: Wed, 22 Jun 2022 11:06:24 +0100	[thread overview]
Message-ID: <8689c6e8-935b-e2dc-3276-d2970a8bd982@xilinx.com> (raw)
In-Reply-To: <20220622030957.20615-1-liudongdong3@huawei.com>

On 6/22/2022 4:09 AM, Dongdong Liu wrote:
> From: Chengwen Feng <fengchengwen@huawei.com>
> 
> The 802.11 physical PMA sub-layer defines three media: copper, fiber and
> backplane. For PMD, the backplane is similar to the fiber, the main
> differences are that backplane doesn't have optical module.
> 
> Because the interface of firmware fiber is also applicable to the
> backplane, this patch supports the backplane only through simple
> extension.
> 
> Cc: stable@dpdk.org
> 
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> Signed-off-by: Dongdong Liu <liudongdong3@huawei.com>
> ---
> v1->v2:
> - document new 'backplane' media type support in release notes.
> ---
>   doc/guides/rel_notes/release_22_07.rst |  4 ++
>   drivers/net/hns3/hns3_ethdev.c         | 54 ++++++++++++++------------
>   2 files changed, 34 insertions(+), 24 deletions(-)
> 
> diff --git a/doc/guides/rel_notes/release_22_07.rst b/doc/guides/rel_notes/release_22_07.rst
> index dd371952c3..7884ecfd09 100644
> --- a/doc/guides/rel_notes/release_22_07.rst
> +++ b/doc/guides/rel_notes/release_22_07.rst
> @@ -172,6 +172,10 @@ New Features
>   
>     * Added support for yt8531s PHY.
>   
> +* **Updated HiSilicon hns3 driver.**
> +
> +  * Added support for backplane media type.
> +

We are sorting PMD updates on vendor name, so can you please move update 
above Intel updates.

Except above minor release notes location order, patch looks good to me, 
but it requires hns3 maintainers ack/review to proceed. (Same for both 
patches.)

Thanks,
ferruh

  reply	other threads:[~2022-06-22 10:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-11  7:42 [PATCH 0/2] " Dongdong Liu
2022-06-11  7:42 ` [PATCH 1/2] net/hns3: fix fail to obtain VF LSC capability Dongdong Liu
2022-06-24 12:01   ` Ferruh Yigit
2022-06-11  7:42 ` [PATCH 2/2] net/hns3: support backplane media type Dongdong Liu
2022-06-21 12:57   ` Ferruh Yigit
2022-06-22  2:45     ` Dongdong Liu
2022-06-22  3:09   ` [PATCH V2 " Dongdong Liu
2022-06-22 10:06     ` Ferruh Yigit [this message]
2022-06-22 10:29       ` Dongdong Liu
2022-06-22 10:59   ` [PATCH V3 " Dongdong Liu
2022-06-24 12:02     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8689c6e8-935b-e2dc-3276-d2970a8bd982@xilinx.com \
    --to=ferruh.yigit@xilinx.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=fengchengwen@huawei.com \
    --cc=humin29@huawei.com \
    --cc=liudongdong3@huawei.com \
    --cc=oulijun@huawei.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    --cc=yisen.zhuang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).