From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 07951A0547;
Thu, 9 Sep 2021 15:38:18 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id C15D24013F;
Thu, 9 Sep 2021 15:38:17 +0200 (CEST)
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
by mails.dpdk.org (Postfix) with ESMTP id D024340041
for <dev@dpdk.org>; Thu, 9 Sep 2021 15:38:15 +0200 (CEST)
X-IronPort-AV: E=McAfee;i="6200,9189,10101"; a="243100887"
X-IronPort-AV: E=Sophos;i="5.85,280,1624345200"; d="scan'208";a="243100887"
Received: from orsmga005.jf.intel.com ([10.7.209.41])
by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
09 Sep 2021 06:38:14 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.85,280,1624345200"; d="scan'208";a="648918996"
Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83])
by orsmga005.jf.intel.com with ESMTP; 09 Sep 2021 06:38:14 -0700
Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by
fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2242.12; Thu, 9 Sep 2021 06:38:14 -0700
Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by
fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2242.12; Thu, 9 Sep 2021 06:38:14 -0700
Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by
fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2242.12 via Frontend Transport; Thu, 9 Sep 2021 06:38:14 -0700
Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.105)
by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.1.2242.12; Thu, 9 Sep 2021 06:38:13 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=Ta3ffNQtWgVB/higLHbYdbPlHO91v/8CsDCUrZRmyAwsY99Qcqo2SyUvVpljoFjQeWAoXKG24dT1kaUgTA53MXSnMfhRoXElLP2NBWHDau4pSUCTe+Z3wsfttP/3rO+H0vFPePCTNNRuv0IgAMczwH2Kn9Arp6XBgjcxuI9YlHfHtMOZpKQDyMKmSmN+G6VBOeuFCO0XkK2v337LIsvNJjzWqj8iSbtyPR5JopLgCc9y6jL65i++UXHOPNe18NQ6TVtSFPeQTh6+RIjffL255xG1PFQu3U/iahh2PFnSrM2VIjVugQVBiI7PIoxvc2qdsk7nX0JCxu+y7cxrEcUTbw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;
bh=h4MO5UBeWM1b7kev1eSHYu+E9Zp2iNhMBaxOt3L+tOI=;
b=eA6FlzJ0yZ4Ris7o6u4DXd1wf419goKywMrfUIqr1VmxQynW0oOZnnsyoNOjTDREBz1TdP7fsXVlvGXRxpcLhdCgNmUY6qTVIWp2v2jRQRIIvOK4GGza5CCXdEqFORNzTANszOJXq1m9G3XO3yASkesEsz5bxnME9fLiirqueGIx559jJB4fai0Yjw2JQVvY8ccvQHtkz6kUP2WDUpAzyMtyu88T4zFPmoSC2DkmHIruqOTCajmxFYe1CRoIQnVacXI2Ku3GJRcUWhJ6RyYQWNzGyJbZqk8SzPwGrN3envELvx32tjjm7+rkcPIdvYRus/L+WURTwd/NZm4pHXDznQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
dkim=pass header.d=intel.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;
s=selector2-intel-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=h4MO5UBeWM1b7kev1eSHYu+E9Zp2iNhMBaxOt3L+tOI=;
b=QMF8mRe1kI6Sd9FVbxStBUdAuKdFqI7gB84k7KnGi9pjFL/SYZzC6YPs5GcNabkahZMJbBzjqrHikEqm4EFjgoX7b6m55iaA1AePSDZJhGfEJA6MKv7G//TXKA07p/d6+NlRraAhoHCnvCqDMCkp/5crmB84Nf1zda5sl4n0fUM=
Authentication-Results: pantheon.tech; dkim=none (message not signed)
header.d=none;pantheon.tech; dmarc=none action=none header.from=intel.com;
Received: from CO1PR11MB4868.namprd11.prod.outlook.com (2603:10b6:303:90::19)
by MWHPR1101MB2253.namprd11.prod.outlook.com (2603:10b6:301:52::17)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14; Thu, 9 Sep
2021 13:38:10 +0000
Received: from CO1PR11MB4868.namprd11.prod.outlook.com
([fe80::4dcc:489e:1d86:47cb]) by CO1PR11MB4868.namprd11.prod.outlook.com
([fe80::4dcc:489e:1d86:47cb%9]) with mapi id 15.20.4500.017; Thu, 9 Sep 2021
13:38:10 +0000
To: Bruce Richardson <bruce.richardson@intel.com>, <dev@dpdk.org>
CC: <juraj.linkes@pantheon.tech>
References: <20210818134240.480605-1-bruce.richardson@intel.com>
From: "Nicolau, Radu" <radu.nicolau@intel.com>
Message-ID: <86926243-d64d-9c13-492a-5984f29d43ea@intel.com>
Date: Thu, 9 Sep 2021 14:38:05 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
Firefox/78.0 Thunderbird/78.14.0
In-Reply-To: <20210818134240.480605-1-bruce.richardson@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-GB
X-ClientProxiedBy: DU2P251CA0027.EURP251.PROD.OUTLOOK.COM
(2603:10a6:10:230::33) To CO1PR11MB4868.namprd11.prod.outlook.com
(2603:10b6:303:90::19)
MIME-Version: 1.0
Received: from [192.168.1.12] (109.255.186.106) by
DU2P251CA0027.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:230::33) with Microsoft
SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.4500.14 via Frontend Transport; Thu, 9 Sep 2021 13:38:09 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 62e084ad-5c78-462c-dafc-08d973971086
X-MS-TrafficTypeDiagnostic: MWHPR1101MB2253:
X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <MWHPR1101MB2253923D46C06A726764723E90D59@MWHPR1101MB2253.namprd11.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: kBKZJA0gpkBQLk1RN72QL+rrOyTJ8xYPgLSz7MzM4Qmh3D22hA+FpXBakg4e3b3AsiSUUTBS0Q0EK+T4FHM3EVEwb8rNiTHRyK1P0t+LOL1o1DzqNLcIsVcK/wvbp6hpY5Tno1mDCv9aHi0M7rCBSRNxKdvC73y+bUFQQkjIfZehJ/W2qxXxzwiizrQs3hkfVbqH9YDy8LjH+LzuJUFo2v4eMXjoDfO2ySGQeq3v/PeA6JQmCn8Ar9qpcqq703gkk1IE+SYvUKaEYVBgdONsbC254QTVLRncTZUrCfyPReUSLqfTWXPW3D7Wn5o7q94Wm7ERsoGjavADK7q9Bjuu6z4Fv5eUoDpcMVzES5UPrOWwiHT5AJGOoAy+3Rl4Euu86vJgiygSXhiK/kJFuYps3IsREnhqzWldUcRUpyYm9tTddDxjDnCE6xniFmJaDyOz35r79MPXT4+tDlPrpHJroUT3FH+UZBRGV89KDu1QpX28C8RmV3/BD8q1DNAYwvPp20AniWuJHe7ipqfpdYiI38YTWfY32wTI0kXMpopcY4+rY3PmffbWIrImy3OiCAMQObgjpRZdFYgHlLw2HC92/HhwojDDZ7R3L+fHN6/DbVPuXpNCRmLgMM/1Ke1xVXNAWqR3MbBhnRmJo/V+zONTp8pdug+FZPiP+TvZH1HulAtZfW2xjRdg7S+D0XCe85tZrppWbbudZk5/VPml5gHWnGou8grM3i8Gt1ruxP0IVJE=
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:CO1PR11MB4868.namprd11.prod.outlook.com; PTR:; CAT:NONE;
SFS:(4636009)(346002)(376002)(39860400002)(136003)(366004)(396003)(8676002)(2906002)(478600001)(16576012)(86362001)(31696002)(956004)(53546011)(6666004)(8936002)(55236004)(66476007)(31686004)(38100700002)(6486002)(36756003)(316002)(66556008)(26005)(186003)(83380400001)(66946007)(2616005)(4326008)(5660300002)(43740500002)(45980500001);
DIR:OUT; SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SllOSVphOEkyZDdvVEFCUXc0b2piOG94RUlTb2NSbFhlUm1USU9zV2pPaExE?=
=?utf-8?B?bDdJK3hrVEpHMDA1WXBwUDMxMjNNVDU4eC9PNVhnODRqMlhxdTlCdm9qVVk5?=
=?utf-8?B?Nmhjd0ZiM0FjM3M4bEdWTlZ5MTlrQXRTZkhySXp0NWIxVC9MWTB4YWlndHll?=
=?utf-8?B?WlkxdUZZNGRndzg5NExZOVZNUTlCREV2SVhRUUZUdXdkeW9DcUNwR3lrUjJL?=
=?utf-8?B?ZTJpclYzQkFIeDUweHBZOFVJQTlhUjB6WTFLcXMxOTFjbGlIRnNkeEtwd0Z0?=
=?utf-8?B?U1E1djROaGtaM2N2dk5RZzJ3Z084Y2g2aWQ4WWIzSDBLK2J4TFJqaU50QVFY?=
=?utf-8?B?K2toV2VEU3Rsd3ZtcThsYStiMnNaSExoTmxrSlY0aHF1OGRkVS9sRmk5MWhm?=
=?utf-8?B?TFg3eGs5Y1lyN1N4akh0dDFVWEVSaGJoY3pKUGFyY1d6c3hYZEZJa1dFU3Rr?=
=?utf-8?B?UVZoVFN1ZWxhUThkV2R1emJhVVROUEl6VGRXaFdiMUZVdnJiNjZWU1RVcHJl?=
=?utf-8?B?SWp6Zzk5NE1MR3FsYmVmcElCeWVYREtvSkVBL1I1a0FLTW1KVFNnd3dESGNS?=
=?utf-8?B?VjliN2U2U0ZFVFZ5NTJHd1U5MkwraUV5bE9ENFE0UmkzcUY2dHB0d0NPekV4?=
=?utf-8?B?Q0tiVEh3L0cwb1AwV0pCczl5dGRxMFJGWllORkpvckNaM3Fxc0hIUE44TkJt?=
=?utf-8?B?ZWpKWE14anp3SlAwbW5mVWVLQy90Y1VYTkhPcklydFFTdmJLUEJZd0g3MXIv?=
=?utf-8?B?QnFqVmtaajJxS3o5UksrUFRaV1d3Y0pOTHNRQjg4Q2RncUxMSHZBU3VSZGxj?=
=?utf-8?B?OXJBNFFCTWRVcjlhODduUVJFemMzVnZOMFloVW90QW5vYndtNWZMZ0Z5dmRG?=
=?utf-8?B?S3ZtQ1BHaXVCcVU1d0RSVXExZnovbk56azVRcnNZdmxFeWFkMGlmSTJxbHh4?=
=?utf-8?B?OXBaZ2RrM0Nady83ZXBzbm1qdWpPZXJBY09sSC8vRW1nZ203bXc3d2k4VE5a?=
=?utf-8?B?VmY3cmRhNWM1NDdQYk1YMVY3Z2dZQzV4RjNieXhEV0YxUi9QOHZaSmEveENW?=
=?utf-8?B?clRjS3NzWW1yOTNxNUg3QkZiRS9ETXdIWnF4Vk4vbG8wK1VGNG1hdVlIKzly?=
=?utf-8?B?M3lqZkhqVGsyZ0FZQXVvYis4SVBBckpUOG9DQm9UVzU3bkQ2SkF0Tk5KTHZ3?=
=?utf-8?B?YVI0eDZZai91MnNyN1BpaHNKL2c1Wm95ZEh6MzlLQTdaOFE2bVNieWFSUzBJ?=
=?utf-8?B?ZHZYb0FWMms2WmRrL1ZkNTZ3R3k2dHVGWHBOZ3NVZzVGZ0EvTlp1T2RFd1FB?=
=?utf-8?B?TFc1bEp6NzVZNUYvV0s5cDBseFpubmZUSHFXTksxR3FYdmJzVWdMMWFHVFlB?=
=?utf-8?B?ekZ6c0xtQ3NISGNwT3hEZ2JHMUQwcng1WlFSQTkvdDdpN3EyakZlL3k1RGQx?=
=?utf-8?B?Mk9xdWR1UG1XTDlpbHB6ajhEYmYzYndKeXF5Ni9qa2ppS2VLUzNjQWZaZEtC?=
=?utf-8?B?YTlSZVAwNUs4ZUN1WDRNSmRzbTNzNVFKbEE2VVFYZXpvTkMrcE9VRTdlSEl0?=
=?utf-8?B?MFlCQUpJR3hHUmtVS25pb0FaVnNpTStiOEV6VHZnQWtMczVwbWZxWlJ1TVhN?=
=?utf-8?B?OUFNcVJsUWJZQ1JUZmEzY1U5VlJUUjRTcU9zRW1lZGtzNU52dHN2T0FFYk9j?=
=?utf-8?B?YzBLQkpsYXhjWHowTjRqZk5hbVRsQWxrMzYwZzc5bjZMQmgzZHFKLzRtRkQ1?=
=?utf-8?Q?9PDVdXx1/KNB7WDYMj5RI/7EORxSFMmybqCzRRv?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 62e084ad-5c78-462c-dafc-08d973971086
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4868.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2021 13:38:10.5887 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lN9KrlZe+P7Rg+4c7/K+Vv5iV/fpTl9NSFeg095tbBJFW0Jb1RyKbU7muz+mhSmM26hNrdnVf/u7ETJNa9wV5g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2253
X-OriginatorOrg: intel.com
Subject: Re: [dpdk-dev] [PATCH] build: fix building when essential drivers
in disable list
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On 8/18/2021 2:42 PM, Bruce Richardson wrote:
> The PCI and vdev bus drivers cannot be disabled for DPDK builds and
> special logic is put in place to not skip them when they are specified
> in the disable list. This logic is broken though, as the inclusion of
> the driver-specific meson.build file is only included in the "else" leg
> of the condition check. This means that when they are specified as
> disabled the PCI and vdev buses are not disabled, but neither are their
> source files compiled.
>
> Fix this by moving the "subdir()" call into the next "if build" block,
> ensuring that if not disabled the sources are always included. To take
> account of the fact that the subdir call could itself disable the
> driver, we add a break call into the following loop to ensure we quickly
> fall through to the following block which stops processing appropriately
> if the driver is disabled.
>
> Fixes: 2e33309ebe03 ("config: enable/disable drivers in Arm builds")
> Cc: juraj.linkes@pantheon.tech
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
Tested-by: Radu Nicolau <radu.nicolau@intel.com>
Acked-by: Radu Nicolau <radu.nicolau@intel.com>