From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 93291DE5;
 Thu, 26 Jan 2017 12:06:55 +0100 (CET)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by orsmga102.jf.intel.com with ESMTP; 26 Jan 2017 03:06:54 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,288,1477983600"; d="scan'208";a="926855624"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.38])
 ([10.237.220.38])
 by orsmga003.jf.intel.com with ESMTP; 26 Jan 2017 03:06:53 -0800
To: Emmanuel Roullit <emmanuel.roullit@gmail.com>, rahul.lakkireddy@chelsio.com
References: <20170124204859.8998-1-emmanuel.roullit@gmail.com>
 <1d9bd589-e104-314c-ad07-ae98b8f5bda0@intel.com>
Cc: dev@dpdk.org, dpdk stable <stable@dpdk.org>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <86a5a517-ac1e-fd2c-75f7-7f5598170e03@intel.com>
Date: Thu, 26 Jan 2017 11:06:52 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.6.0
MIME-Version: 1.0
In-Reply-To: <1d9bd589-e104-314c-ad07-ae98b8f5bda0@intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 1/3] net/cxgbe: init data value before
 reading seeprom
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Jan 2017 11:06:56 -0000

On 1/25/2017 12:12 PM, Ferruh Yigit wrote:
> On 1/24/2017 8:48 PM, Emmanuel Roullit wrote:
>> data value could have been garbage if VPD access timed out for VPD read
>> request could not been issued.
>>
>> Found with clang static analysis:
>> drivers/net/cxgbe/base/t4_hw.c:1577:22:
>> warning: The left operand of '&' is a garbage value
>>         } while ((stats_reg & 0x1) && --max_poll);
>>                   ~~~~~~~~~ ^
>>
>> Fixes: 17ba077c5c54 ("net/cxgbe: support register dump")
>>
>> Signed-off-by: Emmanuel Roullit <emmanuel.roullit@gmail.com>
> 
> Applied to dpdk-next-net/master, thanks.
> 

Fixes: fe0bd9ee5da3 ("net/cxgbe: support EEPROM access")
Cc: stable@dpdk.org