From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2EEB141B7B; Thu, 12 Oct 2023 14:40:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E48AC4028C; Thu, 12 Oct 2023 14:40:25 +0200 (CEST) Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2085.outbound.protection.outlook.com [40.107.104.85]) by mails.dpdk.org (Postfix) with ESMTP id 4DD304028A for ; Thu, 12 Oct 2023 14:40:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cKgYk1El+snHB8/zrFbPsRZ+FBUi8Rg0FvjDj2aMRGw=; b=ykGRcfBo5HZZ8x/NPQeMYDkn35xQ/MDh0ZbcyY0OyOav+q7grTFlr24aUqTfY243UdJ0kTEOhSeRZQnWbzksruGC7U3habgRgdLLobJDByN58MYJgtk9HD5ozo1+t9fB3Y+LzXkkAwg18gJ3BpLMvYNubCWbXz77XEcal8roLXw= Received: from DU2PR04CA0233.eurprd04.prod.outlook.com (2603:10a6:10:2b1::28) by PA4PR08MB5982.eurprd08.prod.outlook.com (2603:10a6:102:eb::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.43; Thu, 12 Oct 2023 12:40:22 +0000 Received: from DBAEUR03FT018.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b1:cafe::aa) by DU2PR04CA0233.outlook.office365.com (2603:10a6:10:2b1::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.29 via Frontend Transport; Thu, 12 Oct 2023 12:40:21 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT018.mail.protection.outlook.com (100.127.142.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.30 via Frontend Transport; Thu, 12 Oct 2023 12:40:21 +0000 Received: ("Tessian outbound ab4fc72d2cd4:v211"); Thu, 12 Oct 2023 12:40:21 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: df86fa80dd06c436 X-CR-MTA-TID: 64aa7808 Received: from b96c6680dbec.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4A764582-0769-49CC-9811-FAEF27929EEA.1; Thu, 12 Oct 2023 12:40:15 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b96c6680dbec.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 12 Oct 2023 12:40:15 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F8oxidUaE2AMJMCOfwa9ysHyaTGrZlEYaf4D831JOq3zsQue1eQgarHlHImsg1JCWKZafPasRmGmJ47h9vYq2pF4oSGWeqW5VvoXlvqANtU6BVsjm5SqRRqOm+Xz9u+XQhyiuWkG0F0Fjqw9pb0S3fJiXNHzo795J5V9b6z4ouTjEP5NKtWee2nK546g2zqnujyzmWWeOcaMcfiOkbIi8NoL0eJuu0B6nadLC4gb2WHUzg+FN50t+z1lqEUMcsJLtwK/Gu6itgXIqtNjLOjTRanuJLalO5KDr/l4vLBn9ob+nl1n+diVBj0ZIWArZ6jzc1dzplidoGbn2qdl7GWgoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cKgYk1El+snHB8/zrFbPsRZ+FBUi8Rg0FvjDj2aMRGw=; b=MyMFdMYl3LPF5aZR4GMC5CVBxPz26UIPU7Y+ZjM39FvxNtlxwb3JeN3YAxh17HKcsAXC+tn0CzXDJdmi6D+jypwqWrdPc03c2EuqbNUAVritq1ahEuBcxNxk0DBmbHhLfRyzqExw0yETRGcH0VMyGuZxAlvl0wi+1ryWMX+sqeeu0pMsJAOsYnDRo8nhimfal+Wy1gTXImzu9Fhn3+pLkwA1BxehMwVg6/eL2D6YpW217MXB9RfB3pO44Ja3mqF9rKq13AtMAgFb83kDW+7x2AoiBRfbbLeH/jtINT/APtzsUFWk85tiCldkNtBmusrYmlU3a1YcromPTWB2mP13iA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cKgYk1El+snHB8/zrFbPsRZ+FBUi8Rg0FvjDj2aMRGw=; b=ykGRcfBo5HZZ8x/NPQeMYDkn35xQ/MDh0ZbcyY0OyOav+q7grTFlr24aUqTfY243UdJ0kTEOhSeRZQnWbzksruGC7U3habgRgdLLobJDByN58MYJgtk9HD5ozo1+t9fB3Y+LzXkkAwg18gJ3BpLMvYNubCWbXz77XEcal8roLXw= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DB4PR08MB8151.eurprd08.prod.outlook.com (2603:10a6:10:381::16) by DBBPR08MB6233.eurprd08.prod.outlook.com (2603:10a6:10:204::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.45; Thu, 12 Oct 2023 12:40:14 +0000 Received: from DB4PR08MB8151.eurprd08.prod.outlook.com ([fe80::7e:f225:af56:ae16]) by DB4PR08MB8151.eurprd08.prod.outlook.com ([fe80::7e:f225:af56:ae16%5]) with mapi id 15.20.6863.032; Thu, 12 Oct 2023 12:40:13 +0000 Message-ID: <86c226a6-d187-4f72-aa5c-7dc1c06e7586@arm.com> Date: Thu, 12 Oct 2023 13:40:11 +0100 User-Agent: Mozilla Thunderbird Cc: nd@arm.com, dev@dpdk.org Subject: Re: [PATCH v2] config/arm: update aarch32 build with gcc13 Content-Language: en-US To: =?UTF-8?Q?Juraj_Linke=C5=A1?= , thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, bruce.richardson@intel.com, Ruifeng.Wang@arm.com References: <20230921095916.344076-1-juraj.linkes@pantheon.tech> <20231009095325.86444-1-juraj.linkes@pantheon.tech> From: Paul Szczepanek In-Reply-To: <20231009095325.86444-1-juraj.linkes@pantheon.tech> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0098.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:191::13) To DB4PR08MB8151.eurprd08.prod.outlook.com (2603:10a6:10:381::16) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DB4PR08MB8151:EE_|DBBPR08MB6233:EE_|DBAEUR03FT018:EE_|PA4PR08MB5982:EE_ X-MS-Office365-Filtering-Correlation-Id: ac0ce76b-1aea-4477-0f69-08dbcb206646 X-LD-Processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: xli7s/aB7PrB6idX8CU4xRYsHRMcqbaoLL+OjiwlC8esUp47FO+WQrPSe82XHAixmV29qZm7BVpmzRdpDHIxBealY7upEBbDNSZsz2sbA8/aENcypEDo5EOrU6Sx+Bwx9e/x2Iy59ZVAKUopwEKXxxvfiGR7krRrNzDLdWvspcXieISsJ3daMxiM9PduqZF/KhPeFwTACmeJIjaYc0RPg1Vme/PDbBAYHRQ3DGz+suC5MSehVAlgw3vmqAp9I2/61W/+VCn5jyOr1Ue390qvNVUag89bGAxAWfmx4Y2ta+caB+iGIBSgPfKq0nHn20VipI7d/dBOlfo/24GuuA929aTVtxsCQk0vX51JgmEyZKtL19GGmXU9hXYHr166dDyWwvHsNdldOVy20GOmUgJ5serFUgrX6NspVgZ+DRhz2PfGSCY+Gp84fUXpZuRczZWvIVetHWIz+j+7VgIJkY7vJJ9drKYG780mnKZXnacWwHx/BbXvx5KgnO8ch33U3PFnYS3Gg787EKzA+hmIRH6gy2s4KWBrTFWn/FqDYTbnNxDgN86QHQD3/FMDZqkU4nwT+xWw/Siy8wfDCYvLYq4xMcgwYuLrJ7Qcz3U1iDxTrNk1LMQwg7+2yKjZrk3dd0XwIxNeSTzdYyqsUzIjRp8x6g== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB4PR08MB8151.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(366004)(396003)(346002)(136003)(376002)(230922051799003)(64100799003)(1800799009)(186009)(451199024)(6512007)(53546011)(2616005)(6506007)(478600001)(6486002)(26005)(2906002)(15650500001)(83380400001)(44832011)(4326008)(41300700001)(5660300002)(66476007)(66556008)(66946007)(6636002)(8676002)(8936002)(316002)(38100700002)(36756003)(86362001)(31696002)(31686004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6233 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 337845a6-0cbe-429d-5b73-08dbcb206177 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: f4d4Cs/I1G4BZuNW/FGR91cPr97A97oUrAI+HCN9jYUQW9cgkweDcLvkreulJRPzwZefc/xL1IqjFx5s/y/59q/dWjQfflwRDIBiAwm858AJd4tJLNQiAkvL62iXaMT0g8hwbtbosyoDmCdD83mLzK3EzXkGHwxl3jr65c7OcgJOTn5gBukKDiAqnaLi2Y6+yn32It9pZGHcuhn3/isF4S1vKgRvfZ6NDHVwkdOKl44/6fhNDhm4a1jKAYELwxlAZK82be/eV4z0UFiHKz0ZMvQ22tvAJogdCVBlozdD9VSSyoWG8yv+R0edpEsnd4ufFNHSJxTiAg4Sqb/kp0x8Bc65k+mKfbTt4tL3bemrEABgjRtjewCorHmlm9B2t1I/++ZR2uLrYTLnfRqepIMoq4usYMXjW6G31lrKECdGx8ADPHfy2SY/6QxZy0q8EbalRFirfKV9OO+3jBRnWGjgfesQw+zRsdMj7NnaZuWZyasodVxJDweZIX4ajisYL3fulQFp3Or0dnRx9QlXGUDIy++MZ3FhHrO1laYuqFaj06oOUOIAOOEDSMt6SMZWpwFYfkigMZWhv7pBGYZTGz8CiHouzqDzg7uUxSdMUBwDPtCZjru2xAhL2/X4sm4FWvG7AG3iaVRfNmRpMyUmqDIwEsRnoqsy9DvTRaski0ZV5n0z/nGa4namodoRxccVrSbZHzAVqb34ZhaM/5DBPFk2TTVbjfqkIvaylI27aMEyzAueDiT7Thjdc4KFiN3rkrVP1yzQQs01FFrbdZgOe9dc8g== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230031)(4636009)(376002)(39860400002)(346002)(396003)(136003)(230922051799003)(64100799003)(186009)(1800799009)(82310400011)(451199024)(40470700004)(46966006)(36840700001)(83380400001)(53546011)(6506007)(6512007)(6486002)(478600001)(2616005)(26005)(36756003)(15650500001)(2906002)(336012)(316002)(70586007)(5660300002)(8936002)(4326008)(6636002)(44832011)(70206006)(8676002)(41300700001)(36860700001)(82740400003)(31696002)(86362001)(356005)(81166007)(47076005)(40460700003)(40480700001)(31686004)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2023 12:40:21.8004 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ac0ce76b-1aea-4477-0f69-08dbcb206646 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB5982 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 09/10/2023 10:53, Juraj Linkeš wrote: > The aarch32 with gcc13 fails with: > > Compiler for C supports arguments -march=armv8-a: NO > > ../config/arm/meson.build:714:12: ERROR: Problem encountered: No > suitable armv8 march version found. > > This is because we test -march=armv8-a alone (without the -mpfu option), > which is no longer supported in gcc13 aarch32 builds. > > The most recent recommendation from the compiler team is to build with > -march=armv8-a+simd -mfpu=auto, which should work for compilers old and > new. The suggestion is to first check -march=armv8-a+simd and only then > check -mfpu=auto. > > To address this, add a way to force the architecture (the value of > the -march option). > > Signed-off-by: Juraj Linkeš > Acked-by: Ruifeng Wang > --- > config/arm/meson.build | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/config/arm/meson.build b/config/arm/meson.build > index 3f22d8a2fc..5303d0e969 100644 > --- a/config/arm/meson.build > +++ b/config/arm/meson.build > @@ -43,7 +43,9 @@ implementer_generic = { > }, > 'generic_aarch32': { > 'march': 'armv8-a', > - 'compiler_options': ['-mfpu=neon'], > + 'force_march': true, > + 'march_features': ['simd'], > + 'compiler_options': ['-mfpu=auto'], > 'flags': [ > ['RTE_ARCH_ARM_NEON_MEMCPY', false], > ['RTE_ARCH_STRICT_ALIGN', true], > @@ -711,7 +713,11 @@ if update_flags > endif > endforeach > if candidate_march == '' > - error('No suitable armv8 march version found.') > + if part_number_config.get('force_march', false) > + candidate_march = part_number_config['march'] > + else > + error('No suitable armv8 march version found.') > + endif This section is only used when no candidate is found, this would make it not really be a forced arch but more a fallback arch. If we want the user to be able to really force the march string we'd need to put the "is forced?" check higher. Am I reading the code right? > endif > if candidate_march != part_number_config['march'] > warning('Configuration march version is ' + > @@ -741,7 +747,7 @@ if update_flags > # apply supported compiler options > if part_number_config.has_key('compiler_options') > foreach flag: part_number_config['compiler_options'] > - if cc.has_argument(flag) > + if cc.has_multi_arguments(machine_args + [flag]) > machine_args += flag > else > warning('Configuration compiler option ' +