From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6A994459B2; Mon, 16 Sep 2024 18:06:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DDDB74025F; Mon, 16 Sep 2024 18:06:53 +0200 (CEST) Received: from smtp-fw-80008.amazon.com (smtp-fw-80008.amazon.com [99.78.197.219]) by mails.dpdk.org (Postfix) with ESMTP id 1D67140150 for ; Mon, 16 Sep 2024 18:06:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1726502812; x=1758038812; h=from:to:cc:date:message-id:references:in-reply-to: mime-version:subject; bh=LeBd8V5HKxh2aQ6IZ8MWCDVHl7cGF0Smqr2fsBRGkoE=; b=c6ZaWrIK3jksN+2a9ZOoz8l5fJvTFpCv6ENvMg0NyHDjaj8gvw6XMEwA IUw+bbMpeArTYcLrb4nzSSVN1ZIMXSoNlqVDDXZ2ScRgqRvN1jmMDXXyC VxtKJMHp/m4Uohq6i0jDdle8RQQ8UmGK8JD7e5vU35CYSjpOOuplzC2qD Q=; X-IronPort-AV: E=Sophos;i="6.10,233,1719878400"; d="scan'208,217";a="126696064" Subject: RE: [PATCH] net/ena: revert redefining memcpy Thread-Topic: [PATCH] net/ena: revert redefining memcpy Received: from pdx4-co-svc-p1-lb2-vlan3.amazon.com (HELO smtpout.prod.us-west-2.prod.farcaster.email.amazon.dev) ([10.25.36.214]) by smtp-border-fw-80008.pdx80.corp.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Sep 2024 16:06:49 +0000 Received: from EX19MTAEUB001.ant.amazon.com [10.0.10.100:31320] by smtpin.naws.eu-west-1.prod.farcaster.email.amazon.dev [10.0.3.169:2525] with esmtp (Farcaster) id 1fab2605-97f8-4f72-9728-b4055b2e3c1b; Mon, 16 Sep 2024 16:06:48 +0000 (UTC) X-Farcaster-Flow-ID: 1fab2605-97f8-4f72-9728-b4055b2e3c1b Received: from EX19D023EUA002.ant.amazon.com (10.252.50.51) by EX19MTAEUB001.ant.amazon.com (10.252.51.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1258.34; Mon, 16 Sep 2024 16:06:48 +0000 Received: from EX19D007EUA002.ant.amazon.com (10.252.50.68) by EX19D023EUA002.ant.amazon.com (10.252.50.51) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1258.34; Mon, 16 Sep 2024 16:06:48 +0000 Received: from EX19D007EUA002.ant.amazon.com ([fe80::1295:20d9:141e:47cc]) by EX19D007EUA002.ant.amazon.com ([fe80::1295:20d9:141e:47cc%3]) with mapi id 15.02.1258.035; Mon, 16 Sep 2024 16:06:48 +0000 From: "Brandes, Shai" To: Stephen Hemminger CC: Ferruh Yigit , Tyler Retzlaff , "dev@dpdk.org" , "Schmeilin, Evgeny" , "Beider, Ron" , "Bernstein, Amit" , "Atrash, Wajeeh" Thread-Index: AQHa7M0iYRaHALrd40mXBEka6Fs4C7JTyzCAgAA0OgCABirjkIAAkY8AgAAPZ/U= Date: Mon, 16 Sep 2024 16:06:48 +0000 Message-ID: <86ca03bb-70bc-49a8-822b-45588f642914@email.android.com> References: <200~bug-1510-3@http.bugs.dpdk.org> <20240812153417.65225-1-stephen@networkplumber.org> <20240912051243.GC6879@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <16f62350-896e-458c-bbb9-0ef3453883c2@amd.com> <7f545f9575b444e5b31be18f033a940e@amazon.com>, <20240916081140.58c052ab@hermes.local> In-Reply-To: <20240916081140.58c052ab@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Content-Type: multipart/alternative; boundary="_000_86ca03bb70bc49a8822b45588f642914emailandroidcom_" MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --_000_86ca03bb70bc49a8822b45588f642914emailandroidcom_ Content-Type: text/plain; charset="windows-1255" Content-Transfer-Encoding: quoted-printable Thanks for the clarification. We are okay to move forward with the revert. =E1=FA=E0=F8=E9=EA 16 =E1=F1=F4=E8=D7 2024 18:12,=FE Stephen Hemminger =EB=FA=E1: CAUTION: This email originated from outside of the organization. Do not cli= ck links or open attachments unless you can confirm the sender and know the= content is safe. On Mon, 16 Sep 2024 06:33:26 +0000 "Brandes, Shai" wrote: > > Did you have any chance to check/test this patch? > [Brandes, Shai] We are currently conducting tests and will provide an upd= ate shortly. In the meantime, could you advise whether it is recommended to= entirely avoid using rte_memcpy in our driver, considering we have direct = calls to it? There is a long term goal to remove rte_memcpy(). It exists only as workaro= und for cases where older compilers do not produce optimium code. When rte_memcpy() is used the checks done by fortify, gcc, coverity etc are less and there is higher probability of bugs going undetected. My current recommendation is to only use rte_memcpy() in the data path and = for variable size data items. --_000_86ca03bb70bc49a8822b45588f642914emailandroidcom_ Content-Type: text/html; charset="windows-1255" Content-Transfer-Encoding: quoted-printable
Thanks for the clarification.
We are okay to move forward with the revert.

=E1=FA=E0=F8=E9=EA 16 =E1=F1=F4=E8=D7 2024 18:= 12,=FE Stephen Hemminger <stephen@networkplumber.org> =EB=FA=E1:
CAUTION: This email originated from outside of the= organization. Do not click links or open attachments unless you can confir= m the sender and know the content is safe.



On Mon, 16 Sep 2024 06:33:26 +0000
"Brandes, Shai" <shaibran@amazon.com> wrote:

> > Did you have any chance to check/test this patch?
> [Brandes, Shai] We are currently conducting tests and will provide an = update shortly. In the meantime, could you advise whether it is recommended= to entirely avoid using rte_memcpy in our driver, considering we have dire= ct calls to it?

There is a long term goal to remove rte_memcpy(). It exists only as workaro= und for
cases where older compilers do not produce optimium code.

When rte_memcpy() is used the checks done by fortify, gcc, coverity etc are=
less and there is higher probability of bugs going undetected.

My current recommendation is to only use rte_memcpy() in the data path and = for
variable size data items.
 --_000_86ca03bb70bc49a8822b45588f642914emailandroidcom_--