From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 1996C10D04 for ; Thu, 22 Dec 2016 11:44:34 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP; 22 Dec 2016 02:44:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,387,1477983600"; d="scan'208";a="915127362" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.29]) ([10.237.220.29]) by orsmga003.jf.intel.com with ESMTP; 22 Dec 2016 02:44:32 -0800 To: "Zhao1, Wei" , "dev@dpdk.org" References: <1480675394-59179-1-git-send-email-wei.zhao1@intel.com> <1480675394-59179-16-git-send-email-wei.zhao1@intel.com> Cc: "Lu, Wenzhuo" , Adrien Mazarguil From: Ferruh Yigit Message-ID: <86cc3f7c-4488-9efa-48ce-82eb57ae572c@intel.com> Date: Thu, 22 Dec 2016 10:44:32 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 15/18] net/ixgbe: parse flow director filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Dec 2016 10:44:35 -0000 On 12/22/2016 9:19 AM, Zhao1, Wei wrote: > Hi, Yigit > >> -----Original Message----- >> From: Yigit, Ferruh >> Sent: Wednesday, December 21, 2016 1:01 AM >> To: Zhao1, Wei ; dev@dpdk.org >> Cc: Lu, Wenzhuo >> Subject: Re: [dpdk-dev] [PATCH 15/18] net/ixgbe: parse flow director filter >> >> On 12/2/2016 10:43 AM, Wei Zhao wrote: >>> From: wei zhao1 >>> >>> check if the rule is a flow director rule, and get the flow director info. >>> >>> Signed-off-by: wei zhao1 >>> Signed-off-by: Wenzhuo Lu >>> --- >> >> <...> >> >>> + PATTERN_SKIP_VOID(rule, struct ixgbe_fdir_rule, >>> + RTE_FLOW_ERROR_TYPE_ITEM_NUM); >>> + if (item->type != RTE_FLOW_ITEM_TYPE_ETH && >>> + item->type != RTE_FLOW_ITEM_TYPE_IPV4 && >>> + item->type != RTE_FLOW_ITEM_TYPE_IPV6 && >>> + item->type != RTE_FLOW_ITEM_TYPE_UDP && >>> + item->type != RTE_FLOW_ITEM_TYPE_VXLAN && >>> + item->type != RTE_FLOW_ITEM_TYPE_NVGRE) { >> >> This gives build error [1], there are a few more same usage: >> >> .../drivers/net/ixgbe/ixgbe_ethdev.c:9238:17: error: comparison of constant >> 241 with expression of type 'const enum rte_flow_item_type' is always true >> [-Werror,-Wtautological-constant-out-of-range-compare] >> item->type != RTE_FLOW_ITEM_TYPE_NVGRE) { >> >> >> > > Ok, I will add two type definition RTE_FLOW_ITEM_TYPE_NVGRE and RTE_FLOW_ITEM_TYPE_E_TAG into const enum rte_flow_item_type to eliminate this problem. > Thank you. > CC: Adrien Mazarguil Yes, that is what right thing to do, since rte_flow patchset not merged yet, perhaps Adrien may want to include this as next version of his patchset? What do you think Adrien? Thanks, ferruh