From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 7E0161B6EC for ; Tue, 24 Oct 2017 00:33:09 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Oct 2017 15:33:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,424,1503385200"; d="scan'208";a="1234327308" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.136]) ([10.241.225.136]) by fmsmga002.fm.intel.com with ESMTP; 23 Oct 2017 15:32:53 -0700 To: aviadye@dev.mellanox.co.il, dev@dpdk.org, sergio.gonzalez.monroy@intel.com, pablo.de.lara.guarch@intel.com, aviadye@mellanox.com Cc: borisp@mellanox.com, akhil.goyal@nxp.com, hemant.agrawal@nxp.com, radu.nicolau@intel.com, declan.doherty@intel.com, liranl@mellanox.com, nelio.laranjeiro@6wind.com, thomas@monjalon.net References: <1508439233-17981-1-git-send-email-aviadye@dev.mellanox.co.il> From: Ferruh Yigit Message-ID: <86d682d7-b0e7-0f02-7260-e2aca3396704@intel.com> Date: Mon, 23 Oct 2017 15:32:52 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1508439233-17981-1-git-send-email-aviadye@dev.mellanox.co.il> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] app/testpmd: compile even if ixgbe anf bnxt pmds are not compiling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Oct 2017 22:33:09 -0000 On 10/19/2017 11:53 AM, aviadye@dev.mellanox.co.il wrote: > From: Aviad Yehezkel Hi Aviad, What do you think using RTE_SET_USED() as done in other samples, we know those variables may not be used if PMDs are not defined, no need to make code more complex. Like: --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -7504,6 +7504,9 @@ cmd_set_vf_rxmode_parsed(void *parsed_result, ret = rte_pmd_bnxt_set_vf_rxmode(res->port_id, res->vf_id, rx_mode, (uint8_t)is_on); #endif + + RTE_SET_USED(is_on); + if (ret < 0) printf("bad VF receive mode parameter, return code = %d \n", ret); --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -3197,6 +3197,10 @@ set_vf_rate_limit(portid_t port_id, uint16_t vf, uint16_t rate, uint64_t q_msk) if (diag == 0) return diag; + RTE_SET_USED(vf); + RTE_SET_USED(rate); + RTE_SET_USED(q_msk); + printf("set_vf_rate_limit for port_id=%d failed diag=%d\n", port_id, diag); return diag; > > Signed-off-by: Aviad Yehezkel > Signed-off-by: Nicolai Radu <...>