From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 76920A00C5; Thu, 15 Sep 2022 12:32:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5DE8B4021F; Thu, 15 Sep 2022 12:32:01 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id A9DF84021D for ; Thu, 15 Sep 2022 12:31:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663237919; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2KTiNMNzgnMu1ljLnO0UHdMJ1w4CU/sEqLl8twDKEcI=; b=icIpxkE5e1zcaRZGDhiq+gXKJYh9nHmerf0j/uNIrScnHbRalbCLnByH1j66Yyqw/FKeei 4XO2ZaH0ySYj3xq3Islj85E2VzGI/BeSA6drSKnYdhNmKd/gE0zBMYDNLREMxosr6xt+KG YVvHr7fwQpj//pievhBT/47DNSSSl4s= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-204-e3ZBWK41M8argf5gwzSGZg-1; Thu, 15 Sep 2022 06:31:56 -0400 X-MC-Unique: e3ZBWK41M8argf5gwzSGZg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DE7C786EB2D; Thu, 15 Sep 2022 10:31:55 +0000 (UTC) Received: from [10.39.208.12] (unknown [10.39.208.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A4AAB18EB5; Thu, 15 Sep 2022 10:31:54 +0000 (UTC) Message-ID: <86ecbc97-a280-903d-7ccb-62f3843c1f98@redhat.com> Date: Thu, 15 Sep 2022 12:31:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 To: Hernan Vargas , dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com References: <20220820023157.189047-1-hernan.vargas@intel.com> <20220820023157.189047-35-hernan.vargas@intel.com> From: Maxime Coquelin Subject: Re: [PATCH v2 34/37] baseband/acc100: update meson file sdk dependency In-Reply-To: <20220820023157.189047-35-hernan.vargas@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 8/20/22 04:31, Hernan Vargas wrote: > Update meson files with FlexRAN SDK dependency. > > Signed-off-by: Hernan Vargas > --- > drivers/baseband/acc100/meson.build | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/drivers/baseband/acc100/meson.build b/drivers/baseband/acc100/meson.build > index 9a1a3b8b07..3b934a25ca 100644 > --- a/drivers/baseband/acc100/meson.build > +++ b/drivers/baseband/acc100/meson.build > @@ -1,6 +1,27 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2020 Intel Corporation > > +# check for FlexRAN SDK libraries > +dep_dec5g = dependency('flexran_sdk_ldpc_decoder_5gnr', required: false) > + > +if dep_dec5g.found() > + ext_deps += cc.find_library('libstdc++', required: true) > + ext_deps += cc.find_library('libirc', required: true) > + ext_deps += cc.find_library('libimf', required: true) > + ext_deps += cc.find_library('libipps', required: true) > + ext_deps += cc.find_library('libsvml', required: true) > + ext_deps += dep_dec5g > + ext_deps += dependency('flexran_sdk_ldpc_encoder_5gnr', required: true) > + ext_deps += dependency('flexran_sdk_LDPC_ratematch_5gnr', required: true) > + ext_deps += dependency('flexran_sdk_rate_dematching_5gnr', required: true) > + ext_deps += dependency('flexran_sdk_turbo', required: true) > + ext_deps += dependency('flexran_sdk_crc', required: true) > + ext_deps += dependency('flexran_sdk_rate_matching', required: true) > + ext_deps += dependency('flexran_sdk_common', required: true) > + cflags += ['-DRTE_BBDEV_SDK_AVX2'] > + cflags += ['-DRTE_BBDEV_SDK_AVX512'] > +endif > + > deps += ['bbdev', 'bus_vdev', 'ring', 'pci', 'bus_pci'] > > sources = files('rte_acc100_pmd.c') I think we should improve build coverage with stubs. For example, we could stub bblib_rate_dematching_5gnr(), and so all the code under RTE_BBDEV_SDK_AVX512 ifdef in enqueue_ldpc_dec_one_op_cb() would be built. It would even open the possibility to have open-source implementations of these libraries if community feel the need. What do you think? Thanks, Maxime