From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F21F9A0524; Thu, 7 Jan 2021 15:27:36 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 769D8140F98; Thu, 7 Jan 2021 15:27:36 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mails.dpdk.org (Postfix) with ESMTP id A8C33140F97 for <dev@dpdk.org>; Thu, 7 Jan 2021 15:27:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610029655; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4SOtmkqzqxO78D03B9MxQlV67+fNedgKBMXUZww59VY=; b=OSFR+2iTrN03s6zKQlSakNSKOCAksAKCSh0z+tKZTYYBMqmPYdw/f2u1g9IlP1PLX4GJMy xojb6QrUFhp/PxZsXTcZm6+YOB9cZvJApumT0tSsclBSnsSS5s3s8dJNrE9A3ALat8xVhC iS/IrA6jW0/kJdIKtkcZs5F/o3BTPx0= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-276-lST1Ufr6P7-sPUk1Gz-5pw-1; Thu, 07 Jan 2021 09:27:32 -0500 X-MC-Unique: lST1Ufr6P7-sPUk1Gz-5pw-1 Received: by mail-wm1-f71.google.com with SMTP id l5so813631wmi.4 for <dev@dpdk.org>; Thu, 07 Jan 2021 06:27:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:organization:references:date :in-reply-to:message-id:user-agent:mime-version; bh=4SOtmkqzqxO78D03B9MxQlV67+fNedgKBMXUZww59VY=; b=nhCJGwiixgS+QcdZpMKVCD1NCw7WKpCH3qyIsqlSO827QR3df2q08xn2kNgCP/93JP 8UNFnLYll0LAe5NQZHzoQ+vpmC5ZJ5pJVFgTTpiTV2G0teouNtmhV5KIfxmZPB8bbY/S dg077v8MmJ+zcCv8jtuJSuOWy6s4JkeVxvPixOejJFFn/EXbKHDS04Af6LQSQwWvsVNI +E1ZHfz5J4JSgAJRFjtWr1KFBOUu8ltNxM6seix3UZMv2/w4UvKfRPAg0r8Dpnd9lXeZ ZP71zthABm9mwCpWdDxeIxW+qEXZyfzUE96XL8xZGrEv0Tt+gtQT3VqwrZ5F5bmiDQGG uTYQ== X-Gm-Message-State: AOAM530covu1+c4OYfOKznyo7vZehKXEbMf/eMhSXvYDhG8Da58pz1Ck bzts6fW9yzbiT2C+k4KZej5HRZvchJpricLxLUc8IetnAFXXekn/RjWnQWTT5YCaBgMS+nHXMQs f8RM6dbXSsN4XgUVlzjy9iSAL0i65HIzM/LwOnxl2mmUkt0syTyc= X-Received: by 2002:adf:97ce:: with SMTP id t14mr9360332wrb.368.1610029651017; Thu, 07 Jan 2021 06:27:31 -0800 (PST) X-Google-Smtp-Source: ABdhPJxKm5pRR6GrSwMry6ndZYO/w62vDxemraRJrot943SOfmf/I3T8hq4QwIEPlPw2P7RF454gKg== X-Received: by 2002:adf:97ce:: with SMTP id t14mr9360296wrb.368.1610029650711; Thu, 07 Jan 2021 06:27:30 -0800 (PST) Received: from localhost (91-166-131-65.subs.proxad.net. [91.166.131.65]) by smtp.gmail.com with ESMTPSA id j15sm8480687wrr.85.2021.01.07.06.27.29 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Jan 2021 06:27:30 -0800 (PST) Received: by localhost (Postfix, from userid 1001) id D25711A0F9A; Thu, 7 Jan 2021 15:27:28 +0100 (CET) From: Dodji Seketeli <dodji@redhat.com> To: David Marchand <david.marchand@redhat.com> Cc: Thomas Monjalon <thomas@monjalon.net>, "Guo\, Jia" <jia.guo@intel.com>, "Zhang\, Qi Z" <qi.z.zhang@intel.com>, "Wu\, Jingjing" <jingjing.wu@intel.com>, "Yang\, Qiming" <qiming.yang@intel.com>, "Wang\, Haiyue" <haiyue.wang@intel.com>, "dev\@dpdk.org" <dev@dpdk.org>, "Yigit\, Ferruh" <ferruh.yigit@intel.com>, "andrew.rybchenko\@oktetlabs.ru" <andrew.rybchenko@oktetlabs.ru>, "orika\@nvidia.com" <orika@nvidia.com>, "getelson\@nvidia.com" <getelson@nvidia.com> Organization: Red Hat / France References: <20201216085854.7842-1-jia.guo@intel.com> <1693993.jziF1hSf6E@thomas> <b85515ea6be742bca9cb8d33c9f2de9a@intel.com> <27289607.Vi9ZVq1Shk@thomas> <CAJFAV8w8SajHv2B3KDzzQS=PrSQX7hCnq46H8aHrCZqPGGzCWQ@mail.gmail.com> X-Operating-System: Red Hat Enterprise Linux Server 7.8 X-URL: http://www.redhat.com Date: Thu, 07 Jan 2021 15:27:28 +0100 In-Reply-To: <CAJFAV8w8SajHv2B3KDzzQS=PrSQX7hCnq46H8aHrCZqPGGzCWQ@mail.gmail.com> (David Marchand's message of "Thu, 7 Jan 2021 14:45:17 +0100") Message-ID: <86ft3clt4f.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dodji@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Subject: Re: [dpdk-dev] [dpdk-dev v2 1/2] ethdev: add new tunnel type for ecpri X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> David Marchand <david.marchand@redhat.com> writes: > On Thu, Jan 7, 2021 at 2:33 PM Thomas Monjalon <thomas@monjalon.net> wrote: >> > Yes that may break the ABI but fortunately the checking-abi-compatibility tool shows negative :) , thanks Ferruh' s guide. >> > https://github.com/ferruhy/dpdk/actions/runs/468859673 >> >> That's very strange. An enum value is changed. >> Why it is not flagged by libabigail? > > I suspect this is because the enum is not referenced in any object... > all I see is an integer with a comment that it should be filled with > values from the enum. I am not sure about the full context but David is right in theory. If the enum is not reachable from a publically exported interface (function or global variable) then it won't we considered as being part of the ABI and changes to that enum won't be reported. I am not sure if that is what is happening in this particular case, though. Cheers, -- Dodji