From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5EDC0A0597; Wed, 8 Apr 2020 09:21:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ECE391BFDC; Wed, 8 Apr 2020 09:21:13 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 12C111BFC4 for ; Wed, 8 Apr 2020 09:21:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586330471; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k+WGuJmGEJD6ws/Hk65wC/3peYqzleJJfhfI+0hS25g=; b=FWRVNtQMJmozfbW+uc6MstG/EUyWblC5lu5Jif2tZbyZMV45LJGdZiov2NCTPB5px+Ep4D CtMzCfylbF05R+u/0zrqAJfMn/VdrHmWIIo67GvYmPfKjtIO9r4FbO+HqvocaIqh6nb1yH 80+NCE02uisphR3Z1+W87O/JUns9aa8= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-264-sDwadcSWNT2LPJ2F25XwQQ-1; Wed, 08 Apr 2020 03:20:22 -0400 X-MC-Unique: sDwadcSWNT2LPJ2F25XwQQ-1 Received: by mail-wm1-f69.google.com with SMTP id n127so1988810wme.4 for ; Wed, 08 Apr 2020 00:20:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:organization:references:date :in-reply-to:message-id:user-agent:mime-version; bh=5GI+YY/+p7KX+2Yd9cJYMONcSciS+ou2bQC1wYawy7E=; b=hVlb6Tb9pAOGBpMcnMiXY8CPxVnQe2ENtF0WwzXdaZgO7x1Xem1VCT4fDCwYNgqSd1 HLLnW2iAb00WTrGnL7lK0IJ3UFMVIa4WNaYopzexfPrFPMR+9firTeZpDwoF4nuaYVdc Dp1iIDljfsPQMb1d0ByJqPjl/cZWYdzEIK9W7vnIRJCEWIovhNuOFTLEo4biSf8r4zwV LLCxnBV8pCthm1yDUP70XQKyMSdDVuIS29jmAr6agF/HQF3i0GdfYZlPXYqPqmPJ9hLK Sl2X4mmLxc3PsxUTP0fs/v2gjDb9PMXCcCXxSWod53wxoqcPSvYE2cTYvglqpjeDlzKn n8Iw== X-Gm-Message-State: AGi0PuYK3kr1IBsPaTIxA+IBpwZyUcn6COuwuNhzOSff+Wou53K17iNb HwyzPzXQtBl/dO0Iqq7gDruw+6TE9vT1/jXTvu2sTd4ZunLoka6C2Crg59PFvzhcp1yHhC+dFFY quHc= X-Received: by 2002:a5d:4047:: with SMTP id w7mr6646469wrp.167.1586330421012; Wed, 08 Apr 2020 00:20:21 -0700 (PDT) X-Google-Smtp-Source: APiQypKixVTQP2vUF5AUNTXgdaEZGQ0ZLnYF+7fZPtZAFxudrY6vJeDPz9gnO00t2ee53UMQj8YA0A== X-Received: by 2002:a5d:4047:: with SMTP id w7mr6646443wrp.167.1586330420673; Wed, 08 Apr 2020 00:20:20 -0700 (PDT) Received: from localhost (91-166-131-130.subs.proxad.net. [91.166.131.130]) by smtp.gmail.com with ESMTPSA id l15sm2296473wmi.48.2020.04.08.00.20.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Apr 2020 00:20:19 -0700 (PDT) From: Dodji Seketeli X-Google-Original-From: Dodji Seketeli Received: by localhost (Postfix, from userid 1001) id 081E51A4B72; Wed, 8 Apr 2020 09:20:18 +0200 (CEST) To: Hemant Agrawal Cc: Dodji Seketeli , David Marchand , "Hemant Agrawal \(OSS\)" , "Yigit\, Ferruh" , dev , Neil Horman , Thomas Monjalon Organization: Red Hat / France References: <20200302145829.27808-1-hemant.agrawal@nxp.com> <877dzscx97.fsf@redhat.com> X-Operating-System: Red Hat Enterprise Linux Server 7.7 X-URL: http://www.redhat.com Date: Wed, 08 Apr 2020 09:20:18 +0200 In-Reply-To: (Hemant Agrawal's message of "Tue, 7 Apr 2020 10:25:00 +0000") Message-ID: <86v9mao34d.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 00/16] NXP DPAAx fixes and enhancements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello Hemant, Hemant Agrawal writes: [...] >> >> > > [Hemant] >> >> > > As per the logs: >> >> > > >> >> > > Variables changes summary: 1 Removed, 2 Changed, 0 Added >> >> > > variables >> >> > > 1 Removed variable: >> >> > > 'dpaa2_portal_dqrr per_lcore_dpaa2_held_bufs' >> >> > {per_lcore_dpaa2_held_bufs@@DPDK_20.0} >> >> > > 2 Changed variables: >> >> > > [C]'dpaa2_io_portal_t dpaa2_io_portal[128]' was changed at >> >> > dpaa2_hw_dpio.h:40:1: size of symbol changed from 5120 to 2048 >> >> > > [C]'dpaa2_io_portal_t per_lcore__dpaa2_io' was changed at >> >> > > dpaa2_hw_dpio.h:20:1: size of symbol changed from 40 to 16 >> >> > > >> >> > > Error: ABI issue reported for 'abidiff --suppr >> >> > > devtools/libabigail.abignore -- >> >> > no-added-syms --headers-dir1 reference/usr/local/include >> >> > --headers-dir2 install/usr/local/include >> >> > reference/dump/librte_bus_fslmc.dump >> >> > install/dump/librte_bus_fslmc.dump' [...] >> In the mean time, the tooling can be tought to ignore changes to these E= LF >> symbols, as you you guys all know already. >>=20 > [Hemant] will you please help me about adding entry to libagigail.abignor= e=20 > I tried doing following, but it is not helping > --- a/devtools/libabigail.abignore > +++ b/devtools/libabigail.abignore > @@ -2,10 +2,15 @@ > symbol_version =3D EXPERIMENTAL > [suppress_variable] > symbol_version =3D EXPERIMENTAL > + name =3D per_lcore__dpaa2_io > + name =3D dpaa2_io_portal > > ; Explicit ignore for driver-only ABI > [suppress_type] > name =3D rte_cryptodev_ops > + name =3D dpaa2_io_portal_t So, I understand you want the tooling to ignore changes to the global arrays dpaa2_io_portal and per_lcore__dpaa2_io, right? If that is correct, then here are the entries you should add to the libabigail.abignore file (please make sure the comments I have added there is accurate): [suppress_variable] # This global variable is exported by the binary but is not part = of # the logical ABI. In a perfect world, that variable should not = be # global, and we should access it via an accessor function. We d= o # that right now because of performance concerns. name =3D dpaa2_io_portal [suppress_variable] # This global variable is exported by the binary but is not part = of # the logical ABI. In a perfect world, that variable should not = be # global, and we should access it via an accessor function. We d= o # that right now because of performance concerns. name =3D per_lcore__dpaa2_io I hope this helps. Cheers, --=20 =09=09Dodji