From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 13701DD2 for ; Fri, 4 May 2018 09:35:29 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 94EBDFB67E; Fri, 4 May 2018 07:35:28 +0000 (UTC) Received: from [10.36.112.52] (ovpn-112-52.ams2.redhat.com [10.36.112.52]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B659D83B84; Fri, 4 May 2018 07:35:27 +0000 (UTC) To: Anatoly Burakov , dev@dpdk.org Cc: Hemant Agrawal , Shreyansh Jain References: <0016ba7532becb9168ec1f53bf578fffa2bd206b.1525333611.git.anatoly.burakov@intel.com> From: Maxime Coquelin Message-ID: <8708c256-8154-9552-1442-3f6a7baea6d1@redhat.com> Date: Fri, 4 May 2018 09:35:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Fri, 04 May 2018 07:35:28 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Fri, 04 May 2018 07:35:28 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH 18.05-RC3 v2] mem: add argument to mem event callbacks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2018 07:35:29 -0000 Hi Anatoly, On 05/03/2018 10:28 AM, Anatoly Burakov wrote: > It may be useful to pass arbitrary data to the callback (such > as device pointers), so add this to the mem event callback API. > > Signed-off-by: Anatoly Burakov > Suggested-by: Maxime Coquelin > --- > > Notes: > v2: > - Fixed compile issue in VFIO > > This is needed to fix virtio-user issues under new memory model, > in order to avoid iterating over all virtio devices on callback. > > drivers/bus/fslmc/fslmc_vfio.c | 5 +++-- > lib/librte_eal/common/eal_common_memalloc.c | 26 +++++++++++++++----------- > lib/librte_eal/common/eal_common_memory.c | 9 +++++---- > lib/librte_eal/common/eal_memalloc.h | 4 ++-- > lib/librte_eal/common/include/rte_memory.h | 13 ++++++++++--- > lib/librte_eal/linuxapp/eal/eal_vfio.c | 8 +++++--- > 6 files changed, 40 insertions(+), 25 deletions(-) Thanks for doing this change, FWIW: Tested-by: Maxime Coquelin Acked-by: Maxime Coquelin Regards, Maxime