From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C06DCA052A; Fri, 10 Jul 2020 19:01:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 932831DBEC; Fri, 10 Jul 2020 19:01:14 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id C245F1DBB1 for ; Fri, 10 Jul 2020 19:01:12 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id F048C5C0174; Fri, 10 Jul 2020 13:01:11 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Fri, 10 Jul 2020 13:01:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 10/cxD9LSaMIIvoban3WraKnAOgeTT9QXnOZ2jChs6U=; b=eMSeOgIBO4bvUrB7 Y1BZLW5nZSW5L4b5tKbGz5E6Wul91RiFYm+dH4p7dzjcJ7b+vLqxyggIWYNjpdnK XWkNJlJVNe0S7vNFWLYURFKVHJ5zDc5zuyxcQR5dkI1ESXDool8Ka3MRD6LofEIw cPlA4wl0DH7MuNU0Mn6u+PYYf3egvm1AZSpVHihugN+ZMxRdUJOPIMPKmzobquFo RLsDLGqk2FX4K5eBim/QHWMM17JzHCyFQTbzXfRlDSOlDKmFkmn4xG47yhZsKMqo BqAD+g9TjGRO1vzd9HCtOFQI5R2ab0nLTHDSyjujtvo22mnVXgdvcC8l5SRS0f2V a1cLCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=10/cxD9LSaMIIvoban3WraKnAOgeTT9QXnOZ2jChs 6U=; b=foKOq8yAzBegXHHVSBdhJmRDmWbccQWAMsAvVs478aILoq10FV/Xcwwlr HyOF8Z0V6CGguYJcs7gSTLtzMzFQcqh0fn3p9ezInrIfGTU3Y0LPVr6R6VgEcIMs YmajPCRgVawJjsXEKSn7uxobaxAXWDdR2mgHJiQT1sp4HXUl8BQk0P/1Ldo3Sewa SDyWvNz7O3Me55Pvr3WRa1Sdz+3jyZ7IqePHP8Pa+5PGhxgezdGYz4tA1UrsK4Vr 2+0UK+GJ6txSeSFgCiTKcf1GrGUbKi9MRsT2Xp+eDif1KC69mkv+02OK7vZ1ZRRR OsHYc85qermSgtmx1e9CbmS9ZV6/A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrvddugdduuddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B8C9930600B9; Fri, 10 Jul 2020 13:01:10 -0400 (EDT) From: Thomas Monjalon To: Stephen Hemminger Cc: dev@dpdk.org, Luca Boccassi , john.mcnamara@intel.com Date: Fri, 10 Jul 2020 19:01:09 +0200 Message-ID: <8714879.D7foGsqW7p@thomas> In-Reply-To: <20200613000055.7909-4-stephen@networkplumber.org> References: <20200613000055.7909-1-stephen@networkplumber.org> <20200613000055.7909-4-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 03/10] check_maintainers: change variable names X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 13/06/2020 02:00, Stephen Hemminger: > Use blocklist where blacklist was used and allowlist > where whitelist was used. This is a mechanical, not accurate, replacement. > Signed-off-by: Stephen Hemminger > Acked-by: Luca Boccassi > --- > --- a/devtools/check-maintainers.sh > +++ b/devtools/check-maintainers.sh > # empty line delimit end of section > - whitelist=$(files $flines) > - blacklist=$(files $xlines) > - match=$(aminusb "$whitelist" "$blacklist") > - if [ -n "$whitelist" ] ; then > + allowlist=$(files $flines) > + blocklist=$(files $xlines) > + match=$(aminusb "$allowlist" "$blocklist") > + if [ -n "$allowlist" ] ; then > printf "# $title " It is listing files with exclusions. The concept allow/block does not match here. I would prefer "files" and "xfiles" as variable names.