RE: [PATCH v9 04/28] net/rnp: support mailbox basic operate

["11" <caowenbo@mucse.com>]

Hi Stephen,

This flag add will ignore some warning error ?
> +error_cflags = ['-Wno-unused-value',
> +        '-Wno-unused-but-set-variable',
> +        '-Wno-unused-parameter',
> +        ]

Regards Wenbo

> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: 2025年2月11日 23:24
> To: Wenbo Cao <caowenbo@mucse.com>
> Cc: thomas@monjalon.net; dev@dpdk.org; ferruh.yigit@amd.com;
> andrew.rybchenko@oktetlabs.ru; yaojun@mucse.com
> Subject: Re: [PATCH v9 04/28] net/rnp: support mailbox basic operate
> 
> On Tue, 11 Feb 2025 16:49:54 +0800
> Wenbo Cao <caowenbo@mucse.com> wrote:
> 
> > diff --git a/drivers/net/rnp/base/meson.build
> > b/drivers/net/rnp/base/meson.build
> > new file mode 100644
> > index 0000000000..9ea88c3bff
> > --- /dev/null
> > +++ b/drivers/net/rnp/base/meson.build
> > @@ -0,0 +1,22 @@
> > +# SPDX-License-Identifier: BSD-3-Clause # Copyright(C) 2023 Mucse IC
> > +Design Ltd.
> > +
> > +sources = [
> > +        'rnp_mbx.c',
> > +]
> > +
> > +error_cflags = ['-Wno-unused-value',
> > +        '-Wno-unused-but-set-variable',
> > +        '-Wno-unused-parameter',
> > +        ]
> 
> Put the first item on new line, meson is like python and similar style
applies.
> It is disappointing that base code is so messy that you have to disable
warnings.
> 
> > +c_args = cflags
> > +foreach flag: error_cflags
> > +    if cc.has_argument(flag)
> > +        c_args += flag
> > +    endif
> > +endforeach