From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>,
"Tosatti, Giovanni" <GTosatti@empirix.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] Add option to dpdk-devbind.py to restore kernel driver binding
Date: Fri, 5 Apr 2019 16:50:34 +0100 [thread overview]
Message-ID: <872e9655-1829-7ac2-47a5-b95ccde2dac4@intel.com> (raw)
In-Reply-To: <c699013c-fad2-15d7-3237-698bc1b40fcf@intel.com>
On 4/10/2018 2:19 PM, Burakov, Anatoly wrote:
> On 10-Apr-18 11:55 AM, Tosatti, Giovanni wrote:
>> This patch adds a " --restore" option that will unbind all devices currently bound to DPDK PMDs back to the kernel driver.
>>
>> --- /opt/Perforce/gtosatti_centos/E-XMS/CSA-Mainline/Third-Party/dpdk/dpdk-16.07.orig/tools/dpdk-devbind.py
>> +++ /opt/Perforce/gtosatti_centos/E-XMS/CSA-Mainline/Third-Party/dpdk/dpdk-16.07/tools/dpdk-devbind.py
>> @@ -91,6 +91,9 @@
>> -u, --unbind:
>
> Two other issues:
>
> 1) the header is also wrongly formatted. it should read something like:
>
> tools/devbind: add option to restore kernel driver binding
>
> 2) the patch does not apply. not only it appears to be generated not
> from git-send-email but reads as a diff, but it looks like it's
> generated against a very old version of DPDK.
>
> You might want to look at DPDK contribution guidelines:
>
> http://dpdk.org/doc/guides/contributing/patches.html
>
> Thanks for your effort so far!
>
There is no response to change request for a year now.
I am marking the patch as rejected, if it is still relevant please send a
new version on top of latest repo.
Sorry for any inconvenience caused.
For reference patches:
https://patches.dpdk.org/patch/37774/
next prev parent reply other threads:[~2019-04-05 15:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 10:55 Tosatti, Giovanni
2018-04-10 12:55 ` Burakov, Anatoly
2018-04-10 13:19 ` Burakov, Anatoly
2019-04-05 15:50 ` Ferruh Yigit [this message]
2019-04-05 15:50 ` Ferruh Yigit
-- strict thread matches above, loose matches on Subject: below --
2018-04-10 11:10 Tosatti, Giovanni
2018-03-22 13:41 Tosatti, Giovanni
2018-03-22 14:19 ` Burakov, Anatoly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=872e9655-1829-7ac2-47a5-b95ccde2dac4@intel.com \
--to=ferruh.yigit@intel.com \
--cc=GTosatti@empirix.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).