Re: [EXT] [PATCH] crypto: fix misspelled key in qt format

[Ray Kinsella <mdr@ashroe.eu>]

Thomas Monjalon <thomas@monjalon.net> writes:

> 18/02/2022 07:11, Kusztal, ArkadiuszX:
>> From: Akhil Goyal <gakhil@marvell.com>
>> > Fix ABI warning.
>> > Add libabigail.abiignore rule.
>> 
>> I think what is worth noticing is a fact that after "random 'k' patch" addition of
>> [suppress_type]
>>         name = rte_crypto_asym_op
>> this problem does not show up.
>> 
>> But I think it is safer to send addition of
>> [suppress_type]
>>         name = rte_crypto_rsa_priv_key_type
>> anyway.
>> Will send v2.
>
> I don't understand why adding this rule,
> and the comment does say nothing about it:
> 	"Ignore name change of rsa qt key type"
>
> The ABI check is fine without above because of this existing exception:
>
> ; Ignore changes to rte_crypto_asym_op, asymmetric crypto API is experimental
> [suppress_type]
>         name = rte_crypto_asym_op
>
> So I will just drop the unjustified additional exception while pulling.
>
> Next time, please make sure such ABI exception is approved by more maintainers.

To be fair to those involved, I had been CC'ed on the v2 of this.
I didn't respond before the patch was merged however.

-- 
Regards, Ray K