From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 489F6A0C41; Wed, 6 Oct 2021 16:53:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1A2F941137; Wed, 6 Oct 2021 16:53:01 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id 81B7941136 for <dev@dpdk.org>; Wed, 6 Oct 2021 16:52:59 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 98B863200C20; Wed, 6 Oct 2021 10:52:57 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 06 Oct 2021 10:52:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= jSCxcKScsbAGxaS9JuFf63NEfr6uwMCQ8rtC//vIXGs=; b=lgUw4b6gRircJrPc WmDq+SiC1BaZR8gvRQbC1JaN1n9BQjIdbYqLqKAkcP/e3P6vnbpjsEniC0cv5frF lIRlrgMLTmOD6F/IDdJcW870s8UWJpDxvmxh0pr8AWr10k8Cr+silVVmrSJqA5SI eEGqjU/1iuVqtPvmCffl+o4ZDLMyMYrtWBGisnuv99H1KenMBTMwUhoJqByuxcS9 +o3VDMCMi3mwB9+arXm26sqcWShYv7qIxt9jh2ETzm9CFFGL2IC9DQ6obHWjH166 Pydvj6QYdHHVWfm8o+UK5HELRCHIlyAqZyB9I6bZo5vJGeKRUd2MnbLi2y+sqi50 p9kbSA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=jSCxcKScsbAGxaS9JuFf63NEfr6uwMCQ8rtC//vIX Gs=; b=ZYr3g6ExQL6OAzq0Ju2kLjGW2s3Jy5g4eHB2trkRTPfiBMzTpZFPn7W6r zHlaqSFGdxY7KWMZH1X4j98U/WkR5gnzIwHvOWR3+rqP8vXTKvG7vVbBNLzfuOSQ axG0KL+HkgyuOsgNgM4zZB/JhQQlAxf3aVQ+c7/0F3jHyLIOYKg6gN2Suoz6J/Z3 YBoV36dv9jyD6IZZJIfA0FpGgbZc8rZs9rvV2plpJKV4apXDXRowYqUzQHxuwXdR CC73X/rGw5jMvVm+hsXPMtMC2ImoY+5FEQEn27v3q3LnT/4adTd/Y2A5pHvVsX3P 2eTSAboDi/EZiSQrKHN+G5754Hzmw== X-ME-Sender: <xms:SLhdYeClAMJCaupk2SMQ2_oLE4iyjw3A417UQEvIOstHnzA3-1iSAg> <xme:SLhdYYj8w6GHTVQ-0ZKkFpJkck9M6z5mtjrdqE5LP_d4bPBIwfxc2fjAlAllUD8Px AoyJ8kRyfjZxrvWwA> X-ME-Received: <xmr:SLhdYRkOFapRExOVrGBmAVILX7GqSrtNc_zhCdssAu146TtbB9xDupTtoQ9JExqchW-JlJ0m8f17KJ7BFGveTnnwEaPLhpwJ9TMvsVAkh90> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudeliedgjeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: <xmx:SLhdYczikEc3t97OkFqD_xMslxWcGjXDAqQr9f2rSdB96YJctLl32w> <xmx:SLhdYTSdx9xWe49yOm4tTnZwDM2HShOwx9g89xki6awnsRGDxyaSVA> <xmx:SLhdYXZDEd06sGy0muvqVFByxMoYwB08Rsm3-HhuUJghZHR_gpVx5Q> <xmx:SbhdYaL7XM0Qjg3EGzUuQoHyx48JU9OAih45gfz0P-MdSgBIh1_gwg> Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 6 Oct 2021 10:52:55 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: "Min Hu (Connor)" <humin29@huawei.com> Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com> Date: Wed, 06 Oct 2021 16:52:53 +0200 Message-ID: <8737697.d4JhdggRFk@thomas> In-Reply-To: <ba8fc7e1-40f0-f0dd-2310-32eb81b1b90b@intel.com> References: <20210914060219.45890-1-humin29@huawei.com> <ba8fc7e1-40f0-f0dd-2310-32eb81b1b90b@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] examples/kni: add dev close step when kni free X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 21/09/2021 09:48, Ferruh Yigit: > On 9/14/2021 7:02 AM, Min Hu (Connor) wrote: > > From: Huisong Li <lihuisong@huawei.com> > > > > This patch adds dev_close() step to release network adapter resources > > when kni free. > > > > Signed-off-by: Huisong Li <lihuisong@huawei.com> > > Signed-off-by: Min Hu (Connor) <humin29@huawei.com> > > Acked-by: Ferruh Yigit <ferruh.yigit@intel.com> > > Closing the port not directly related to the 'kni free', just both done before > exiting the app, so I would update the patch title to something like: > examples/kni: close port before exit Applied, with suggested title, thanks.