From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 68009A0540; Mon, 13 Jul 2020 12:23:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 48BF31D5E3; Mon, 13 Jul 2020 12:23:33 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 3EEDC1D5E2 for ; Mon, 13 Jul 2020 12:23:31 +0200 (CEST) IronPort-SDR: XMTZfwd54B+rvXtr78msVk4LhsZ6U5ylZE5qLMjnE8kxTlDaw9UMn3jPuj6u6MtQniBdpFWec/ MBBadk3K2RcA== X-IronPort-AV: E=McAfee;i="6000,8403,9680"; a="166697521" X-IronPort-AV: E=Sophos;i="5.75,347,1589266800"; d="scan'208";a="166697521" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2020 03:23:30 -0700 IronPort-SDR: R+Yi9aoMk3GRomYxzM+IN5MyCKoV+xikunV2D53HL78xkgJGc1hynYv7w87TD4K7KbX9EBzv1L 39YEgoAseCIA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,347,1589266800"; d="scan'208";a="390135881" Received: from vmedvedk-mobl.ger.corp.intel.com (HELO [10.213.224.143]) ([10.213.224.143]) by fmsmga001.fm.intel.com with ESMTP; 13 Jul 2020 03:23:28 -0700 To: Thomas Monjalon Cc: dev@dpdk.org, konstantin.ananyev@intel.com, bruce.richardson@intel.com, david.marchand@redhat.com, jerinj@marvell.com, mdr@ashroe.eu References: <6874799.X9nVCTG8Yq@thomas> From: "Medvedkin, Vladimir" Message-ID: <87399890-4cd0-e102-2072-f5d6a12ffde9@intel.com> Date: Mon, 13 Jul 2020 11:23:27 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <6874799.X9nVCTG8Yq@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 1/8] eal/x86: introduce AVX 512-bit type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Archived-At: List-Archive: Hi Thomas, On 10/07/2020 22:49, Thomas Monjalon wrote: > Please Cc those who participated in the review previously. > Adding Ray, Jerin, David. > > 10/07/2020 16:46, Vladimir Medvedkin: >> New data type to manipulate 512 bit AVX values. > [...] >> +#ifdef __AVX512F__ >> + >> +#define RTE_X86_ZMM_SIZE (sizeof(__m512i)) >> +#define RTE_X86_ZMM_MASK (ZMM_SIZE - 1) > > Why do you use tabs? Will resend v6 > >> + >> +typedef union __rte_x86_zmm { > > Double space Will fix in v6 > >> + __m512i z; >> + ymm_t y[RTE_X86_ZMM_SIZE / sizeof(ymm_t)]; >> + xmm_t x[RTE_X86_ZMM_SIZE / sizeof(xmm_t)]; >> + uint8_t u8[RTE_X86_ZMM_SIZE / sizeof(uint8_t)]; >> + uint16_t u16[RTE_X86_ZMM_SIZE / sizeof(uint16_t)]; >> + uint32_t u32[RTE_X86_ZMM_SIZE / sizeof(uint32_t)]; >> + uint64_t u64[RTE_X86_ZMM_SIZE / sizeof(uint64_t)]; >> + double pd[RTE_X86_ZMM_SIZE / sizeof(double)]; >> +} __rte_aligned(RTE_X86_ZMM_SIZE) __rte_x86_zmm_t; >> + >> +#endif /* __AVX512F__ */ > > You were supposed to undef the macros above. It was intentional. It could be used later by other libs, like XMM_SIZE: git grep -lw XMM_SIZE lib/librte_acl/acl_gen.c lib/librte_acl/acl_run.h lib/librte_acl/rte_acl.h lib/librte_eal/arm/include/rte_vect.h lib/librte_eal/ppc/include/rte_vect.h lib/librte_eal/x86/include/rte_vect.h lib/librte_hash/rte_thash.h > > Vladimir, after your recent contributions, > it seems you are not interested in details. > Please understand we have to maintain a project with consistency > and good doc. Please pay attention, thanks. > > -- Regards, Vladimir